Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone downstream with submodules #17

Closed
wants to merge 1 commit into from
Closed

Conversation

abhinav
Copy link

@abhinav abhinav commented Feb 8, 2023

Clones the downstream repository with --recurse-submodules
which will check out all submodules in the repository
after cloning.

This is necessary because pulumi-aws now uses submodules
(pulumi/pulumi-aws#2247).

Resolves pulumi/pulumi#12115
Resolves #15

Clones the downstream repository with `--recurse-submodules`
which will check out all submodules in the repository
after cloning.

This is necessary because pulumi-aws now uses submodules
(pulumi/pulumi-aws#2247).

Resolves pulumi/pulumi#12115
Resolves #15
@abhinav
Copy link
Author

abhinav commented Feb 8, 2023

🤦
I didn't check for an existing PR before doing this.
#16 already exists.
Closing in favor of #16.

@abhinav abhinav closed this Feb 8, 2023
@abhinav abhinav deleted the abhinav/submodules branch February 8, 2023 22:21
@abhinav abhinav restored the abhinav/submodules branch February 8, 2023 22:22
@abhinav
Copy link
Author

abhinav commented Feb 8, 2023

Reopening for the test because approach in #16 is different.

@abhinav abhinav reopened this Feb 8, 2023
@abhinav
Copy link
Author

abhinav commented Feb 8, 2023

...
	yarn run tsc && \
...yarn run v1.22.19
  error Couldn't find a package.json file in "/home/runner/work/action-test-provider-downstream/pulumi-aws/sdk/nodejs"

pulumi-aws/sdk/nodejs most definitely has a package.json.
This appears to be the make build_nodejs step in pulumi-aws faililng.

@abhinav abhinav closed this Mar 24, 2023
@abhinav abhinav deleted the abhinav/submodules branch March 24, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No longer works with pulumi-aws due to submodules. ci: Codegen / Test aws Downstream broken
1 participant