-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mediatech.by and mediatech.dev domains #1333
Conversation
@ugenk The PR is missing all of the required information that must accompany a PR (see the link to "contributing guidelines" below in the comment stream on github). If you are in the process of updating this PR, this can be ignored, but this PR won't proceed unless it is complete. |
Marking this as invalid so it stands out against the other PRs to re-review. Please read #1245 for important considerations related to requesting subdomains, and indicate if this request was submitted to work around limits. |
@ugenk please complete or close this PR, there is a lot missing and this is currently invalid and not possible to process. Additionally, please tick the boxes on the following which are true:
If we don't see a conforming response in the next 7 days, we'll go ahead and close this PR |
Hi! I've updated original comment with all the required data.
|
The rationale is still too basic - it does not provide the various eyes that read these enough information to process PR
But why is a PSL entry needed? What is the purpose or objective? Only stating that the company hosts clients on subdomains is not enough. |
Also you should look at #1337 as a recent rollback of a similar request, and #1342 which requested a core domain and #1343. We have no control over when or if the various projects, browsers, CA, etc add or remove entries, and those submissions where the domain name of their primary organziation domain in the header is being submitted are often affected in ways that harm the core domain. Do read those and confirm you want to proceed (once better rationale is provided as well, of course). |
Hi @ugenk, is this PR related to iOS 14.5 changes and Facebook advertising at all? If so please see below: Posting to let you know that Facebook has updated our guidance to include a validation flow run by Facebook staff. We encourage anyone requesting addition to the PSL as it relates to Facebook and iOS 14 interactions to make a request directly to Facebook via the form linked from our Help Center Article: https://www.facebook.com/business/help/126789292407737 In the form, given that you have already raised a pull request here, please include a link to this pull request in the description. We have agreed to do this to reduce the burden on PSL maintainers, ensure that you are asking to be on the PSL for the right reasons, and to allow us to collate and understand the issues that businesses are facing as part of this shift. After Facebook has assessed one of these requests we will make a recommendation or no recommendation decision, the PSL maintainers will make the final determination and we will coordinate with them on next steps accordingly. |
Hi We have to disable cookies tracking between different client sites hosted on our subdomains. This PR is not related to ios/facebook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- DNS Validation ok
- Tests ok
- Rationale ok
- No conflict with base
Approved
Description of Organization
Reason for PSL Inclusion
DNS verification via dig
Run Syntax Checker (make test)
Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration.
Description of Organization
Organization Website: https://mediatech.by https://mediatech.dev
We're company developing applications and solutions for TV and OTT
Reason for PSL Inclusion
We're hosting different clients applications/sites/api under our mediatech.by / mediatech.dev subdomains.
DNS Verification via dig
-->
make test
All the tests passed.