Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mediatech.by and mediatech.dev domains #1333

Merged
merged 1 commit into from
Jun 11, 2021
Merged

add mediatech.by and mediatech.dev domains #1333

merged 1 commit into from
Jun 11, 2021

Conversation

ugenk
Copy link
Contributor

@ugenk ugenk commented May 27, 2021

  • Description of Organization

  • Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration.

Description of Organization

Organization Website: https://mediatech.by https://mediatech.dev

We're company developing applications and solutions for TV and OTT

Reason for PSL Inclusion

We're hosting different clients applications/sites/api under our mediatech.by / mediatech.dev subdomains.

DNS Verification via dig

$  dig +short TXT _psl.mediatech.by
"https://github.com/publicsuffix/list/pull/1333"
$  dig +short TXT _psl.mediatech.dev
"https://github.com/publicsuffix/list/pull/1333"

-->

make test

All the tests passed.

@dnsguru
Copy link
Member

dnsguru commented May 27, 2021

@ugenk The PR is missing all of the required information that must accompany a PR (see the link to "contributing guidelines" below in the comment stream on github).

If you are in the process of updating this PR, this can be ignored, but this PR won't proceed unless it is complete.

@dnsguru dnsguru added the waiting-followup Blocked for need of follow-up label May 27, 2021
@dnsguru
Copy link
Member

dnsguru commented May 27, 2021

Marking this as invalid so it stands out against the other PRs to re-review. Please read #1245 for important considerations related to requesting subdomains, and indicate if this request was submitted to work around limits.

@dnsguru dnsguru added ❌invalid Invalid due to the formatting, premise, or other factor IOS-FB? PR related to Issue #1245 / needs https://www.facebook.com/help/contact/474057987130813 labels May 27, 2021
@dnsguru dnsguru self-assigned this Jun 1, 2021
@dnsguru
Copy link
Member

dnsguru commented Jun 2, 2021

@ugenk please complete or close this PR, there is a lot missing and this is currently invalid and not possible to process.

Additionally, please tick the boxes on the following which are true:
Submitter affirms the following:

  • We are listing any third party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)
  • This request was not submitted with the objective of working around other third party limits
  • The Guidelines were carefully read and understood, and this request conforms
  • The submission follows the guidelines on formatting

If we don't see a conforming response in the next 7 days, we'll go ahead and close this PR

@ugenk
Copy link
Contributor Author

ugenk commented Jun 3, 2021

Hi!

I've updated original comment with all the required data.

@dnsguru
Copy link
Member

dnsguru commented Jun 3, 2021

The rationale is still too basic - it does not provide the various eyes that read these enough information to process PR

We're hosting different clients applications/sites/api under our mediatech.by / mediatech.dev subdomains.

But why is a PSL entry needed? What is the purpose or objective?

Only stating that the company hosts clients on subdomains is not enough.

@dnsguru
Copy link
Member

dnsguru commented Jun 3, 2021

Also you should look at #1337 as a recent rollback of a similar request, and #1342 which requested a core domain and #1343.

We have no control over when or if the various projects, browsers, CA, etc add or remove entries, and those submissions where the domain name of their primary organziation domain in the header is being submitted are often affected in ways that harm the core domain. Do read those and confirm you want to proceed (once better rationale is provided as well, of course).

@n8schloss
Copy link

Hi @ugenk, is this PR related to iOS 14.5 changes and Facebook advertising at all? If so please see below:

Posting to let you know that Facebook has updated our guidance to include a validation flow run by Facebook staff. We encourage anyone requesting addition to the PSL as it relates to Facebook and iOS 14 interactions to make a request directly to Facebook via the form linked from our Help Center Article: https://www.facebook.com/business/help/126789292407737

In the form, given that you have already raised a pull request here, please include a link to this pull request in the description.

We have agreed to do this to reduce the burden on PSL maintainers, ensure that you are asking to be on the PSL for the right reasons, and to allow us to collate and understand the issues that businesses are facing as part of this shift.

After Facebook has assessed one of these requests we will make a recommendation or no recommendation decision, the PSL maintainers will make the final determination and we will coordinate with them on next steps accordingly.

@ugenk
Copy link
Contributor Author

ugenk commented Jun 11, 2021

Hi

We have to disable cookies tracking between different client sites hosted on our subdomains.

This PR is not related to ios/facebook.

@dnsguru dnsguru removed IOS-FB? PR related to Issue #1245 / needs https://www.facebook.com/help/contact/474057987130813 waiting-followup Blocked for need of follow-up ❌invalid Invalid due to the formatting, premise, or other factor labels Jun 11, 2021
Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • DNS Validation ok
  • Tests ok
  • Rationale ok
  • No conflict with base

Approved

@dnsguru dnsguru merged commit 43232aa into publicsuffix:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants