Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding adimo.co.uk #1343

Merged
merged 3 commits into from
Jun 2, 2021
Merged

Adding adimo.co.uk #1343

merged 3 commits into from
Jun 2, 2021

Conversation

eagerowl
Copy link
Contributor

@eagerowl eagerowl commented Jun 1, 2021

This is a follow up to a previous PR that was using our primary domain name. I've created this PR that uses a secondary domain that simply redirects to the primary. There is less risk as the secondary is not linked anywhere. #1342

  • Description of Organization

  • Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration.

Submitter affirms the following:

  • This request was not made to work around vendor limits other than those listed in rationale (see Issue #1245 as an example)
  • The Guidelines were carefully read and understood, and this request conforms
  • The submission follows the guidelines on formatting

Description of Organization

Organization Website: https://adimo.co & https://adimo.co.uk (for which this change applies)

We are a global shoppable technology provider for brands across the world. our clients include Nestlé, Unilever, SC Johnson and many other large multi national organisations. These brands use our technology to make their websites shoppable, allowing consumers to add products to their online retailer's shopping cart.

Reason for PSL Inclusion

Our clients frequently use our landing pages on social media and the urls to the pages have the subdomain campaigns.adimo.co. There are trust and security issues with this for our clients, consumers see this domain name in the url (such as on Twitter) and there is no mention of the brand name in the domain which confuses users. We desire to have a subdomain setup for each of our clients to circumvent this, such as clientA.adimo.co.uk, clientB.adimo.co.uk etc. The subdomain will give the brand what they desire and the inclusion in PSL will overcome the cookie issues we're having around security with multiple subdomains.

DNS Verification via dig

dig +short TXT _psl.adimo.co.uk
"https://github.com/publicsuffix/list/pull/1343"

make test

# TOTAL: 5
# PASS:  5
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0

Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration.

Domain adimo.co.uk expires Nov 2023, with auto renewal.

@dnsguru
Copy link
Member

dnsguru commented Jun 2, 2021

Please clarify if this is a submission made to work around the IOS/FB subdomaining issue introduced by Apple in IOS 14.5 (#1245)

@dnsguru dnsguru self-assigned this Jun 2, 2021
@dnsguru dnsguru added IOS-FB? PR related to Issue #1245 / needs https://www.facebook.com/help/contact/474057987130813 ❔❔ question Open question, please look / answer / respond labels Jun 2, 2021
@eagerowl
Copy link
Contributor Author

eagerowl commented Jun 2, 2021

Hello, I can confirm it is not, it is to allow our clients to have their own subdomains, which will allow us better cookie management and security.

@dnsguru dnsguru added NOT IOS FB Submitter attests PR is not #1245 related and removed IOS-FB? PR related to Issue #1245 / needs https://www.facebook.com/help/contact/474057987130813 ❔❔ question Open question, please look / answer / respond labels Jun 2, 2021
Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • DNS Validation ok
  • Tests ok
  • Rationale ok
  • No conflict with base

Approved

@dnsguru dnsguru merged commit c9070be into publicsuffix:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NOT IOS FB Submitter attests PR is not #1245 related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants