-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tracking] - HTTP Endpoint Cleanup #12958
Comments
This one is implemented in #12927 |
2 tasks
This was referenced Sep 29, 2023
Merged
3 tasks
we need to migrate lightclient to stop using the eth proto package and instead use just the v1alphav1 |
there are duplicate code in the builder types + how it uses ssz that could be cleaned up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🦄 HTTP Endpoint Cleanup Tracking
Feature Description
Now that all the validator client endpoints have been modified to be HTTP endpoints we need to clean up a few things before moving on to converting the rest of the Beacon API.
Tasks
s.V1Alpha1Server
to use thecore
package insteadbeacon-chain/rpc/eth/shared/structs_blocks.go
structs
package and group them into definition-ToConsensus
-FromConsensus
for each typeFromConsensus
functions should start with a nil checkFromConsensus
functions.fmt.Sprintf
is less verbose thanstrconv
.DecodeHexWithLength
inToConsensus
functionsValidateHex
/ValidateUint
HandleError
is always followed withreturn
http
package tohttputil
to avoid aliasing in every handler fileUintFromQuery
instead ofValidateUint
because it's strictly better (need to verify if that's the case first) and make the latter unimported. Would it make sense to create aHexFromQuery
function?rpc/eth
toapi/beacon
Bls
toBLS
in field namesThis issue should be closed after all of the above tasks are complete.
The text was updated successfully, but these errors were encountered: