HTTP API: /eth/v1/beacon/pool/bls_to_execution_changes
#12963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
changed the title
/eth/v1/beacon/pool/bls_to_execution_changes
james-prysm
requested review from
prestonvanloon,
terencechain,
nisdas,
saolyn and
rkapka
rkapka
requested changes
Sep 29, 2023
| @@ -87,13 +85,6 @@ func (_ *BeaconEndpointFactory) Create(path string) (*apimiddleware.Endpoint, er | |||
| case "/eth/v1/beacon/pool/proposer_slashings": | |||
| endpoint.PostRequest = &ProposerSlashingJson{} | |||
| endpoint.GetResponse = &ProposerSlashingsPoolResponseJson{} | |||
| case "/eth/v1/beacon/pool/bls_to_execution_changes": | |||
| endpoint.PostRequest = &SubmitBLSToExecutionChangesRequest{} | |||
| endpoint.GetResponse = &BLSToExecutionChangesPoolResponseJson{} | |||
There was a problem hiding this comment.
BLSToExecutionChangesPoolResponseJson can be removed
|
|
||
| // SubmitSignedBLSToExecutionChanges submits said object to the node's pool | ||
| // if it passes validation the node must broadcast it to the network. | ||
| func (s *Server) SubmitSignedBLSToExecutionChanges(w http.ResponseWriter, r *http.Request) { |
There was a problem hiding this comment.
I would simplify the name to SubmitBLSToExecutionChanges because there is no unsigned counterpart
Comment on lines
380
to
391
| if len(failures) > 0 { | ||
| failuresContainer := &helpers.IndexedVerificationFailure{Failures: failures} | ||
| err := grpc.AppendCustomErrorHeader(ctx, failuresContainer) | ||
| if err != nil { | ||
| http2.HandleError(w, fmt.Sprintf("One or more BLSToExecutionChange failed validation. Could not prepare BLSToExecutionChange failure information: %v", | ||
| err), http.StatusBadRequest) | ||
| return | ||
| } | ||
| http2.HandleError(w, fmt.Sprintf("One or more BLSToExecutionChange failed validation: %v", | ||
| err), http.StatusBadRequest) | ||
| return | ||
| } |
There was a problem hiding this comment.
This is not how it should be done for HTTP. It should be done the same way as when submitting atts:
if len(attFailures) > 0 {
failuresErr := &shared.IndexedVerificationFailureError{
Code: http.StatusBadRequest,
Message: "One or more attestations failed validation",
Failures: attFailures,
}
http2.WriteError(w, failuresErr)
}
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
rkapka
approved these changes
Oct 11, 2023
james-prysm
added
OK to merge
and removed
Ready For Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
implements
/eth/v1/beacon/pool/bls_to_execution_changes/eth/v1/beacon/pool/bls_to_execution_changesendpoints in full rest and removes the grpc implementation. some of the types must remain for the purposes of execution payload use, we may have a better migration path for these endpoints in the future.
Which issues(s) does this PR fix?
part of #12970