Use middleware to handle comma-separated query params #12995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
previously approved these changes
Oct 3, 2023
rauljordan
previously approved these changes
Oct 3, 2023
|
looks like tests failed for a real reason @rkapka |
rauljordan
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This is a more future-proof solution to handling comma-separated query parameters than #12966. We now use an http middleware to inject custom code before invoking handlers.
Unit testing this functionality from the level of individual handlers is no longer possible. A much better test is passing comma-separated values in e2e, which I added to the Beacon API evaluator.
Which issues(s) does this PR fix?
Part of #12958