Move block proposer out of v1alpha1 #12927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # beacon-chain/rpc/prysm/v1alpha1/validator/proposer.go
rkapka
force-pushed
the
move-proposing-to-core
branch
from
71dee7d
to
8c11e3d
Compare
rkapka
commented
Sep 20, 2023
| @@ -93,7 +93,7 @@ func MakeAttestationsFromBitlists(bl []bitfield.Bitlist) []*ethpb.Attestation { | |||
| } | |||
|
|
|||
| // MakeSyncContributionsFromBitVector creates list of sync contributions from list of bitvector. | |||
| func MakeSyncContributionsFromBitVector(bl []bitfield.Bitvector128) []*ethpb.SyncCommitteeContribution { | |||
There was a problem hiding this comment.
This had to change because I included proposer_utils_bench_test.go in the test bazel rule in the core package, which was not present in the v1alpha1 package. Including the file led to incompatibility with minimal config.
rkapka
commented
Sep 20, 2023
Comment on lines
+12
to
+16
| logrus.SetLevel(logrus.DebugLevel) | ||
| logrus.SetOutput(io.Discard) | ||
| prevConfig := params.BeaconConfig().Copy() | ||
| defer params.OverrideBeaconConfig(prevConfig) | ||
| params.OverrideBeaconConfig(params.MinimalSpecConfig()) |
There was a problem hiding this comment.
copied directly from v1alpha1
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Cleanup
What does this PR do? Why is it needed?
Moves proposer code out of
rpc/prysm/v1alpha1and intorpc/core. This has the following benefits:Servertype declared in v1alpha1