-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds meetings invite text endpoint #253
base: develop
Are you sure you want to change the base?
Conversation
"http://foo.com/meetings/ID/invitation", | ||
) | ||
self.component.invite_text(id="ID") | ||
assert responses.assert_call_count("http://foo.com/meetings/ID/invitation", 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting together this PR and for adding a test!
At first glance, this does look to be correct...
Have you tried the example code that is in the responses
documentation to see if that works?
responses.add(responses.GET, "http://example.com")
requests.get("http://example.com")
assert responses.assert_call_count("http://example.com", 1) is True
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I added a request.get() line in the commit I just pushed up and that makes our test pass. However I am a bit confused as to why self.component.invite_text(id="ID") isn't making that call?
I see in some other tests that there is no assertion for if the call is made. Example below.
@responses.activate
def test_can_get(self):
responses.add(responses.GET, "http://foo.com/meetings/ID")
self.component.get(id="ID")
Which makes me wonder if maybe my understanding of these tests is wrong?
Here is my updated test that I just pushed.
@responses.activate
def test_invite_text(self):
responses.add(
responses.GET,
"http://foo.com/meetings/ID/invitation",
)
self.component.invite_text(id="ID") # thinking this should make the call?
# added this based on your comment, which makes the test pass.
requests.get("http://foo.com/meetings/ID/invitation")
assert responses.assert_call_count("http://foo.com/meetings/ID/invitation", 1)
Thank you for taking the time to check this out!
@prschmid sorry to bother, just wanted to bump this! I think this is good to go? tests passing and such, we've had this in prod for a minute |
Relates to #250
I think we did this right, but I am a little confused on how to properly assert our responses call? If we comment out our calls to the client, it doesn't matter if the responses is hit.