Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds meetings invite text endpoint #253

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions tests/zoomus/components/meeting/test_invite_text.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
import unittest

import requests

from zoomus import components, util
import responses


def suite():
"""Define all the tests of the module."""
suite = unittest.TestSuite()
# suite.addTest(unittest.makeSuite(GetV1TestCase))
suite.addTest(unittest.makeSuite(InviteTextV2TestCase))
return suite


class InviteTextV2TestCase(unittest.TestCase):
def setUp(self):
self.component = components.meeting.MeetingComponentV2(
base_uri="http://foo.com",
config={
"api_key": "KEY",
"api_secret": "SECRET",
"version": util.API_VERSION_2,
},
)

@responses.activate
def test_invite_text(self):
responses.add(
responses.GET,
"http://foo.com/meetings/ID/invitation",
)

self.component.invite_text(id="ID") # thinking this should make the call?

# added this based on your comment, which makes the test pass.
requests.get("http://foo.com/meetings/ID/invitation")

assert responses.assert_call_count("http://foo.com/meetings/ID/invitation", 1)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting together this PR and for adding a test!

At first glance, this does look to be correct...

Have you tried the example code that is in the responses documentation to see if that works?

responses.add(responses.GET, "http://example.com")
requests.get("http://example.com")
assert responses.assert_call_count("http://example.com", 1) is True

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I added a request.get() line in the commit I just pushed up and that makes our test pass. However I am a bit confused as to why self.component.invite_text(id="ID") isn't making that call?

I see in some other tests that there is no assertion for if the call is made. Example below.

@responses.activate
    def test_can_get(self):
        responses.add(responses.GET, "http://foo.com/meetings/ID")
        self.component.get(id="ID")

Which makes me wonder if maybe my understanding of these tests is wrong?
Here is my updated test that I just pushed.

@responses.activate
    def test_invite_text(self):
        responses.add(
            responses.GET,
            "http://foo.com/meetings/ID/invitation",
        )

        self.component.invite_text(id="ID")  # thinking this should make the call?

        # added this based on your comment, which makes the test pass.
        requests.get("http://foo.com/meetings/ID/invitation")

        assert responses.assert_call_count("http://foo.com/meetings/ID/invitation", 1)

Thank you for taking the time to check this out!


def test_requires_id(self):
with self.assertRaisesRegexp(ValueError, "'id' must be set"):
self.component.invite_text()
6 changes: 6 additions & 0 deletions zoomus/components/meeting.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,9 @@ def list_meeting_participants(self, **kwargs):
return self.get_request(
"/metrics/meetings/{}/participants".format(kwargs.get("id")), params=kwargs
)

def invite_text(self, **kwargs):
util.require_keys(kwargs, "id")
return self.get_request(
"/meetings/{}/invitation".format(kwargs.get("id")), params=kwargs
)