-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds meetings invite text endpoint #253
Open
pinkmanJ
wants to merge
2
commits into
prschmid:develop
Choose a base branch
from
pinkmanJ:meeting-invite-text
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
import unittest | ||
|
||
import requests | ||
|
||
from zoomus import components, util | ||
import responses | ||
|
||
|
||
def suite(): | ||
"""Define all the tests of the module.""" | ||
suite = unittest.TestSuite() | ||
# suite.addTest(unittest.makeSuite(GetV1TestCase)) | ||
suite.addTest(unittest.makeSuite(InviteTextV2TestCase)) | ||
return suite | ||
|
||
|
||
class InviteTextV2TestCase(unittest.TestCase): | ||
def setUp(self): | ||
self.component = components.meeting.MeetingComponentV2( | ||
base_uri="http://foo.com", | ||
config={ | ||
"api_key": "KEY", | ||
"api_secret": "SECRET", | ||
"version": util.API_VERSION_2, | ||
}, | ||
) | ||
|
||
@responses.activate | ||
def test_invite_text(self): | ||
responses.add( | ||
responses.GET, | ||
"http://foo.com/meetings/ID/invitation", | ||
) | ||
|
||
self.component.invite_text(id="ID") # thinking this should make the call? | ||
|
||
# added this based on your comment, which makes the test pass. | ||
requests.get("http://foo.com/meetings/ID/invitation") | ||
|
||
assert responses.assert_call_count("http://foo.com/meetings/ID/invitation", 1) | ||
|
||
def test_requires_id(self): | ||
with self.assertRaisesRegexp(ValueError, "'id' must be set"): | ||
self.component.invite_text() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting together this PR and for adding a test!
At first glance, this does look to be correct...
Have you tried the example code that is in the
responses
documentation to see if that works?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I added a request.get() line in the commit I just pushed up and that makes our test pass. However I am a bit confused as to why self.component.invite_text(id="ID") isn't making that call?
I see in some other tests that there is no assertion for if the call is made. Example below.
Which makes me wonder if maybe my understanding of these tests is wrong?
Here is my updated test that I just pushed.
Thank you for taking the time to check this out!