Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting invite text? #250

Open
ckcollab opened this issue Jan 21, 2022 · 4 comments
Open

Getting invite text? #250

ckcollab opened this issue Jan 21, 2022 · 4 comments
Assignees

Comments

@ckcollab
Copy link

Heyo, thanks so much for releasing and maintaining this project, so far has been a breeze to work with!

I am trying to implement this fella and it doesn't seem to be in this project:
https://marketplace.zoom.us/docs/api-reference/zoom-api/meetings/meetinginvitation

Is this something I should maybe try to PR, or is there an easy way to access this api with the existing version of zoomus .. or is this kind of a silly API to hit anyway?

Appreciate any advice, thanks!

@prschmid
Copy link
Owner

Hi @ckcollab! Thank you for your patience in waiting for my response and for bringing up this idea. You are definitely more than welcome to submit a PR for that functionality. It's always great when the community adds in functionality that they need so that everyone can benefit. I'll try to review it as quickly as I can so that we can get it merged in.

Glad to hear that you are finding this project useful!

@ckcollab
Copy link
Author

ckcollab commented Feb 8, 2022

@prschmid do you have any time soon to take a peek at that PR? we'd love to get this merged before our release -- if it's a pain no biggy, we can just point at our fork for the time being!

@prschmid
Copy link
Owner

@ckcollab I did take a look at the PR and it looks like the test that was written was failing - I did review that PR and the changes are pending. If you have time, feel free to pull that PR and make the appropriate fix. Once the tests are passing, I will happily merge that PR. Thanks!

@ckcollab
Copy link
Author

Ugh! Sorry I missed your reply in there, thanks for taking a look at it back a few weeks ago. I think we demonstrated a problem in that PR, but maybe we're misunderstanding how responses works in this context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants