forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types): Deprecate the DBBackend variable in favor of the Tendermint Config's db_backend value. #51
Merged
dwedul-figure
merged 34 commits into
release-pio/v0.45.x
from
dwedul/10948-remove-dbbackend-var
Feb 15, 2022
Merged
feat(types): Deprecate the DBBackend variable in favor of the Tendermint Config's db_backend value. #51
dwedul-figure
merged 34 commits into
release-pio/v0.45.x
from
dwedul/10948-remove-dbbackend-var
Feb 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Upgrade Rosetta to v0.7.2
…os-sdk into release-pio/v0.44.3.1
release: update release notes
* convert message router to interface * Add setter for msg service interface * Adding a custom fee charging handler, so that if provenance want's they can charge fees for certain msg types. * refactored variable name. * Fixing comments on changed files. * Return transaction context from runTx * emitting events from AdditionalMsgFeeHandler, since authz and wasm calls need the event too. * test: Fix comppile issues on existing tests * handling error on failure to charge additional fee. * fixing err while deliverTx. * Update return values to have err at end * Fix tests * Refactor to remove pio specific stuff Co-authored-by: arnabmitra <[email protected]>
…-sdk into release-pio/v0.44.5
…t takes care of the order of ante and base events, since ante events are charged before all events and fee events are charged at the end.
…-sdk into release-pio/v0.44.5
feat: pio/v0.44.5
…ated fix: Error from fee invoker is not getting propagated properly.
dwedul-figure
changed the title
feat(types): Deprecate the DBBackend variable in favor of the Tendermint Config's db-backend value.
feat(types): Deprecate the DBBackend variable in favor of the Tendermint Config's db_backend value.
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replicates the changes in the Cosmos-SDK PR 11188.
This PR deprecates the
types.DBBackend
variable andtypes.NewLevelDB
function. It replaces them with a newtypes.NewDB
function that accepts a db backend parameter. Uses ofNewLevelDB
were replaced with calls toNewDB
and the db backend value comes from the tendermint configdb-backend
entry. The simapp stuff doesn't have the tendermint config, so a config field and flag was added in order to know the db backend value to use for them.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
addedN/A!
to the type prefix if API or client breaking changefollowed the guidelines for building modulesN/ACHANGELOG.md
updated the relevant documentation or specificationN/AReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change