Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): Deprecate the DBBackend variable in favor of the Tendermint Config's db_backend value. #51

Merged
merged 34 commits into from
Feb 15, 2022

Conversation

dwedul-figure
Copy link

@dwedul-figure dwedul-figure commented Feb 15, 2022

Description

This replicates the changes in the Cosmos-SDK PR 11188.

This PR deprecates the types.DBBackend variable and types.NewLevelDB function. It replaces them with a new types.NewDB function that accepts a db backend parameter. Uses of NewLevelDB were replaced with calls to NewDB and the db backend value comes from the tendermint config db-backend entry. The simapp stuff doesn't have the tendermint config, so a config field and flag was added in order to know the db backend value to use for them.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change N/A
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules N/A
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification N/A
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

fkneeland-figure and others added 30 commits December 9, 2021 16:08
* convert message router to interface

* Add setter for msg service interface

* Adding a custom fee charging handler, so that if provenance want's they can charge fees for certain msg types.

* refactored variable name.

* Fixing comments on changed files.

* Return transaction context from runTx

* emitting events from AdditionalMsgFeeHandler, since authz and wasm calls need the event too.

* test: Fix comppile issues on existing tests

* handling error on failure to charge additional fee.

* fixing err while deliverTx.

* Update return values to have err at end

* Fix tests

* Refactor to remove pio specific stuff

Co-authored-by: arnabmitra <[email protected]>
…t takes care of the order of ante and base events, since ante events are charged before all events and fee events are charged at the end.
…ated

fix: Error from fee invoker is not getting propagated properly.
@dwedul-figure dwedul-figure marked this pull request as ready for review February 15, 2022 18:05
@dwedul-figure dwedul-figure changed the title feat(types): Deprecate the DBBackend variable in favor of the Tendermint Config's db-backend value. feat(types): Deprecate the DBBackend variable in favor of the Tendermint Config's db_backend value. Feb 15, 2022
@dwedul-figure dwedul-figure merged commit b529968 into release-pio/v0.45.x Feb 15, 2022
@dwedul-figure dwedul-figure deleted the dwedul/10948-remove-dbbackend-var branch May 20, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants