feat: Add msg service router interface #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey can charge fees for certain msg types.
arnabmitra
changed the title
arnabmitra
changed the base branch from
v0.44.3-pio
to
release-pio/v0.44.3.x
arnabmitra
requested review from
arnabmitra,
iramiller,
dwedul-figure,
derekadams,
fkneeland-figure and
egaxhaj
fkneeland-figure
approved these changes
Dec 17, 2021
iramiller
reviewed
Dec 17, 2021
baseapp/baseapp.go
Outdated
| @@ -133,6 +133,9 @@ type BaseApp struct { // nolint: maligned | |||
| // indexEvents defines the set of events in the form {eventType}.{attributeKey}, | |||
| // which informs Tendermint what to index. If empty, all events will be indexed. | |||
| indexEvents map[string]struct{} | |||
|
|
|||
| // msg fee handler | |||
| additionalMsgFeeHandler sdk.AdditionalMsgFeeHandler // ante handler for fee and auth | |||
There was a problem hiding this comment.
Since this is the core SDK and the msg fee module isn't part of the core cosmos sdk ... it feels like there shouldn't be anything named "msg fee handler" here...
They do in fact have context available in DeliverTx for middleware ... looks like that won't be an issue. |
derekadams
approved these changes
Dec 22, 2021
channa-figure
requested review from
iramiller,
derekadams and
fkneeland-figure
derekadams
approved these changes
Dec 23, 2021
iramiller
reviewed
Dec 23, 2021
arnabmitra
added a commit
that referenced
this pull request
Feb 1, 2022
* Updated and fixed Rosetta * add changelog * added prs to changelog * update release notes * feat: Add msg service router interface (#2) * convert message router to interface * Add setter for msg service interface * Adding a custom fee charging handler, so that if provenance want's they can charge fees for certain msg types. * refactored variable name. * Fixing comments on changed files. * Return transaction context from runTx * emitting events from AdditionalMsgFeeHandler, since authz and wasm calls need the event too. * test: Fix comppile issues on existing tests * handling error on failure to charge additional fee. * fixing err while deliverTx. * Update return values to have err at end * Fix tests * Refactor to remove pio specific stuff Co-authored-by: arnabmitra <[email protected]> * fixed @arnabmitra cr request * go mod vendor * cleanup * fmt * adding msg fee work to the changelog under unreleased section. * fixed tests * updated changelog to reflect provenance releases * remove unused db copy cmd * updated release notes * updating comment. * updating comment based on code review. * adding anteevents which were missed in the merge. * update release notes wording * baseapp changes the way they propagate antehandler events, this commit takes care of the order of ante and base events, since ante events are charged before all events and fee events are charged at the end. * Error from fee invoker is not getting propagated properly. * merging. * updating release notes. * Add missing iavl config size value to config parser Co-authored-by: fkneeland <[email protected]> Co-authored-by: fkneeland-figure <[email protected]> Co-authored-by: Carlton Hanna <[email protected]> Co-authored-by: Carlton Hanna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an interface to the msg router service for customization of msg handling. The current format for the msg_router_service is a struct. This design does not allow for adding custom behavior to the
MsgServiceRouter. Therefore, we added an interface to theMsgServiceRoutercalledIMsgServiceRouterthis allows for applications to add a custom router in the app.go file of their application. The default can also still be used that is defined in the baseapp.Provenance needed to modify the behavior of the router to add additional fees to specific msg types. i.e.) The MsgSend can have an additional 500nhash charge when executed. Therefore, fees would be addition charges + gas fees = total fees.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change