feat: pio/v0.44.5 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Upgrade Rosetta to v0.7.2
…os-sdk into release-pio/v0.44.3.1
release: update release notes
* convert message router to interface * Add setter for msg service interface * Adding a custom fee charging handler, so that if provenance want's they can charge fees for certain msg types. * refactored variable name. * Fixing comments on changed files. * Return transaction context from runTx * emitting events from AdditionalMsgFeeHandler, since authz and wasm calls need the event too. * test: Fix comppile issues on existing tests * handling error on failure to charge additional fee. * fixing err while deliverTx. * Update return values to have err at end * Fix tests * Refactor to remove pio specific stuff Co-authored-by: arnabmitra <[email protected]>
RELEASE_NOTES.md
Outdated
| See the [Cosmos SDK v0.44.5 Changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.44.5/CHANGELOG.md) for the exhaustive list of all changes. | ||
|
|
||
| **Full Changelog**: https://github.com/cosmos/cosmos-sdk/compare/v0.44.4...v0.44.5 | ||
| This release adds the fixes from cosmos-sdk upstream v0.44.4 and v0.44.5 to the updated Provenanced version v0.44.3 |
There was a problem hiding this comment.
TODO: Need to update the wording on this.
arnabmitra
reviewed
Jan 11, 2022
CHANGELOG.md
Outdated
|
|
||
| ## [v0.44.3-rosetta-fix](https://github.com/provenance-io/cosmos-sdk/tag/v0.44.3-rosetta-fix) | ||
|
|
||
| ### Improvements |
There was a problem hiding this comment.
ugh..we forgot to add the msg fee Improvement here, i will work on adding it :(
arnabmitra
reviewed
Jan 11, 2022
| @@ -2,7 +2,6 @@ FROM golang:1.17-alpine AS build | |||
| RUN apk add build-base git linux-headers | |||
| WORKDIR /work | |||
| COPY go.mod go.sum /work/ | |||
| COPY db/go.mod db/go.sum /work/db/ | |||
There was a problem hiding this comment.
This was deleted as the db/ folder does not exist in cosmos-sdk v0.44.5 and thus causes a make localnet-start to fail as well as failing tests.
channa-figure
suggested changes
Jan 11, 2022
RELEASE_NOTES.md
Outdated
| See the [Cosmos SDK v0.44.5 Changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.44.5/CHANGELOG.md) for the exhaustive list of all changes. | ||
|
|
||
| **Full Changelog**: https://github.com/cosmos/cosmos-sdk/compare/v0.44.4...v0.44.5 | ||
| This release adds the updates from cosmos-sdk upstream v0.44.4 and v0.44.5 to the msg fee and rosetta fixes added into the Provenanced version v0.44.3 |
There was a problem hiding this comment.
NIT: Can we say provenance fork instead of provenanced version?
arnabmitra
reviewed
Jan 11, 2022
…t takes care of the order of ante and base events, since ante events are charged before all events and fee events are charged at the end.
…-sdk into release-pio/v0.44.5
Codecov Report
@@ Coverage Diff @@
## release-pio/v0.44.5.x #21 +/- ##
========================================================
Coverage ? 60.83%
========================================================
Files ? 589
Lines ? 37611
Branches ? 0
========================================================
Hits ? 22881
Misses ? 12789
Partials ? 1941 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change