Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix topic internal indication #2846

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Fix topic internal indication #2846

merged 1 commit into from
Oct 31, 2022

Conversation

Haarolean
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added type/bug Something isn't working scope/backend labels Oct 30, 2022
@Haarolean Haarolean self-assigned this Oct 30, 2022
@Haarolean Haarolean requested a review from a team as a code owner October 30, 2022 15:39
@Haarolean Haarolean added hacktoberfest-accepted status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. labels Oct 30, 2022
@github-actions
Copy link

Custom deployment will be available at http://pr2846.internal.kafka-ui.provectus.io

@Haarolean Haarolean linked an issue Oct 31, 2022 that may be closed by this pull request
@Haarolean Haarolean merged commit 2f2e19d into master Oct 31, 2022
@Haarolean Haarolean deleted the issues/2759 branch October 31, 2022 08:46
@github-actions
Copy link

Custom deployment removed

javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
Narekmat pushed a commit that referenced this pull request Dec 12, 2022
Haarolean added a commit that referenced this pull request Mar 15, 2023
Haarolean added a commit that referenced this pull request Mar 20, 2023
* Revert "Fix topic internal indication (#2846)"

This reverts commit 2f2e19d.

* Fix #3135

* Add a nullable annotation for internalTopicPrefix

* Fix e2e tests

* upd isInternal

---------

Co-authored-by: VladSenyuta <[email protected]>
Haarolean added a commit that referenced this pull request Mar 27, 2023
* Revert "Fix topic internal indication (#2846)"

This reverts commit 2f2e19d.

* Fix #3135

* Add a nullable annotation for internalTopicPrefix

* Fix e2e tests

* upd isInternal

* upd checkShowInternalTopicsButton

* add manual cases

---------

Co-authored-by: Roman Zabaluev <[email protected]>
@Haarolean Haarolean removed the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label May 8, 2023
@github-actions
Copy link

github-actions bot commented May 8, 2023

Custom deployment removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to delete topics with names beginning with an underscore
2 participants