Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an internal topic name prefix #3505

Merged
merged 5 commits into from
Mar 20, 2023
Merged

Implement an internal topic name prefix #3505

merged 5 commits into from
Mar 20, 2023

Conversation

Haarolean
Copy link
Contributor

@Haarolean Haarolean commented Mar 15, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Closes #3135

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added type/bug Something isn't working scope/backend labels Mar 15, 2023
@Haarolean Haarolean self-assigned this Mar 15, 2023
@Haarolean Haarolean changed the title Issues/3135 Implement an internal topic name prefix Mar 16, 2023
@Haarolean Haarolean marked this pull request as ready for review March 16, 2023 13:38
@Haarolean Haarolean requested a review from a team as a code owner March 16, 2023 13:38
@Haarolean Haarolean requested a review from iliax March 16, 2023 13:45
@Haarolean Haarolean requested a review from a team as a code owner March 16, 2023 20:13
@Haarolean Haarolean merged commit d42e911 into master Mar 20, 2023
@Haarolean Haarolean deleted the issues/3135 branch March 20, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Show Internal Topics" not working
3 participants