Removed the unnecessary setuptools package dependency for Python package #7511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haberman
reviewed
May 17, 2020
| @@ -241,7 +241,7 @@ def get_option_from_sys_argv(option_str): | |||
| os.environ['PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION'] = 'cpp' | |||
|
|
|||
| # Keep this list of dependencies in sync with tox.ini. | |||
| install_requires = ['six>=1.9', 'setuptools'] | |||
| install_requires = ['six>=1.9'] | |||
There was a problem hiding this comment.
Per the comment, can you verify whether any change to tox.ini is required?
There was a problem hiding this comment.
Funnily enough - tox.ini was NOT in sync with this file, in the one way that it was missing setuptools :).
|
@haberman, and update on this? |
|
@haberman , Friendly ping? |
|
Friendly ping again? |
…age. The setuptools package was added to allow definition of namespaces using the now outdated (and discouraged from use) pkg_resources-style. The code here, for a long while now, uses a try/except (`ImportError`) protection around the setuptools code, and falls back to the more encoraged pkgutil-style. Removing this library won't affect any current workflow, and in the case of setuptools not found, it'll actually use a more modern (and encouraged) flow.
mishas
force-pushed
the
remove_setuptools_req
branch
from
e2a642c to
d13288e
Compare
|
Sorry for letting this slip. This looks fine to me, but I'd feel a little better if someone from our team who knows Python packaging stuff better than me took a look. @dlj-NaN could you take a look? |
|
@dlj-NaN, friendly ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setuptools package was added to allow definition of namespaces using
the now outdated (and discouraged from use) pkg_resources-style.
The code here, for a long while now, uses a try/except (
ImportError)protection around the setuptools code, and falls back to the more
encoraged pkgutil-style.
Removing this library won't affect any current workflow, and in the case
of setuptools not found, it'll actually use a more modern (and
encouraged) flow.
More info: https://packaging.python.org/guides/packaging-namespace-packages/