Skip to content

Commit

Permalink
Removed the unnecessary setuptools package dependency for Python pack…
Browse files Browse the repository at this point in the history
…age.

The setuptools package was added to allow definition of namespaces using
the now outdated (and discouraged from use) pkg_resources-style.

The code here, for a long while now, uses a try/except (`ImportError`)
protection around the setuptools code, and falls back to the more
encoraged pkgutil-style.

Removing this library won't affect any current workflow, and in the case
of setuptools not found, it'll actually use a more modern (and
encouraged) flow.
  • Loading branch information
mishas authored and acozzette committed Oct 13, 2020
1 parent c8f7633 commit 7daf0aa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ def get_option_from_sys_argv(option_str):
os.environ['PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION'] = 'cpp'

# Keep this list of dependencies in sync with tox.ini.
install_requires = ['six>=1.9', 'setuptools']
install_requires = ['six>=1.9']
if sys.version_info <= (2,7):
install_requires.append('ordereddict')
install_requires.append('unittest2')
Expand Down

0 comments on commit 7daf0aa

Please sign in to comment.