Integrate from Piper for C++, Java, and Python #8076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acozzette
reviewed
Nov 20, 2020
python/setup.py
Outdated
| @@ -254,7 +254,7 @@ def get_option_from_sys_argv(option_str): | |||
| os.environ['PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION'] = 'cpp' | |||
|
|
|||
| # Keep this list of dependencies in sync with tox.ini. | |||
| install_requires = ['six>=1.9'] | |||
| install_requires = ['six>=1.9', 'setuptools'] | |||
There was a problem hiding this comment.
This setuptools dependency was just recently deleted in #7511 so I think something must be going wrong if it's getting reverted.
acozzette
approved these changes
Nov 20, 2020
Python 3.8 changed the meaning and type of the tp_print slot.
Heresh83
reviewed
Nov 20, 2020
src/google/protobuf/arena.h
Outdated
| @@ -348,7 +348,7 @@ class PROTOBUF_EXPORT PROTOBUF_ALIGNAS(8) Arena final { | |||
| } | |||
| } | |||
|
|
|||
| // The following are routines are for monitoring. They will aproximate the | |||
There was a problem hiding this comment.
Are you suggesting that something needs to be added to CHANGES.txt here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: this integration must be merged, not squashed!