Protobuf can't be required on Ruby 2.6 #5161

tenderlove · 2018-09-17T21:10:54Z

What version of protobuf and what language are you using?
Version: v3.6.1
Language: Ruby

What operating system (Linux, Windows, ...) and version?

[aaron@TC ~]$ uname -a
Darwin TC.local 17.7.0 Darwin Kernel Version 17.7.0: Fri Jul  6 19:54:51 PDT 2018; root:xnu-4570.71.3~2/RELEASE_X86_64 x86_64

What runtime / compiler are you using (e.g., python version or gcc version)

[aaron@TC ~]$ ruby -v
ruby 2.6.0dev (2018-06-21 gc-compact-7-27 63710) [x86_64-darwin17]
last_commit=Yay!  We did more work!!!
[aaron@TC ~]$

What did you do?
Steps to reproduce the behavior:

Install Ruby 2.6 from source
Install google-protobuf gem
Require protobuf
See error when requiring the gem

What did you expect to see

The gem can be required

What did you see instead?

An error indicating the gem cannot be required. Here is the output on my terminal:

[aaron@TC ~]$ gem install google-protobuf
Successfully installed google-protobuf-3.6.1-universal-darwin
Parsing documentation for google-protobuf-3.6.1-universal-darwin
Done installing documentation for google-protobuf after 0 seconds
1 gem installed
[aaron@TC ~]$ ruby -r google/protobuf -e'puts "hello"'
Traceback (most recent call last):
	6: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:34:in `require'
	5: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:130:in `rescue in require'
	4: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:130:in `require'
	3: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.6.0/gems/google-protobuf-3.6.1-universal-darwin/lib/google/protobuf.rb:47:in `<top (required)>'
	2: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.6.0/gems/google-protobuf-3.6.1-universal-darwin/lib/google/protobuf.rb:50:in `rescue in <top (required)>'
	1: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
/Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- google/protobuf_c (LoadError)

Anything else we should know about your project / environment

I am working against a development version of Ruby.

Thanks!

The text was updated successfully, but these errors were encountered:

tenderlove · 2018-09-17T21:15:36Z

I was able to get this to work by manually specifying the platform is ruby:

[aaron@TC ~]$ gem install google-protobuf --platform=ruby
Fetching: google-protobuf-3.6.1.gem (100%)
Building native extensions. This could take a while...
Successfully installed google-protobuf-3.6.1
Parsing documentation for google-protobuf-3.6.1
Installing ri documentation for google-protobuf-3.6.1
Done installing documentation for google-protobuf after 3 seconds
1 gem installed
[aaron@TC ~]$ ruby -r google/protobuf -e'puts "hello"'
hello

I'm not sure if that's supported/expected, but it did get me unblocked. 😊

At the moment google-protobuf has issues building on Ruby 2.6 (protocolbuffers/protobuf#5161) We don't however want to skip other tests in 3 most important gems. Added test to fail when such skips are no longer needed. Closes #431

blowmage · 2018-10-30T16:43:02Z

I was able to get this to work by manually specifying the platform is ruby

This is the workaround we have been given when a new version of Ruby is released. The pre-compiled gems usually show up ~February, so until then we either have to set the platform and compile the gems when installing, or use the previous Ruby version until the pre-compiled gems are available.

One can install (and successfully require) google-protobuf on Ruby 2.6 when specifying build platform: protocolbuffers/protobuf#5161 (comment) That however does not play well with Bundler. I did not manage to override platform for single gem in bundle (being on OSX) nor to make bundler use pre-built gem for different platform. Apparently correctly pre-built gems will land in Feb: protocolbuffers/protobuf#5161 (comment) Similar kertuffle for JRuby: protocolbuffers/protobuf#1594 I'd rather skip it altogether now and re-evaluate in the future. [#431] [#432] [#461]

- and it requires special installation from protocolbuffers/protobuf#5161

This allows mutation/testing on Ruby 2.6. Related: https://twitter.com/pawelpacana/status/1080576829872844801 protocolbuffers/protobuf#5161 Private source to be removed once there's an official update on rubygems.org. Building https://github.com/protocolbuffers/protobuf: 1. compile C++ version to have src/proto ready for use 2. on macos: rake build clobber_package gem gem:native 3. on linux: rake build clobber_package gem gem:native as well, but make sure to update rake-compiler* dependencies to newest ones, update RUBY_CC_VERSION to include 2.6.0 and disable non-linux from ext.cross_platform

TeBoring · 2019-01-03T05:41:28Z

Although I can use ruby 2.6.0 to do rake test in ruby/ dir, I cannot pass ruby/compatibility_test/v3.0.0.
The error is that: File does not exist: google/protobuf

TeBoring · 2019-01-03T05:42:23Z

I tried to copy the lib dir generated by rake test in ruby dir.
It failed with: incompatible library version - /home/teboring/protobuf-ruby26-test2/ruby/compatibility_tests/v3.0.0/lib/google/protobuf_c.so

TeBoring · 2019-01-08T03:46:06Z

Fixed by #5537

mostlyobvious · 2019-01-08T11:18:24Z

Btw. do you plan to push rebuilt gems to rubygems.org as well?

romansklenar · 2019-01-08T11:34:08Z

Since this issue is part of v3.7.0, I'd guess it might take a while.

stephenh · 2019-01-08T14:27:22Z

Glancing at the diff, it doesn't seem tied to protobuf-3.7.0 (AFAICT); would be great to get this backported to a rubygem w/protobuf-3.6.x as currently it's blocking us moving to Ruby 2.6.

macmv · 2019-01-23T02:28:08Z

I'm still having issues after running this:

gem install google-protobuf --platform=ruby

It results in the same error as before, and down grading to ruby 2.5 is a pain on arch linux. Any fix?

TeBoring · 2019-02-01T04:34:56Z

I am currently blocked by creating gem on linux.
In our code, we depend on time.h to provide strptime. However, when compiling gem, it reports strptime is not supported.
According to https://stackoverflow.com/questions/43460876/trouble-including-function-declaration-for-strptime, I need to use -std=gnu11 to compile.
Does anyone know how to add this option to Rakefile?

mattwelke · 2019-02-03T05:01:21Z

@macmv Using rvm or rbenv is a good way to be able to install any Ruby version you need on your dev machine. They work on Arch Linux.

TeBoring · 2019-02-03T05:03:14Z

We have released 3.7.0-rc2, which supports ruby 2.6

…

On Sat, Feb 2, 2019 at 21:01 Matt Welke ***@***.***> wrote: @macmv <https://github.com/macmv> Using rvm or rbenv is a good way to be able to install any Ruby version you need on your dev machine. They work on Arch Linux. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#5161 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE9H5WVibXihI4FLs9Z1u7bBtyH_XjJoks5vJm01gaJpZM4WsuvV> .

See protocolbuffers/protobuf#5161

breisig · 2019-05-03T13:29:51Z

Looks like 3.7.0 was released with Ruby 2.6 support.

stAndrei · 2020-05-18T09:32:21Z

I was able to get this to work by manually specifying the platform is ruby:

[aaron@TC ~]$ gem install google-protobuf --platform=ruby
Fetching: google-protobuf-3.6.1.gem (100%)
Building native extensions. This could take a while...
Successfully installed google-protobuf-3.6.1
Parsing documentation for google-protobuf-3.6.1
Installing ri documentation for google-protobuf-3.6.1
Done installing documentation for google-protobuf after 3 seconds
1 gem installed
[aaron@TC ~]$ ruby -r google/protobuf -e'puts "hello"'
hello

I'm not sure if that's supported/expected, but it did get me unblocked. 😊

$ bundle config force_ruby_platform true

mostlyobvious mentioned this issue Sep 21, 2018

Start testing on ruby 2.6 RailsEventStore/rails_event_store#431

Closed

xfxyjwf added question ruby labels Sep 24, 2018

xfxyjwf assigned TeBoring Sep 24, 2018

TeBoring added P3 bug labels Oct 31, 2018

TeBoring added this to the v3.7.0 milestone Dec 1, 2018

danascheider mentioned this issue Jan 1, 2019

CI against Ruby 2.6.0 cucumber/cucumber-ruby#1338

Closed

3 tasks

olleolleolle added a commit to koic/cucumber-ruby that referenced this issue Jan 1, 2019

CI: Ruby 2.6.0 requires google-protobuf

e3da090

- and it requires special installation from protocolbuffers/protobuf#5161

mostlyobvious mentioned this issue Jan 2, 2019

Provide own native gems for Ruby 2.6 and Protobuf. RailsEventStore/rails_event_store#525

Merged

TeBoring closed this as completed Jan 8, 2019

blowmage mentioned this issue Jan 17, 2019

Add support and tests for Ruby 2.6 googleapis/google-cloud-ruby#2825

Closed

tadashi0713 mentioned this issue Jan 20, 2019

Run travis ci on ruby 2.6.0 although currently failing jnicklas/turnip#207

Merged

This was referenced Jan 21, 2019

Issues with ruby 2.6.0 anycable/anycable-rails#71

Closed

Docker with ruby alpine image throws error anycable/anycable-rails#70

Closed

nehashri mentioned this issue Jan 30, 2019

Update dependencies to support ruby 2.6 getgauge/gauge-ruby#102

Closed

adrianomitre mentioned this issue Feb 4, 2019

google-protobuf 3.6.1 gem incompatible with Ruby 2.6.0 #5675

Closed

blowmage mentioned this issue Feb 11, 2019

require 'google/protobuf' fails on ruby gem version 3.4.0 x86_64-linux #3509

Closed

yehaha9876 pushed a commit to yehaha9876/gitlab that referenced this issue Feb 20, 2019

Upgrade google-protobuf for Ruby 2.6 support

7f11d8a

See protocolbuffers/protobuf#5161

koic mentioned this issue Mar 7, 2019

Add support Ruby 2.6 for cucumber-message cucumber/common#571

Closed

davidgrayston mentioned this issue Mar 20, 2019

SDK-779: Regenerate protobuf files getyoti/yoti-ruby-sdk#29

Merged

aslakhellesoy mentioned this issue Jan 6, 2020

cucumber-messages incompatible with Ruby 2.7.0 cucumber/common#843

Closed

wppurking mentioned this issue Mar 4, 2020

google-protobuf gem can not loaded archfish/pulsar_sdk#6

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Protobuf can't be required on Ruby 2.6 #5161

Protobuf can't be required on Ruby 2.6 #5161

tenderlove commented Sep 17, 2018

tenderlove commented Sep 17, 2018

blowmage commented Oct 30, 2018

TeBoring commented Jan 3, 2019

TeBoring commented Jan 3, 2019

TeBoring commented Jan 8, 2019

mostlyobvious commented Jan 8, 2019

romansklenar commented Jan 8, 2019

stephenh commented Jan 8, 2019

macmv commented Jan 23, 2019

TeBoring commented Feb 1, 2019

mattwelke commented Feb 3, 2019

TeBoring commented Feb 3, 2019 via email

breisig commented May 3, 2019

stAndrei commented May 18, 2020

Protobuf can't be required on Ruby 2.6 #5161

Protobuf can't be required on Ruby 2.6 #5161

Comments

tenderlove commented Sep 17, 2018

tenderlove commented Sep 17, 2018

blowmage commented Oct 30, 2018

TeBoring commented Jan 3, 2019

TeBoring commented Jan 3, 2019

TeBoring commented Jan 8, 2019

mostlyobvious commented Jan 8, 2019

romansklenar commented Jan 8, 2019

stephenh commented Jan 8, 2019

macmv commented Jan 23, 2019

TeBoring commented Feb 1, 2019

mattwelke commented Feb 3, 2019

TeBoring commented Feb 3, 2019 via email

breisig commented May 3, 2019

stAndrei commented May 18, 2020