Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruby 2.6 gem build for linux #5537

Merged
merged 6 commits into from
Jan 8, 2019
Merged

Add ruby 2.6 gem build for linux #5537

merged 6 commits into from
Jan 8, 2019

Conversation

TeBoring
Copy link
Contributor

@TeBoring TeBoring commented Jan 4, 2019

No description provided.

@TeBoring
Copy link
Contributor Author

TeBoring commented Jan 7, 2019

Failed tests seem to be caused by the new mac image from kokoro.

@TeBoring
Copy link
Contributor Author

TeBoring commented Jan 7, 2019

This change modifies the script to build ruby gems, which should not be related to all these failing tests.

@TeBoring TeBoring merged commit c3340b2 into master Jan 8, 2019
@TeBoring TeBoring deleted the ruby-2.6-gem-master branch January 8, 2019 18:20
@Envek
Copy link

Envek commented Jan 21, 2019

Can anyone release a new version to the RubyGems? Thanks in advance.

@oggy
Copy link

oggy commented Jan 21, 2019

Pushing a new gem would be especially useful because one can't easily add this as a git dependency using bundler, unlike most other gems.

@Envek
Copy link

Envek commented Jan 21, 2019

@oggy this works for me:

# Gemfile
gem "google-protobuf", git: "https://github.com/protocolbuffers/protobuf"

Isn't it works for you?

@aadityataparia
Copy link

@Envek this doesn't work,

@oggy
Copy link

oggy commented Jan 28, 2019

@Envek No. It bundles ok, but because there are ruby files that need to be generated before the gem is built, you can't, e.g., require 'google/protobuf/struct_pb'.

@Envek
Copy link

Envek commented Jan 29, 2019

@oggy, @aadityataparia, @romansklenar, then try to set BUNDLE_FORCE_RUBY_PLATFORM environment variable to 1 to make Bundler ignore precompiled binaries and thus build them from scratch.

See #4460 (comment) for reference.

@romansklenar
Copy link

@Envek I tried it but unfortunately, it didn't help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants