CI against Ruby 2.6.0

[koic]

Summary

CI against Ruby 2.6.0.

Details

Ruby 2.6.0 has been released and this Ruby version is available on CircleCI.

• https://www.ruby-lang.org/en/news/2018/12/25/ruby-2-6-0-released/
• https://hub.docker.com/r/circleci/ruby/tags/

Checklist:

• I've added tests for my code
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[olleolleolle]

You need to add the 2.6 job to the "workflows/jobs" list at the end of the config.yml.

It does not run, yet.

[koic]

Oops! I updated this PR.

[luke-hill]

Are these failing because of the other PR around BigDecimal.new? Or something else?

Have you had time to triage @koic ?

[olleolleolle]

This build error:

An error occurred while loading ./spec/cucumber/cli/configuration_spec.rb.
Failure/Error: require 'gherkin/gherkin'

LoadError:
  cannot load such file -- google/protobuf_c

Seems like all of them are about that.

[danascheider]

Looks to be related to an issue with the google-protobuf gem protocolbuffers/protobuf#5161

[olleolleolle]

In order to move forward, I made an experimental addition to this PR: run the gem install as described in the Description of protocolbuffers/protobuf#5161

That did not work, yet. I'm sorry about moving too quickly.

[olleolleolle]

The protobuf Issue has been closed fixed in the other repo, but there's no new gem release yet.

https://rubygems.org/gems/google-protobuf

[luke-hill]

@koic If you add a new gem requirement of: gem 'google-protobuf', '~> 3.7.0.rc.2' this should in theory start passing.

If you've got time do you want to give that a go?

[koic]

Yep! I will try it.

[koic]

Unfortunately the following error occurred when running bundle update.

% bundle update google-protobuf
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Bundler could not find compatible versions for gem "google-protobuf":
  In Gemfile:
    google-protobuf (~> 3.7.0.rc.2)

    cucumber was resolved to 4.0.0.rc.1, which depends on
      gherkin (~> 6.0) was resolved to 6.0.15, which depends on
        cucumber-messages (~> 2.0.0) was resolved to 2.0.0, which depends on
          google-protobuf (= 3.6.1)

First of all, the dependency needs to be resolved.

cucumber-formatter-dots 1.1.2 (latest) requires cucumber-messages ~> 2.0.0.
https://rubygems.org/gems/cucumber-formatter-dots/versions/1.1.2

cucumber-messages 2.0.0 requires google-protobuf = 3.6.1.
https://rubygems.org/gems/cucumber-messages/versions/2.0.0

Each version needs to be bumped. I will open PR to cucumber-messages repo and cucumber-formatter-dots repo for resolving dependencies.

[koic]

The cucumber-messages gem release is required to resolve dependencies of cucumber-messages to google-protobuf. It has already been fixed in the cucumber-messages repo code base.
cucumber/common#571 (comment)

[koic]

Also cucumber-formatter-dots gem will wait for release as well.

[luke-hill]

The messages fix has been applied. This should automatically pull through

[aslakhellesoy]

Superseded by #1346

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.