-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app: Fix undef error for CHIP_CONFIG_ENABLE_READ_CLIENT #29238
Merged
mergify
merged 2 commits into
project-chip:master
from
wqx6:fix_undef_error/disable_read_client
Sep 19, 2023
Merged
app: Fix undef error for CHIP_CONFIG_ENABLE_READ_CLIENT #29238
mergify
merged 2 commits into
project-chip:master
from
wqx6:fix_undef_error/disable_read_client
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
September 14, 2023 03:59
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yunhanw-google
September 14, 2023 03:59
PR #29238: Size comparison from f47ce53 to 770feb8 Decreases (6 builds for cc32xx, efr32, psoc6)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
wqx6
force-pushed
the
fix_undef_error/disable_read_client
branch
from
September 15, 2023 03:41
770feb8
to
c6a3016
Compare
wqx6
force-pushed
the
fix_undef_error/disable_read_client
branch
from
September 15, 2023 03:46
c6a3016
to
e37105e
Compare
PR #29238: Size comparison from d104699 to e37105e Increases (5 builds for bl702, bl702l)
Decreases (1 build for efr32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Sep 15, 2023
andy31415
approved these changes
Sep 19, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…#29238) * app: Fix undef error for CHIP_CONFIG_ENABLE_READ_CLIENT * Add #include <app/AppBuildConfig.h> for all the files that check CHIP_CONFIG_ENABLE_READ_CLIENT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were checking CHIP_CONFIG_ENABLE_READ_CLIENT without including the config header that defines it.
Fixes #29213