Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Configuration for CHIP_CONFIG_ENABLE_READ_CLIENT looks broken #29213

Closed
bzbarsky-apple opened this issue Sep 13, 2023 · 0 comments · Fixed by #29238
Closed

[BUG] Configuration for CHIP_CONFIG_ENABLE_READ_CLIENT looks broken #29213

bzbarsky-apple opened this issue Sep 13, 2023 · 0 comments · Fixed by #29238
Labels
bug Something isn't working needs triage v1.2

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Sep 13, 2023 •
edited
Loading

Reproduction steps

Compiling with -Wundef added in build/config/compiler/BUILD.gn in the strict_warnings section leads to a bunch of failures because things check CHIP_CONFIG_ENABLE_READ_CLIENT without it actually being defined.

This seems very broken: why are the relevant files being compiled in an environment where that variable is not set to either 1 or 0? In particular, that means the compilation for those is broken if read client is enabled.

Looks like this was caused by #28149. For 1.2 we need to either fix this or back out that PR @wqx6 @andy31415 @woody-apple

Bug prevalence

Always

GitHub hash of the SDK that was being used

b02c984

Platform

core

Platform Version(s)

No response

Anything else?

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage v1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

app: Fix undef error for CHIP_CONFIG_ENABLE_READ_CLIENT wqx6/connectedhomeip
1 participant
@bzbarsky-apple