-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable YAML tests in CI. #28958
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:re-enable-yaml-tests-in-ci
Aug 30, 2023
Merged
Re-enable YAML tests in CI. #28958
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:re-enable-yaml-tests-in-ci
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #28958: Size comparison from 74e602d to afd4316 Full report (1 build for cc32xx)
|
bzbarsky-apple
force-pushed
the
re-enable-yaml-tests-in-ci
branch
from
August 29, 2023 22:25
afd4316
to
fbfc7a7
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
August 29, 2023 22:26
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 29, 2023 22:26
PR #28958: Size comparison from 74e602d to fbfc7a7 Decreases (3 builds for bl602, efr32, telink)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Two fixes, basically: 1. Make tests_with_command fail if the command fails. This would have caught the fact that we were not ending up with a useful test list. 2. Fix the test list determination for the CHIP_TOOL_PYTHON runner.
bzbarsky-apple
force-pushed
the
re-enable-yaml-tests-in-ci
branch
from
August 30, 2023 01:17
fbfc7a7
to
edc9292
Compare
PR #28958: Size comparison from f8690ac to edc9292 Decreases (1 build for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Aug 30, 2023
vivien-apple
approved these changes
Aug 30, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Sep 12, 2023
Two fixes, basically: 1. Make tests_with_command fail if the command fails. This would have caught the fact that we were not ending up with a useful test list. 2. Fix the test list determination for the CHIP_TOOL_PYTHON runner.
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Two fixes, basically: 1. Make tests_with_command fail if the command fails. This would have caught the fact that we were not ending up with a useful test list. 2. Fix the test list determination for the CHIP_TOOL_PYTHON runner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes, basically:
Note: The removal of the no-longer-generated .h file is fixing a bad merge from d9edecb.