[nrfconnect] Added kconfig option to enable extended discovery (#18367)

There is no kconfig that would allow to easily enable and disable extended discovery from config file. Added kconfig enabling extended discovery.
project-chip · Aug 17, 2023 · 4223961 · 4223961
1 parent e8b4892
commit 4223961
Show file tree

Hide file tree

Showing 10 changed files with 15 additions and 13 deletions.
diff --git a/config/nrfconnect/chip-module/Kconfig.defaults b/config/nrfconnect/chip-module/Kconfig.defaults
@@ -185,6 +185,11 @@ config CHIP_QSPI_NOR
     bool
     default y
 
+# Enable extended discovery
+config CHIP_EXTENDED_DISCOVERY
+    bool
+    default y
+
 # Enable OpenThread
 
 config NET_L2_OPENTHREAD

diff --git a/config/zephyr/Kconfig b/config/zephyr/Kconfig
@@ -244,6 +244,12 @@ config CHIP_OTA_IMAGE_INCLUDE_MCUBOOT
 
 endif
 
+config CHIP_EXTENDED_DISCOVERY
+	bool "Enable extended discovery"
+	help
+	  Enables the device to advertise commissionable service when not in the
+	  commissioning mode.
+
 module = MATTER
 module-str = Matter
 source "${ZEPHYR_BASE}/subsys/logging/Kconfig.template.log_config"

diff --git a/examples/all-clusters-app/nrfconnect/main/include/CHIPProjectConfig.h b/examples/all-clusters-app/nrfconnect/main/include/CHIPProjectConfig.h
@@ -31,5 +31,3 @@
 #define CHIP_DEVICE_CONFIG_USE_TEST_SETUP_DISCRIMINATOR 0xF00
 
 #define CHIP_DEVICE_CONFIG_SED_IDLE_INTERVAL 2000_ms32
-
-#define CHIP_DEVICE_CONFIG_ENABLE_EXTENDED_DISCOVERY 1
diff --git a/examples/chef/nrfconnect/CHIPProjectConfig.h b/examples/chef/nrfconnect/CHIPProjectConfig.h
@@ -35,5 +35,3 @@
 #define CHIP_CONFIG_ENABLE_ARG_PARSER 1
 
 #define CHIP_DEVICE_CONFIG_DISABLE_SHELL_PING 1
-
-#define CHIP_DEVICE_CONFIG_ENABLE_EXTENDED_DISCOVERY 1
diff --git a/examples/light-switch-app/nrfconnect/main/include/CHIPProjectConfig.h b/examples/light-switch-app/nrfconnect/main/include/CHIPProjectConfig.h
@@ -31,4 +31,3 @@
 #define CHIP_DEVICE_CONFIG_USE_TEST_SETUP_PIN_CODE 20202021
 #define CHIP_DEVICE_CONFIG_USE_TEST_SETUP_DISCRIMINATOR 0xF00
 #define CHIP_DEVICE_CONFIG_SED_IDLE_INTERVAL 2000_ms32
-#define CHIP_DEVICE_CONFIG_ENABLE_EXTENDED_DISCOVERY 1
diff --git a/examples/lighting-app/nrfconnect/main/include/CHIPProjectConfig.h b/examples/lighting-app/nrfconnect/main/include/CHIPProjectConfig.h
@@ -30,5 +30,3 @@
 // Use a default pairing code if one hasn't been provisioned in flash.
 #define CHIP_DEVICE_CONFIG_USE_TEST_SETUP_PIN_CODE 20202021
 #define CHIP_DEVICE_CONFIG_USE_TEST_SETUP_DISCRIMINATOR 0xF00
-
-#define CHIP_DEVICE_CONFIG_ENABLE_EXTENDED_DISCOVERY 1
diff --git a/examples/lock-app/nrfconnect/main/include/CHIPProjectConfig.h b/examples/lock-app/nrfconnect/main/include/CHIPProjectConfig.h
@@ -32,5 +32,3 @@
 #define CHIP_DEVICE_CONFIG_USE_TEST_SETUP_DISCRIMINATOR 0xF00
 
 #define CHIP_DEVICE_CONFIG_SED_IDLE_INTERVAL 2000_ms32
-
-#define CHIP_DEVICE_CONFIG_ENABLE_EXTENDED_DISCOVERY 1
diff --git a/examples/pump-app/nrfconnect/main/include/CHIPProjectConfig.h b/examples/pump-app/nrfconnect/main/include/CHIPProjectConfig.h
@@ -30,5 +30,3 @@
 // Use a default pairing code if one hasn't been provisioned in flash.
 #define CHIP_DEVICE_CONFIG_USE_TEST_SETUP_PIN_CODE 20202021
 #define CHIP_DEVICE_CONFIG_USE_TEST_SETUP_DISCRIMINATOR 0xF00
-
-#define CHIP_DEVICE_CONFIG_ENABLE_EXTENDED_DISCOVERY 1
diff --git a/examples/pump-controller-app/nrfconnect/main/include/CHIPProjectConfig.h b/examples/pump-controller-app/nrfconnect/main/include/CHIPProjectConfig.h
@@ -30,5 +30,3 @@
 // Use a default pairing code if one hasn't been provisioned in flash.
 #define CHIP_DEVICE_CONFIG_USE_TEST_SETUP_PIN_CODE 20202021
 #define CHIP_DEVICE_CONFIG_USE_TEST_SETUP_DISCRIMINATOR 0xF00
-
-#define CHIP_DEVICE_CONFIG_ENABLE_EXTENDED_DISCOVERY 1
diff --git a/src/platform/nrfconnect/CHIPDevicePlatformConfig.h b/src/platform/nrfconnect/CHIPDevicePlatformConfig.h
@@ -126,3 +126,7 @@
 #ifdef CONFIG_CHIP_DEVICE_TYPE
 #define CHIP_DEVICE_CONFIG_DEVICE_TYPE CONFIG_CHIP_DEVICE_TYPE
 #endif // CONFIG_CHIP_DEVICE_TYPE
+
+#ifdef CONFIG_CHIP_EXTENDED_DISCOVERY
+#define CHIP_DEVICE_CONFIG_ENABLE_EXTENDED_DISCOVERY 1
+#endif // CONFIG_CHIP_EXTENDED_DISCOVERY
Original file line number	Diff line number	Diff line change
Expand Up		@@ -31,5 +31,3 @@
		#define CHIP_DEVICE_CONFIG_USE_TEST_SETUP_DISCRIMINATOR 0xF00

		#define CHIP_DEVICE_CONFIG_SED_IDLE_INTERVAL 2000_ms32

		#define CHIP_DEVICE_CONFIG_ENABLE_EXTENDED_DISCOVERY 1
Original file line number	Diff line number	Diff line change
Expand Up		@@ -35,5 +35,3 @@
		#define CHIP_CONFIG_ENABLE_ARG_PARSER 1

		#define CHIP_DEVICE_CONFIG_DISABLE_SHELL_PING 1

		#define CHIP_DEVICE_CONFIG_ENABLE_EXTENDED_DISCOVERY 1
Original file line number	Diff line number	Diff line change
Expand Up		@@ -32,5 +32,3 @@
		#define CHIP_DEVICE_CONFIG_USE_TEST_SETUP_DISCRIMINATOR 0xF00

		#define CHIP_DEVICE_CONFIG_SED_IDLE_INTERVAL 2000_ms32

		#define CHIP_DEVICE_CONFIG_ENABLE_EXTENDED_DISCOVERY 1