Fix YAML script issues Dec 18 (#31060)

* Fixes issues: 87,88,89,90,91,93,94 Modified tests: TC_G_2_3 TC_IDM_4_2 TC_I_2_2 TC_OPSTATE_2_2 TC_OPSTATE_2_5 TC_REFALM_2_2 TC_S_2_3 TC_S_3_1 * Auto generated files * Fixes issue: 81, 84 TC_DISHM_1_1 TC_DISHM_2_1 TC_SWTCH_1_1 TC_SWTCH_2_1 TC_SWTCH_2_2 TC_SWTCH_3_2 TC_TCCM_2_1 * Restyled by whitespace * Fixes issue: 95. 96 * Modified init.py to run the test APPOBSERVER againts TV-app * Remove TC-APPOBSERVER-1.13 test * Fixes issue: 83 * Remove APPOBSERVER from init.py * Updated TC-S-3.1 manual test. * Restyled by whitespace --------- Co-authored-by: Restyled.io <[email protected]>
project-chip · Jan 30, 2024 · 3862744 · 3862744
1 parent 3abdee7
commit 3862744
Show file tree

Hide file tree

Showing 23 changed files with 1,131 additions and 637 deletions.
diff --git a/src/app/tests/suites/certification/PICS.yaml b/src/app/tests/suites/certification/PICS.yaml
@@ -757,6 +757,12 @@ PICS:
           "Does the device implement an Application Device Type on any endpoint"
       id: APPDEVICE.S
 
+    # Content App Observer Cluster
+    - label:
+          "Does the device implement the Content App Observer cluster as a
+          server?"
+      id: APPOBSERVER.S
+
     # Actions Cluster Test Plan
     - label: "Does the device implement the Actions cluster as a server?"
       id: ACT.S

diff --git a/src/app/tests/suites/certification/Test_TC_CADMIN_1_3.yaml b/src/app/tests/suites/certification/Test_TC_CADMIN_1_3.yaml
@@ -391,7 +391,7 @@ tests:
       verification: |
           On TH_CR2 send the below command
 
-          ./chip-tool pairing open-commissioning-window 2 1 PIXIT.CADMIN.CwDuration 1000 3840 --commissioner-name beta
+          ./chip-tool pairing open-commissioning-window nodeId2 endpoint PIXIT.CADMIN.CwDuration 1000 3840 --commissioner-name beta
 
           Verify the Open commisioning window on the DUT_CE(all-cluster-app) Log:
 

diff --git a/src/app/tests/suites/certification/Test_TC_DISHM_1_1.yaml b/src/app/tests/suites/certification/Test_TC_DISHM_1_1.yaml
@@ -35,10 +35,11 @@ tests:
       verification: |
           ./chip-tool dishwashermode read cluster-revision 1 1
 
-          Verify the "ClusterRevision" value is of unit16 and reflects the highest revision number (2) on the TH(Chip-tool) and below is the sample log provided for the raspi platform:
+          Verify the "ClusterRevision" value is of unit16 and reflects the highest revision number 2 on the TH(Chip-tool) and below is the sample log provided for the raspi platform:
 
-          [1690365584.246794][27436:27438] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0059 Attribute 0x0000_FFFD DataVersion: 1130015440
-          [1690365584.246860][27436:27438] CHIP:TOO:   ClusterRevision: 2
+          CHIP:DMG : }
+          CHIP:TOO : Endpoint: 1 Cluster: 0x0000_0059 Attribute 0x0000_FFFD DataVersion: 2488070594
+          CHIP:TOO :   ClusterRevision: 2
       disabled: true
 
     - label: "Step 3: TH reads from the DUT the FeatureMap attribute."
@@ -56,32 +57,31 @@ tests:
           ./chip-tool dishwashermode read attribute-list 1 1
 
           Verify the "AttributeList " should include the mandatory attributes (values 0, 1),
-          - Global attributes  (value 65533, 65532, 65531, 65530, 65529 and 65528) and
+          - Global attributes  (value 65533, 65532, 65531, 65529 and 65528) and
           - List may include optional attribute(value 0x0002), if DISHM.S.A0002(StartUpMode) supports,
           - List contains feature dependent attribute (values 0x0003), if DISHM.S.F00(DEPONOFF) is true  on the TH(Chip-tool) Log and below is the sample log provided for the raspi platform:
 
-          [1689930814.439457][300741:300743] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0059 Attribute 0x0000_FFFB DataVersion: 2031856391
-          [1689930814.439500][300741:300743] CHIP:TOO:   AttributeList: 10 entries
-          [1689930814.439520][300741:300743] CHIP:TOO:     [1]: 0
-          [1689930814.439538][300741:300743] CHIP:TOO:     [2]: 1
-          [1689930814.439565][300741:300743] CHIP:TOO:     [3]: 2
-          [1689930814.439584][300741:300743] CHIP:TOO:     [4]: 3
-          [1689930814.439599][300741:300743] CHIP:TOO:     [5]: 65528
-          [1689930814.439602][300741:300743] CHIP:TOO:     [6]: 65529
-          [1689930814.439604][300741:300743] CHIP:TOO:     [7]: 65530
-          [1689930814.439616][300741:300743] CHIP:TOO:     [8]: 65531
-          [1689930814.439619][300741:300743] CHIP:TOO:     [9]: 65532
-          [1689930814.439621][300741:300743] CHIP:TOO:     [10]: 65533
+          [1696402605.599359][7921:7923] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0059 Attribute 0x0000_FFFB DataVersion: 712950283
+          [1696402605.599377][7921:7923] CHIP:TOO:   AttributeList: 9 entries
+          [1696402605.599382][7921:7923] CHIP:TOO:     [1]: 0
+          [1696402605.599385][7921:7923] CHIP:TOO:     [2]: 1
+          [1696402605.599388][7921:7923] CHIP:TOO:     [3]: 2
+          [1696402605.599391][7921:7923] CHIP:TOO:     [4]: 3
+          [1696402605.599393][7921:7923] CHIP:TOO:     [5]: 65528
+          [1696402605.599396][7921:7923] CHIP:TOO:     [6]: 65529
+          [1696402605.599399][7921:7923] CHIP:TOO:     [7]: 65531
+          [1696402605.599402][7921:7923] CHIP:TOO:     [8]: 65532
+          [1696402605.599404][7921:7923] CHIP:TOO:     [9]: 65533
       disabled: true
 
     - label: "Step 5: TH reads from the DUT the EventList attribute."
       verification: |
           ./chip-tool dishwashermode read event-list 1 1
 
-          Verify "EventList" contains a list of supported events, for this cluster the list is emty(0 entries) on the TH(Chip-tool) Log and below is the sample log provided for the raspi platform:
+          * Step 5 is currently not supported and SHALL be skipped.
 
-          [1689996691.141081][359868:359870] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0059 Attribute 0x0000_FFFA DataVersion: 1427220838
-          [1689996691.141341][359868:359870] CHIP:TOO:   EventList: 0 entries
+          [1696402636.316151][7926:7928] CHIP:DMG: }
+          [1696402636.316183][7926:7928] CHIP:TOO: Response Failure: IM Error 0x00000586: General error: 0x86 (UNSUPPORTED_ATTRIBUTE)
       disabled: true
 
     - label: "Step 6: TH reads from the DUT the AcceptedCommandList attribute."

diff --git a/src/app/tests/suites/certification/Test_TC_DISHM_2_1.yaml b/src/app/tests/suites/certification/Test_TC_DISHM_2_1.yaml
@@ -13,7 +13,7 @@
 # limitations under the License.
 # Auto-generated scripts for harness use only, please review before automation. The endpoints and cluster names are currently set to default
 
-name: 263.3.1. [TC-DISHM-2.1] ChangeToModeWithStatus Verification DUT as Server
+name: 263.3.1. [TC-DISHM-2.1]  Change to Mode functionality with DUT as Server
 
 PICS:
     - DISHM.S
@@ -38,6 +38,7 @@ tests:
 
           Verify that the DUT response contains list of ModeOptionsStruct entries
           - Verify that the list has two or more entries
+          - Verify that PIXIT.DISHM.MODE_CHANGE_FAIL is one of supported_modes_dut
           - Save the Mode field values as supported_modes_dut on the TH (Chip-tool) and below is the sample log provided for the raspi platform:
 
           [1689998005.121163][360287:360289] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0059 Attribute 0x0000_0000 DataVersion: 1994417976
@@ -108,13 +109,13 @@ tests:
     - label:
           "Step 5: Manually put the device in a state from which it will FAIL to
           transition to PIXIT.DISHM.MODE_CHANGE_FAIL"
-      PICS: DISHM.S.M.CAN_TEST_MODE_FAILURE
+      PICS: DISHM.S.M.CAN_TEST_MODE_FAILURE && DISHM.S.M.CAN_MANUALLY_CONTROLLED
       verification: |
           Manual operation required
       disabled: true
 
     - label: "Step 6: TH reads from the DUT the CurrentMode attribute."
-      PICS: DISHM.S.A0001
+      PICS: DISHM.S.A0001 && DISHM.S.M.CAN_MANUALLY_CONTROLLED
       verification: |
           ./chip-tool dishwashermode read current-mode 1 1
 
@@ -157,12 +158,13 @@ tests:
     - label:
           "Step 9: Manually put the device in a state from which it will
           SUCCESSFULLY transition to PIXIT.DISHM.MODE_CHANGE_OK"
+      PICS: DISHM.S.M.CAN_MANUALLY_CONTROLLED
       verification: |
           Manual operation required
       disabled: true
 
     - label: "Step 10: TH reads from the DUT the CurrentMode attribute."
-      PICS: DISHM.S.A0001
+      PICS: DISHM.S.A0001 && DISHM.S.M.CAN_MANUALLY_CONTROLLED
       verification: |
           ./chip-tool dishwashermode read current-mode 1 1
 

diff --git a/src/app/tests/suites/certification/Test_TC_DRLK_2_5.yaml b/src/app/tests/suites/certification/Test_TC_DRLK_2_5.yaml
@@ -19,6 +19,7 @@ name:
 
 PICS:
     - DRLK.S
+    - DRLK.S.F08
 
 config:
     nodeId: 0x12344321
@@ -84,7 +85,8 @@ tests:
                 value: null
 
     - label:
-          "Step 1: TH reads NumberOfWeekDay SchedulesSupportedPerUser attribute"
+          "Step 1: TH reads NumberOfWeekDay SchedulesSupportedPerUser attribute
+          and saves for future use"
       PICS: DRLK.S.F04 && DRLK.S.A0014
       command: "readAttribute"
       attribute: "NumberOfWeekDaySchedulesSupportedPerUser"
@@ -94,7 +96,9 @@ tests:
               minValue: 0
               maxValue: 255
 
-    - label: "Step 2: TH reads NumberOfTotalUsers Supported attribute"
+    - label:
+          "Step 2: TH reads NumberOfTotalUsers Supported attribute and saves for
+          future use"
       PICS: DRLK.S.F08 && DRLK.S.A0011
       command: "readAttribute"
       attribute: "NumberOfTotalUsersSupported"
@@ -104,7 +108,11 @@ tests:
               minValue: 0
               maxValue: 65534
 
-    - label: "Step 3: TH send Set Week Day Schedule Command"
+    - label:
+          "Step 3: TH send Set Week Day Schedule Command to DUT with the
+          following values : a)WeekDayIndex as 1 b)UserIndex as 1 c)DaysMaskMap
+          as 2 d)StartHour as 15 e)StartMinute as 45 f)EndHour as 16 g)EndMinute
+          as 55 "
       PICS: DRLK.S.F04 && DRLK.S.C0b.Rsp
       command: "SetWeekDaySchedule"
       arguments:
@@ -125,7 +133,9 @@ tests:
                 value: 55
 
     #issue #18591
-    - label: "Step 4: TH send Get Week Day Schedule Command to DUT"
+    - label:
+          "Step 4:  TH send Get Week Day Schedule Command to DUT with
+          a)WeekDayIndex as 1 b)UserIndex as 1 "
       PICS: DRLK.S.F04 && DRLK.S.C0c.Rsp && DRLK.S.C0c.Tx
       command: "GetWeekDaySchedule"
       arguments:
@@ -157,7 +167,11 @@ tests:
                     hasValue: true
                     minValue: 55
 
-    - label: "Step 5: TH send Set Week Day Schedule Command"
+    - label:
+          "Step 5: TH send Set Week Day Schedule Command to DUT with the
+          following values : a)WeekDayIndex as 0 (invalid value) b)UserIndex as
+          1 c)DaysMaskMap as 7 (invalid value) d)StartHour as 15 e)StartMinute
+          as 45 f)EndHour as 16 g)EndMinute as 55"
       PICS: DRLK.S.F04 && DRLK.S.C0b.Rsp
       command: "SetWeekDaySchedule"
       arguments:
@@ -179,7 +193,9 @@ tests:
       response:
           error: INVALID_COMMAND
 
-    - label: "Step 6: TH send Get Week Day Schedule Command to DUT"
+    - label:
+          "Step 6: TH send Get Week Day Schedule Command to DUT : a)WeekDayIndex
+          as 0 b)UserIndex as 1 "
       PICS: DRLK.S.F04 && DRLK.S.C0c.Rsp && DRLK.S.C0c.Tx
       command: "GetWeekDaySchedule"
       arguments:
@@ -213,8 +229,9 @@ tests:
                     hasValue: false
 
     - label:
-          "Step 7: TH sends Get Week Day Schedule Command to DUT for
-          non-existent User"
+          "Step 7: TH sends Get Week Day Schedule Command to DUT with following
+          values: a)WeekDayIndex as 1 (index of existing Schedule entry)
+          b)UserIndex as 2 (index on non-existent User)"
       PICS: DRLK.S.F04 && DRLK.S.C0c.Rsp && DRLK.S.C0c.Tx
       command: "GetWeekDaySchedule"
       arguments:
@@ -247,7 +264,9 @@ tests:
                 constraints:
                     hasValue: false
 
-    - label: "Step 8: TH sends Clear Week Day Schedule Command to DUT"
+    - label:
+          "Step 8: TH sends Clear Week Day Schedule Command to DUT with :
+          a)WeekDayIndex as 1 b)UserIndex as 1"
       PICS: DRLK.S.F04 && DRLK.S.C0d.Rsp
       command: "ClearWeekDaySchedule"
       arguments:
@@ -257,7 +276,9 @@ tests:
               - name: "UserIndex"
                 value: 1
 
-    - label: "Step 9: TH sends Get Week Day Schedule Command to DUT"
+    - label:
+          "Step 9: TH sends Get Week Day Schedule Command to DUT with following
+          values: a)WeekDayIndex as 1 b)UserIndex as 1"
       PICS: DRLK.S.F04 && DRLK.S.C0c.Rsp && DRLK.S.C0c.Tx
       command: "GetWeekDaySchedule"
       arguments: