[ReadHandler] Handler Reportable if timer fired #28949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #28949: Size comparison from 5e09d74 to 650aa4c Increases (53 builds for bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (13 builds for bl602, bl702, bl702l, cc32xx, esp32, psoc6)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
LuDuda
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
bzbarsky-apple
approved these changes
Aug 29, 2023
jmartinez-silabs
approved these changes
Aug 29, 2023
|
PR #28949: Size comparison from 5e09d74 to 351e803 Increases (53 builds for bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (16 builds for bl602, bl702, bl702l, cc32xx, esp32, linux, psoc6)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
@jmartinez-silabs In cases like this: #28434 (comment), basically can happen on OS that are not real time (or at least with non real time timers), or on systems where the clock can get adjusted, could probably happen with timers that do not have precise ms resolution as well. |
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Now using the EngineRunScheduled to assess reportability in the scheduler * Added note to IsReportableNow to explain the use of IsEngineRunScheduled flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses: #28929
We are now using the EngineRunScheduled flag to assess if a ReadHandler is reportable. This means if a timer has fired for a read handler, it will be considered as reportable regardless of the min and max interval as the timer should have fired for the min interval only if the handler is dirty or have fired on the max interval.