-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifying ReplacementProductListManager to be generic #28185
Merged
cliffamzn
merged 36 commits into
project-chip:master
from
cliffamzn:replacement-product-fix
Jul 27, 2023
Merged
Modifying ReplacementProductListManager to be generic #28185
cliffamzn
merged 36 commits into
project-chip:master
from
cliffamzn:replacement-product-fix
Jul 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing feedback from PR project-chip#28095 and also addressing project-chip#28148 Tested to ensure functionality still works as expected using the all-clusters-app as well as the resource-monitoring-app
cliffamzn
force-pushed
the
replacement-product-fix
branch
from
July 21, 2023 22:25
948e7fa
to
f9ed8b9
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
July 21, 2023 22:25
PR #28185: Size comparison from 88f9a44 to a20f485 Increases (4 builds for bl602, bl702, cc32xx)
Decreases (2 builds for bl702, qpg)
Full report (9 builds for bl602, bl702, bl702l, cc32xx, mbed, qpg)
|
cliffamzn
force-pushed
the
replacement-product-fix
branch
from
July 26, 2023 00:18
c626d5b
to
f6d1305
Compare
PR #28185: Size comparison from 88f9a44 to f6d1305 Increases (17 builds for bl602, bl702, bl702l, esp32, linux, nrfconnect, psoc6, telink)
Decreases (9 builds for cc32xx, cyw30739, esp32, psoc6, qpg, telink)
Full report (56 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/clusters/resource-monitoring-server/replacement-product-list-manager.h
Show resolved
Hide resolved
src/app/clusters/resource-monitoring-server/replacement-product-list-manager.h
Outdated
Show resolved
Hide resolved
src/app/clusters/resource-monitoring-server/replacement-product-list-manager.h
Outdated
Show resolved
Hide resolved
src/app/clusters/resource-monitoring-server/replacement-product-list-manager.h
Outdated
Show resolved
Hide resolved
src/app/clusters/resource-monitoring-server/resource-monitoring-cluster-objects.h
Outdated
Show resolved
Hide resolved
src/app/clusters/resource-monitoring-server/resource-monitoring-cluster-objects.h
Outdated
Show resolved
Hide resolved
src/app/clusters/resource-monitoring-server/resource-monitoring-cluster-objects.h
Outdated
Show resolved
Hide resolved
...es/resource-monitoring-app/resource-monitoring-common/src/instances/HepafilterMonitoring.cpp
Outdated
Show resolved
Hide resolved
...les/resource-monitoring-app/resource-monitoring-common/src/ReplacementProductListManager.cpp
Show resolved
Hide resolved
...rce-monitoring-app/resource-monitoring-common/include/DynamicReplacementProductListManager.h
Outdated
Show resolved
Hide resolved
namespace (rather than Attributes) Also removed the ReplacementProductList namespace and changed the implementation of the DynamicReplacementProductListManager
PR #28185: Size comparison from 88f9a44 to 84ccb8e Increases (56 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for cc32xx, psoc6)
Full report (56 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
ImmutableReplacementProductListManager This better represents devices that might read each replacement product from flash
PR #28185: Size comparison from 88f9a44 to 4c34b66 Increases above 0.2%:
Increases (56 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc32xx, linux, nrfconnect, psoc6, telink)
Full report (56 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jul 27, 2023
src/app/clusters/resource-monitoring-server/resource-monitoring-server.cpp
Outdated
Show resolved
Hide resolved
used in the Read function
PR #28185: Size comparison from 88f9a44 to 26ef1aa Increases (56 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (26 builds for cc32xx, linux, nrfconnect, psoc6, telink)
Full report (56 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing feedback from PR #28095 and also addressing #28148
Tested to ensure functionality still works as expected using the all-clusters-app as well as the resource-monitoring-app