Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying ReplacementProductListManager to be generic #28185

Merged
merged 36 commits into from
Jul 27, 2023
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
58f7a50
Modifying ReplacementProductListManager to be generic
cliffamzn Jul 21, 2023
53c50eb
Restyled by whitespace
restyled-commits Jul 21, 2023
f9ed8b9
Restyled by clang-format
restyled-commits Jul 21, 2023
3bbb797
Passing error back up
cliffamzn Jul 22, 2023
138de15
Merge branch 'master' into replacement-product-fix
cliffamzn Jul 22, 2023
3e0a655
Apply @bzbarsky-apple's suggestions from code review
cliffamzn Jul 25, 2023
f131838
Merge branch 'project-chip:master' into replacement-product-fix
cliffamzn Jul 25, 2023
60586e3
Integrating Borris' comments into ReplacementProductStruct
cliffamzn Jul 25, 2023
debbe5e
Restyled by whitespace
restyled-commits Jul 25, 2023
42d0d18
Restyled by clang-format
restyled-commits Jul 25, 2023
72a588a
Restyled by prettier-yaml
restyled-commits Jul 25, 2023
9de8518
Adding Tests for ResourceMonitor to ci tests list
cliffamzn Jul 25, 2023
623b42c
Restyled by prettier-yaml
restyled-commits Jul 25, 2023
399ff30
Adding newly generated zap files
cliffamzn Jul 25, 2023
73e8a95
Replaced the use of std::set with IntrusiveList in ModeBase. (#28163)
hicklin Jul 25, 2023
1c2f26d
Remove unwanted "\" at line 156 from DA-1.4 test (#28252)
manjunath-grl Jul 25, 2023
baa4eb0
Remove zap development install. (#28223)
mikaelhm Jul 25, 2023
b598ad6
[feature]Add dishwasher-app example for ASR platform (#28207)
mideayanghui Jul 25, 2023
0c25d18
[ Java] Decouple generated API in build option (#27624)
joonhaengHeo Jul 25, 2023
37f7188
Revert "[ Java] Decouple generated API in build option (#27624)" (#28…
andy31415 Jul 25, 2023
9a6feb4
[ASR] update device manager (#28251)
tx2rx Jul 25, 2023
aef213a
Add RVC device type to XML + fix RVC Clean/Run XML issue (#28239)
plauric Jul 25, 2023
a55fbb4
Make C++17 the default everywhere (#28269)
andy31415 Jul 25, 2023
4963c26
Add ipv6only build for rpc target, to not run out of ram when linking…
andy31415 Jul 25, 2023
ae10124
Attempting to fix error ` error: 'ReplacementProductStruct' was not
cliffamzn Jul 25, 2023
a20f485
Merge branch 'project-chip:master' into replacement-product-fix
cliffamzn Jul 25, 2023
f6d1305
Modifying the placeholder app to have example output
cliffamzn Jul 26, 2023
11802f7
Moved around the ReplacementProductStruct to the ResourceMonitoring
cliffamzn Jul 26, 2023
aa6e303
Restyled by whitespace
restyled-commits Jul 26, 2023
8e91c35
Restyled by clang-format
restyled-commits Jul 26, 2023
84ccb8e
Removing commented out code
cliffamzn Jul 26, 2023
64b5316
Changing DynamicReplacementProductListManager to an
cliffamzn Jul 26, 2023
cc9622a
Overriding the = operation to always do a copy
cliffamzn Jul 26, 2023
021040a
Restyled by whitespace
restyled-commits Jul 26, 2023
4c34b66
Restyled by clang-format
restyled-commits Jul 26, 2023
26ef1aa
Adding back the instance of the ReplacementProductList so that it can be
cliffamzn Jul 27, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Restyled by whitespace
restyled-commits authored and cliffamzn committed Jul 26, 2023
commit aa6e303d8f28ef7f9aad74c9ea26b64ef06b91e9
Original file line number Diff line number Diff line change
@@ -39,7 +39,7 @@ class DynamicReplacementProductListManager : public ReplacementProductListManage
/**
* Creates a ReplacementProductStruct and adds it to the list. Can only add up to kReplacementProductListMaxSize
* entries to a list (as defined by the spec).
*
*
* @param aProductIdentifierType The identifier type of the product.
* @param aProductIdentifierValue The value of the product.
* @return CHIP_ERROR_NO_MEMORY if the list is full, a CHIP_ERROR if there was a problem creating the
Original file line number Diff line number Diff line change
@@ -61,4 +61,4 @@ CHIP_ERROR DynamicReplacementProductListManager::Next(ReplacementProductStruct &
}

return CHIP_ERROR_PROVIDER_LIST_EXHAUSTED;
}
}
Original file line number Diff line number Diff line change
@@ -43,7 +43,7 @@ class ReplacementProductListManager
void Reset() { mIndex = 0; }

/**
* Iterates through the entries in the ReplacementProductListManager. Each call to this function copies the next item into
* Iterates through the entries in the ReplacementProductListManager. Each call to this function copies the next item into
* the out param. Calls to this function will return CHIP_NO_ERROR if there are still valid elements in the list. The function
* will return CHIP_ERROR_PROVIDER_LIST_EXHAUSTED if the end of the list has been reached.
*
Original file line number Diff line number Diff line change
@@ -29,7 +29,7 @@ namespace app {
namespace Clusters {
namespace ResourceMonitoring {

// max of 20 characters as defined by the constraint on the ProductIdentifierValue in the specification
// max of 20 characters as defined by the constraint on the ProductIdentifierValue in the specification
static constexpr size_t kProductIdentifierValueMaxNameLength = 20u;
static constexpr std::array<ClusterId, 2> AliasedClusters = { HepaFilterMonitoring::Id, ActivatedCarbonFilterMonitoring::Id };