-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ReadHandler] Rename and comment #27269
[ReadHandler] Rename and comment #27269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with a few nits
PR #27269: Size comparison from 5efdd31 to 27758a2 Increases (31 builds for bl602, bl702, cc32xx, efr32, k32w, nrfconnect, psoc6, qpg, telink)
Decreases (13 builds for bl602, bl702, cc32xx, cyw30739, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27269: Size comparison from 5efdd31 to 1546b1d Increases above 0.2%:
Increases (26 builds for bl602, bl702, cc32xx, k32w, linux, nrfconnect, psoc6, qpg)
Decreases (3 builds for bl602, bl702)
Full report (35 builds for bl602, bl702, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #27269: Size comparison from 5efdd31 to 06ff866 Increases (9 builds for bl602, bl702, cc32xx, linux, qpg)
Decreases (1 build for bl702)
Full report (13 builds for bl602, bl702, cc32xx, linux, mbed, nrfconnect, qpg)
|
06ff866
to
2076746
Compare
PR #27269: Size comparison from 8fbcc1b to 2076746 Increases (30 builds for bl602, bl702, cc32xx, cyw30739, efr32, k32w, psoc6, qpg, telink)
Decreases (7 builds for bl602, cyw30739, nrfconnect, psoc6, telink)
Full report (55 builds for bl602, bl702, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…ubcription reports in the ReadHandler to explicit its functionnality
Co-authored-by: mkardous-silabs <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
a01b6f4
to
e963a90
Compare
PR #27269: Size comparison from 5ed31da to e963a90 Increases (30 builds for bl602, bl702, cc32xx, efr32, esp32, k32w, nrfconnect, psoc6, qpg, telink)
Decreases (15 builds for bl702, cc32xx, cyw30739, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
// mHoldSync is used to prevent subscription empty report delivery while we | ||
// are waiting for the max reporting interval to elaps. When mHoldSync | ||
// WaitingUntilMaxInterval is used to prevent subscription empty report delivery while we | ||
// are waiting for the max reporting interval to elaps. When WaitingUntilMaxInterval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"to elapse"
This PR renames and comments various methods and members of the ReadHandler to make its report scheduling mechanism more explicit.