Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: mkardous-silabs <[email protected]>
  • Loading branch information
lpbeliveau-silabs and mkardous-silabs authored Jun 15, 2023
1 parent 27758a2 commit 1546b1d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/app/ReadHandler.h
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ class ReadHandler : public Messaging::ExchangeDelegate
auto GetTransactionStartGeneration() const { return mTransactionStartGeneration; }

/// @brief This allows the read handler to schedule a run as soon as the min interval has elapsed by setting the read handler to
/// a dirty state regardless of the attributes change, thus being reportable as soon as the min interval callback happends.
/// a dirty state regardless of the attributes change, thus being reportable as soon as the min interval callback happens.
void ForceDirtyState();

const AttributeValueEncoder::AttributeEncodeState & GetAttributeEncodeState() const { return mAttributeEncoderState; }
Expand Down Expand Up @@ -404,7 +404,7 @@ class ReadHandler : public Messaging::ExchangeDelegate
*/
void Close(CloseOptions options = CloseOptions::kDropPersistedSubscription);

/// @brief This function is called when the min interval timer has expired, it restarts the timer on a timeout equalt to the
/// @brief This function is called when the min interval timer has expired, it restarts the timer on a timeout equal to the
/// difference between the max interval and the min interval.
static void MinIntervalExpiredCallback(System::Layer * apSystemLayer, void * apAppState);
static void MaxIntervalExpiredCallback(System::Layer * apSystemLayer, void * apAppState);
Expand All @@ -427,7 +427,7 @@ class ReadHandler : public Messaging::ExchangeDelegate

void PersistSubscription();

/// @brief This function modifies at state Flag in the read handler and schedules an engine run if the read handler want from a
/// @brief This function modifies a state Flag in the read handler and schedules an engine run if the read handler want from a
/// non reportable state to a reportable state, resulting in the emission of a report.
/// @param aFlag Flag to set
/// @param aValue Flag new value
Expand Down

0 comments on commit 1546b1d

Please sign in to comment.