-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scenes] Scene Handler Encode and Decode attribute value list #27089
Merged
andy31415
merged 5 commits into
project-chip:master
from
lpbeliveau-silabs:feature/SceneHandlers-helper
Jun 15, 2023
Merged
[Scenes] Scene Handler Encode and Decode attribute value list #27089
andy31415
merged 5 commits into
project-chip:master
from
lpbeliveau-silabs:feature/SceneHandlers-helper
Jun 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
June 5, 2023 22:08
pullapprove
bot
requested review from
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
June 5, 2023 22:08
lpbeliveau-silabs
force-pushed
the
feature/SceneHandlers-helper
branch
from
June 5, 2023 22:16
395adb5
to
9b54e53
Compare
PR #27089: Size comparison from f701c45 to 9b54e53 Increases (8 builds for bl602, bl702, cyw30739, nrfconnect, psoc6)
Decreases (2 builds for k32w, psoc6)
Full report (39 builds for bl602, bl702, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
lpbeliveau-silabs
force-pushed
the
feature/SceneHandlers-helper
branch
from
June 5, 2023 23:39
9b54e53
to
ed6eb71
Compare
PR #27089: Size comparison from 4f6923f to ed6eb71 Increases (9 builds for bl602, esp32, k32w, psoc6, telink)
Decreases (9 builds for bl702, nrfconnect, psoc6, qpg, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lpbeliveau-silabs
changed the title
Scene Handler Encode and Decode attribute value list
[Scenes] Scene Handler Encode and Decode attribute value list
Jun 6, 2023
lpbeliveau-silabs
force-pushed
the
feature/SceneHandlers-helper
branch
from
June 9, 2023 20:43
9fe0acd
to
307bccf
Compare
PR #27089: Size comparison from 40fb7c2 to 307bccf Increases (17 builds for bl602, cyw30739, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (9 builds for bl702, cc32xx, esp32, k32w, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 13, 2023
Co-authored-by: Boris Zbarsky <[email protected]>
jmartinez-silabs
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helper functions for SceneHandlers to avoid code duplication went implementing cluster specific handlers.