-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scenes] Added the on-off cluster handler for scene EFS #27041
Merged
lpbeliveau-silabs
merged 9 commits into
project-chip:master
from
lpbeliveau-silabs:feature/scenes-onoff-handler
Jun 19, 2023
Merged
[Scenes] Added the on-off cluster handler for scene EFS #27041
lpbeliveau-silabs
merged 9 commits into
project-chip:master
from
lpbeliveau-silabs:feature/scenes-onoff-handler
Jun 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
ksperling-apple
June 2, 2023 15:02
lpbeliveau-silabs
changed the title
Added the on-off cluster handler for scene EFS
[Scenes] Added the on-off cluster handler for scene EFS
Jun 6, 2023
lpbeliveau-silabs
force-pushed
the
feature/scenes-onoff-handler
branch
from
June 6, 2023 18:43
c2a0664
to
93d83f7
Compare
lpbeliveau-silabs
force-pushed
the
feature/scenes-onoff-handler
branch
from
June 6, 2023 18:45
93d83f7
to
0e06fe4
Compare
PR #27041: Size comparison from a73c8e9 to 0e06fe4 Increases above 0.2%:
Increases (27 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, psoc6, telink)
Decreases (10 builds for bl702, cc32xx, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
lpbeliveau-silabs
force-pushed
the
feature/scenes-onoff-handler
branch
2 times, most recently
from
June 15, 2023 18:45
27b8699
to
28e620f
Compare
PR #27041: Size comparison from eef9529 to 28e620f Increases above 0.2%:
Increases (44 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (11 builds for bl602, bl702, cc32xx, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 16, 2023
…th expected results from TestSceneTable
… <Endpoint, State> array, addressed comments related to code style and nits
…ensure memory is released
…led in SceneTable's destructor
Co-authored-by: Boris Zbarsky <[email protected]>
lpbeliveau-silabs
force-pushed
the
feature/scenes-onoff-handler
branch
from
June 16, 2023 21:39
9e3dbf9
to
9f2db1a
Compare
PR #27041: Size comparison from aa13fa3 to 9f2db1a Increases above 0.2%:
Increases (44 builds for bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (10 builds for bl602, bl702, cc32xx, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
PR #27041: Size comparison from aa13fa3 to 8625074 Increases above 0.2%:
Increases (43 builds for bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (11 builds for bl602, bl702, cc32xx, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a default extension field set handler for the on-off cluster, allowing scenes to interact with the on-off cluster when scenes are invoked.