Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherrypick] Added Attestation Certificate Format Validation Method #23060

Merged
merged 3 commits into from
Oct 7, 2022
Merged

[cherrypick] Added Attestation Certificate Format Validation Method #23060

merged 3 commits into from
Oct 7, 2022

Conversation

emargolis
Copy link
Contributor

Fixes #22942

* Added Attestation Certificate Format Validation Method.

  -- Added new method VarifyAttestationCertificateFormat() that verifies that
     attestation certificate format is compliant with the Spec.
  -- Updated DefaultDeviceAttestationVerifier to validate PAI and DAC certificates format.
  -- Updated FileAttestationTrustStore to validate PAA certificates format when they are
     loaded from the file storage.
  -- Added new unit test (TestCommissionerDUTVectors) that iterates through all
     negative and positive test cases to validate that PAI/DAC validation
     passes/fails as expected.

  -- Fixed minor typos and bugs in the chip-cert tool and test vector generation
     script (gen_com_dut_test_vectors.py). As a result I also regenerated all test vectors
     in credentials/development/commissioner_dut/

emargolis and others added 3 commits October 6, 2022 11:26
@emargolis
Added Attestation Certificate Format Validation Method. (project-chip…
d9374d9 
…#22943)

* Added Attestation Certificate Format Validation Method.

  -- Added new method VarifyAttestationCertificateFormat() that verifies that
     attestation certificate format is compliant with the Spec.
  -- Updated DefaultDeviceAttestationVerifier to validate PAI and DAC certificates format.
  -- Updated FileAttestationTrustStore to validate PAA certificates format when they are
     loaded from the file storage.
  -- Added new unit test (TestCommissionerDUTVectors) that iterates through all
     negative and positive test cases to validate that PAI/DAC validation
     passes/fails as expected.

  -- Fixed minor typos and bugs in the chip-cert tool and test vector generation
     script (gen_com_dut_test_vectors.py). As a result I also regenerated all test vectors
     in credentials/development/commissioner_dut/

* updates and fixes mostly for EFR32 implementation if the crypto library
@rcasallas-silabs @emargolis
EFR32: Crypto PSA bugfix: Missing return on success. (project-chip#23033
86b59ce 
)
@emargolis
[tinycrypt] bugfix: Missing return on success (project-chip#23039)
91105be
@andy31415 andy31415 merged commit c50094a into project-chip:v1.0-branch Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

Assignees
No one assigned
Labels
app crypto efr32 platform tests tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emargolis @andy31415 @rcasallas-silabs