Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tinycrypt] bugfix: Missing return on success #23039

Merged
merged 1 commit into from
Oct 6, 2022
Merged

[tinycrypt] bugfix: Missing return on success #23039

merged 1 commit into from
Oct 6, 2022

Conversation

emargolis
Copy link
Contributor

fixes typo in the #22943

similar to #23033 fix

@github-actions github-actions bot added the crypto label Oct 5, 2022
@github-actions
Copy link

github-actions bot commented Oct 5, 2022

PR #23039: Size comparison from f1bbff3 to 99c920c

Decreases (2 builds for bl702, nrfconnect)
platform target config section f1bbff3 99c920c change % change
bl702 lighting-app bl702+rpc (read/write) 1284147 1284131 -16 -0.0
.debug_info 41811331 41811330 -1 -0.0
.text 1030482 1030480 -2 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 803384 803380 -4 -0.0
Full report (9 builds for bl702, linux, mbed, nrfconnect, qpg)
platform target config section f1bbff3 99c920c change % change
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1188211 1188211 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67102 67102 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1506913 1506913 0 0.0
.debug_aranges 133120 133120 0 0.0
.debug_frame 486540 486540 0 0.0
.debug_info 37904719 37904719 0 0.0
.debug_line 5256212 5256212 0 0.0
.debug_loc 3366560 3366560 0 0.0
.debug_ranges 359264 359264 0 0.0
.debug_str 3457718 3457718 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116552 116552 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565037 565037 0 0.0
.symtab 171648 171648 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 956778 956778 0 0.0
bl702+rpc 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1284147 1284131 -16 -0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75150 75150 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644458 1644458 0 0.0
.debug_aranges 140624 140624 0 0.0
.debug_frame 511916 511916 0 0.0
.debug_info 41811331 41811330 -1 -0.0
.debug_line 5630747 5630747 0 0.0
.debug_loc 3559220 3559220 0 0.0
.debug_ranges 381720 381720 0 0.0
.debug_str 3853618 3853618 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129944 129944 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624210 624210 0 0.0
.symtab 189456 189456 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 1030482 1030480 -2 -0.0
linux chip-tool-ipv6only arm64 (read only) 10428900 10428900 0 0.0
(read/write) 706321 706321 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650608 650608 0 0.0
.dynamic 560 560 0 0.0
.got 13896 13896 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518004 518004 0 0.0
.text 8255348 8255348 0 0.0
thermostat-no-ble arm64 (read only) 2389420 2389420 0 0.0
(read/write) 143617 143617 0 0.0
.bss 55377 55377 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77232 77232 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144244 144244 0 0.0
.text 2002288 2002288 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2451792 2451792 0 0.0
.bss 215028 215028 0 0.0
.data 5872 5872 0 0.0
.text 1414436 1414436 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183051 1183051 0 0.0
bss 144441 144441 0 0.0
rodata 144220 144220 0 0.0
text 815488 815488 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161735 1161735 0 0.0
bss 143668 143668 0 0.0
rodata 135792 135792 0 0.0
text 803384 803380 -4 -0.0
qpg lighting-app qpg6105+debug (read/write) 1148256 1148256 0 0.0
.bss 110556 110556 0 0.0
.data 832 832 0 0.0
.text 595356 595356 0 0.0
lock-app qpg6105+debug (read/write) 1113320 1113320 0 0.0
.bss 106372 106372 0 0.0
.data 836 836 0 0.0
.text 560416 560416 0 0.0

@emargolis
Copy link
Contributor Author

@jmartinez-silabs PTAL - fix similar to #23033

@jmartinez-silabs jmartinez-silabs enabled auto-merge (squash) October 6, 2022 18:53
@jmartinez-silabs jmartinez-silabs merged commit 2784c8c into project-chip:master Oct 6, 2022
emargolis added a commit to emargolis/connectedhomeip-1 that referenced this pull request Oct 6, 2022
@emargolis
[tinycrypt] bugfix: Missing return on success (project-chip#23039)
91105be
andy31415 pushed a commit that referenced this pull request Oct 7, 2022
@emargolis @rcasallas-silabs
[cherrypick] Added Attestation Certificate Format Validation Method (#…
c50094a 
…23060)

* Added Attestation Certificate Format Validation Method. (#22943)

* Added Attestation Certificate Format Validation Method.

  -- Added new method VarifyAttestationCertificateFormat() that verifies that
     attestation certificate format is compliant with the Spec.
  -- Updated DefaultDeviceAttestationVerifier to validate PAI and DAC certificates format.
  -- Updated FileAttestationTrustStore to validate PAA certificates format when they are
     loaded from the file storage.
  -- Added new unit test (TestCommissionerDUTVectors) that iterates through all
     negative and positive test cases to validate that PAI/DAC validation
     passes/fails as expected.

  -- Fixed minor typos and bugs in the chip-cert tool and test vector generation
     script (gen_com_dut_test_vectors.py). As a result I also regenerated all test vectors
     in credentials/development/commissioner_dut/

* updates and fixes mostly for EFR32 implementation if the crypto library

* EFR32: Crypto PSA bugfix: Missing return on success. (#23033)

* [tinycrypt] bugfix: Missing return on success (#23039)

Co-authored-by: Ricardo Casallas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
crypto review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emargolis @yufengwangca @jmartinez-silabs