Added Attestation Certificate Format Validation Method. #22943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple and
chrisdecenzo
pullapprove
bot
requested review from
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda and
mlepage-google
|
PR #22943: Size comparison from 3bd7c37 to 42ec84a Increases (14 builds for bl602, bl702, cc13x2_26x2, esp32, linux, psoc6)
Decreases (8 builds for bl702, cc13x2_26x2, esp32)
Full report (32 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg)
|
|
PR #22943: Size comparison from 3bd7c37 to 7c41450 Increases (12 builds for bl602, bl702, cc13x2_26x2, linux, psoc6)
Decreases (4 builds for cc13x2_26x2)
Full report (25 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, psoc6, qpg)
|
|
PR #22943: Size comparison from 3bd7c37 to 75ba9ef Increases (6 builds for bl602, bl702, linux)
Full report (11 builds for bl602, bl702, k32w, linux, mbed, qpg)
|
|
PR #22943: Size comparison from 3bd7c37 to c9fd793 Increases (18 builds for bl602, bl702, cc13x2_26x2, esp32, linux, psoc6, telink)
Decreases (6 builds for cc13x2_26x2, esp32)
Full report (30 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
andy31415
approved these changes
Sep 29, 2022
|
PR #22943: Size comparison from 8e58621 to 98756f3 Increases (10 builds for bl702, cc13x2_26x2, linux, psoc6)
Decreases (4 builds for cc13x2_26x2, telink)
Full report (28 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, psoc6, qpg, telink)
|
emargolis
force-pushed
the
emargolis/feature/add-attestation-certs-format-verifier
branch
from
98756f3 to
6c6ba29
Compare
|
PR #22943: Size comparison from a6ecd62 to 6c6ba29 Increases (4 builds for bl702, linux)
Full report (7 builds for bl702, linux, mbed, qpg)
|
|
PR #22943: Size comparison from a6ecd62 to 784c425 Increases (8 builds for bl602, bl702, linux, telink)
Full report (14 builds for bl602, bl702, k32w, linux, mbed, qpg, telink)
|
|
PR #22943: Size comparison from a6ecd62 to af56216 Increases (17 builds for bl602, bl702, cc13x2_26x2, esp32, linux, psoc6, telink)
Decreases (6 builds for cc13x2_26x2, esp32)
Full report (30 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
emargolis
force-pushed
the
emargolis/feature/add-attestation-certs-format-verifier
branch
from
af56216 to
48c5755
Compare
|
PR #22943: Size comparison from a334714 to 48c5755 Increases (11 builds for bl602, bl702, cc13x2_26x2, linux, psoc6)
Decreases (6 builds for bl602, cc13x2_26x2, esp32, telink)
Full report (32 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
-- Added new method VarifyAttestationCertificateFormat() that verifies that
attestation certificate format is compliant with the Spec.
-- Updated DefaultDeviceAttestationVerifier to validate PAI and DAC certificates format.
-- Updated FileAttestationTrustStore to validate PAA certificates format when they are
loaded from the file storage.
-- Added new unit test (TestCommissionerDUTVectors) that iterates through all
negative and positive test cases to validate that PAI/DAC validation
passes/fails as expected.
-- Fixed minor typos and bugs in the chip-cert tool and test vector generation
script (gen_com_dut_test_vectors.py). As a result I also regenerated all test vectors
in credentials/development/commissioner_dut/
emargolis
force-pushed
the
emargolis/feature/add-attestation-certs-format-verifier
branch
from
d9d831f to
3819099
Compare
|
PR #22943: Size comparison from b6c9191 to 3819099 Increases (10 builds for bl702, linux, nrfconnect, psoc6, telink)
Decreases (8 builds for bl702, esp32, psoc6, qpg)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This was referenced Oct 4, 2022
emargolis
added a commit
to emargolis/connectedhomeip-1
that referenced
this pull request
Oct 6, 2022
…#22943) * Added Attestation Certificate Format Validation Method. -- Added new method VarifyAttestationCertificateFormat() that verifies that attestation certificate format is compliant with the Spec. -- Updated DefaultDeviceAttestationVerifier to validate PAI and DAC certificates format. -- Updated FileAttestationTrustStore to validate PAA certificates format when they are loaded from the file storage. -- Added new unit test (TestCommissionerDUTVectors) that iterates through all negative and positive test cases to validate that PAI/DAC validation passes/fails as expected. -- Fixed minor typos and bugs in the chip-cert tool and test vector generation script (gen_com_dut_test_vectors.py). As a result I also regenerated all test vectors in credentials/development/commissioner_dut/ * updates and fixes mostly for EFR32 implementation if the crypto library
andy31415
pushed a commit
that referenced
this pull request
Oct 7, 2022
…23060) * Added Attestation Certificate Format Validation Method. (#22943) * Added Attestation Certificate Format Validation Method. -- Added new method VarifyAttestationCertificateFormat() that verifies that attestation certificate format is compliant with the Spec. -- Updated DefaultDeviceAttestationVerifier to validate PAI and DAC certificates format. -- Updated FileAttestationTrustStore to validate PAA certificates format when they are loaded from the file storage. -- Added new unit test (TestCommissionerDUTVectors) that iterates through all negative and positive test cases to validate that PAI/DAC validation passes/fails as expected. -- Fixed minor typos and bugs in the chip-cert tool and test vector generation script (gen_com_dut_test_vectors.py). As a result I also regenerated all test vectors in credentials/development/commissioner_dut/ * updates and fixes mostly for EFR32 implementation if the crypto library * EFR32: Crypto PSA bugfix: Missing return on success. (#23033) * [tinycrypt] bugfix: Missing return on success (#23039) Co-authored-by: Ricardo Casallas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22942
-- Added new method VarifyAttestationCertificateFormat() that verifies that
attestation certificate format is compliant with the Spec.
-- Updated DefaultDeviceAttestationVerifier to validate PAI and DAC certificates format.
-- Updated FileAttestationTrustStore to validate PAA certificates format when they are
loaded from the file storage.
-- Added new unit test (TestCommissionerDUTVectors) that iterates through all
negative and positive test cases to validate that PAI/DAC validation
passes/fails as expected.
-- Fixed minor typos and bugs in the chip-cert tool and test vector generation
script (gen_com_dut_test_vectors.py). As a result I also regenerated all test vectors
in credentials/development/commissioner_dut/