Switch from readline to editline #20330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woody-apple
approved these changes
Jul 5, 2022
|
PR #20330: Size comparison from 777ee25 to e073703 Increases above 0.2%:
Increases (3 builds for linux, telink)
Decreases (1 build for linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Jul 5, 2022
|
PR #20330: Size comparison from 1f62fa2 to e80e873 Increases (2 builds for cc13x2_26x2, cyw30739)
Decreases (1 build for cc13x2_26x2)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Readline is GPL'd software and may not be available in the build environment. Vendor editline which is permissively licensed and drop it in as a replacement for readline.
|
PR #20330: Size comparison from 64b179a to b099b47 Increases above 0.2%:
Increases (2 builds for esp32, linux)
Decreases (3 builds for linux, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
pullapprove
bot
requested review from
arkq,
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
msandstedt and
saurabhst
pullapprove
bot
requested review from
selissia,
tecimovic,
vijs,
wbschiller and
xylophone21
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Jul 6, 2022
As of 3340fc2 ("Switch from readline to editline (project-chip#20330)") there is no longer an issue with respect to the availability of libreadline.
andy31415
pushed a commit
to andy31415/connectedhomeip
that referenced
this pull request
Jul 6, 2022
Readline is GPL'd software and may not be available in the build environment. Vendor editline which is permissively licensed and drop it in as a replacement for readline.
andy31415
added a commit
that referenced
this pull request
Jul 6, 2022
Readline is GPL'd software and may not be available in the build environment. Vendor editline which is permissively licensed and drop it in as a replacement for readline. Co-authored-by: Michael Spang <[email protected]>
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Jul 6, 2022
As of 3340fc2 ("Switch from readline to editline (project-chip#20330)") there is no longer an issue with respect to the availability of libreadline.
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Jul 6, 2022
As of 3340fc2 ("Switch from readline to editline (project-chip#20330)") there is no longer an issue with respect to the availability of libreadline.
mspang
added a commit
that referenced
this pull request
Jul 7, 2022
woody-apple
added a commit
that referenced
this pull request
Jul 7, 2022
As of 3340fc2 ("Switch from readline to editline (#20330)") there is no longer an issue with respect to the availability of libreadline. Co-authored-by: Michael Spang <[email protected]>
cpagravel
pushed a commit
to cpagravel/connectedhomeip
that referenced
this pull request
Jul 12, 2022
Readline is GPL'd software and may not be available in the build environment. Vendor editline which is permissively licensed and drop it in as a replacement for readline.
cpagravel
pushed a commit
to cpagravel/connectedhomeip
that referenced
this pull request
Jul 12, 2022
As of 3340fc2 ("Switch from readline to editline (project-chip#20330)") there is no longer an issue with respect to the availability of libreadline.
cpagravel
pushed a commit
to cpagravel/connectedhomeip
that referenced
this pull request
Jul 12, 2022
As of 3340fc2 ("Switch from readline to editline (project-chip#20330)") there is no longer an issue with respect to the availability of libreadline.
cpagravel
pushed a commit
to cpagravel/connectedhomeip
that referenced
this pull request
Jul 13, 2022
Readline is GPL'd software and may not be available in the build environment. Vendor editline which is permissively licensed and drop it in as a replacement for readline.
cpagravel
pushed a commit
to cpagravel/connectedhomeip
that referenced
this pull request
Jul 13, 2022
As of 3340fc2 ("Switch from readline to editline (project-chip#20330)") there is no longer an issue with respect to the availability of libreadline.
cpagravel
pushed a commit
to cpagravel/connectedhomeip
that referenced
this pull request
Jul 13, 2022
Readline is GPL'd software and may not be available in the build environment. Vendor editline which is permissively licensed and drop it in as a replacement for readline.
cpagravel
pushed a commit
to cpagravel/connectedhomeip
that referenced
this pull request
Jul 13, 2022
As of 3340fc2 ("Switch from readline to editline (project-chip#20330)") there is no longer an issue with respect to the availability of libreadline.
andy31415
pushed a commit
that referenced
this pull request
Jul 14, 2022
…20600) * Switch from readline to editline (#20330) Readline is GPL'd software and may not be available in the build environment. Vendor editline which is permissively licensed and drop it in as a replacement for readline. * Don't sweat interactive mode in build_examples.py (#20389) As of 3340fc2 ("Switch from readline to editline (#20330)") there is no longer an issue with respect to the availability of libreadline. * Target non-interactive Linux example build in CI (#20635) Co-authored-by: Michael Spang <[email protected]>
rerasool
pushed a commit
to SiliconLabs/matter
that referenced
this pull request
Sep 9, 2022
…roject-chip#20600) * Switch from readline to editline (project-chip#20330) Readline is GPL'd software and may not be available in the build environment. Vendor editline which is permissively licensed and drop it in as a replacement for readline. * Don't sweat interactive mode in build_examples.py (project-chip#20389) As of 3340fc2 ("Switch from readline to editline (project-chip#20330)") there is no longer an issue with respect to the availability of libreadline. * Target non-interactive Linux example build in CI (project-chip#20635) Co-authored-by: Michael Spang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Readline is GPL'd software and may not be available in the build
environment.
Change overview
Vendor editline which is permissively licensed and drop it in as a
replacement for readline.
Testing
chip-tool interactive