Skip to content

Commit

Permalink
Remove UnauthenticatedSession::mLocalMessageCounter (#11375)
Browse files Browse the repository at this point in the history
  • Loading branch information
kghost authored and pull[bot] committed Jun 15, 2022
1 parent 1e5a325 commit 2508872
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/transport/SessionManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ CHIP_ERROR SessionManager::PrepareMessage(SessionHandle sessionHandle, PayloadHe
{
ReturnErrorOnFailure(payloadHeader.EncodeBeforeData(message));

MessageCounter & counter = sessionHandle.GetUnauthenticatedSession()->GetLocalMessageCounter();
MessageCounter & counter = mGlobalUnencryptedMessageCounter;
uint32_t messageCounter = counter.Value();
ReturnErrorOnFailure(counter.Advance());

Expand Down
4 changes: 1 addition & 3 deletions src/transport/UnauthenticatedSessionTable.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class UnauthenticatedSessionDeleter
class UnauthenticatedSession : public ReferenceCounted<UnauthenticatedSession, UnauthenticatedSessionDeleter, 0>
{
public:
UnauthenticatedSession(const PeerAddress & address) : mPeerAddress(address) { mLocalMessageCounter.Init(); }
UnauthenticatedSession(const PeerAddress & address) : mPeerAddress(address) {}

UnauthenticatedSession(const UnauthenticatedSession &) = delete;
UnauthenticatedSession & operator=(const UnauthenticatedSession &) = delete;
Expand All @@ -59,14 +59,12 @@ class UnauthenticatedSession : public ReferenceCounted<UnauthenticatedSession, U

const PeerAddress & GetPeerAddress() const { return mPeerAddress; }

MessageCounter & GetLocalMessageCounter() { return mLocalMessageCounter; }
PeerMessageCounter & GetPeerMessageCounter() { return mPeerMessageCounter; }

private:
uint64_t mLastActivityTimeMs = 0;

const PeerAddress mPeerAddress;
GlobalUnencryptedMessageCounter mLocalMessageCounter;
PeerMessageCounter mPeerMessageCounter;
};

Expand Down

0 comments on commit 2508872

Please sign in to comment.