Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry Pick - RPi builds no longer need no-interactive workaround #20600

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Cherry Pick - RPi builds no longer need no-interactive workaround #20600

merged 3 commits into from
Jul 14, 2022

Conversation

cpagravel
Copy link
Contributor

@cpagravel cpagravel commented Jul 12, 2022 •
edited
Loading

Problem

  • Master branch no longer produces the no-interactive builds for linux on arm64. This makes things inconsistent. For test purposes, we'd like to use the same build.

Change overview

Testing

  • Tested in CI

@restyled-io restyled-io bot mentioned this pull request Jul 12, 2022
Closed
@andy31415
Copy link
Contributor

@cpagravel is this really a cherrypick? The title seems to indicate so, however list of changes seems to be a longer list and PR is still in draft (assumuming code changes are required)

@cpagravel
Copy link
Contributor Author

@andy31415 this is created using git cherry-pick. I need to redo the merge here which is why I left this as a draft.

@cpagravel cpagravel force-pushed the interop_cherry_pick branch from baa3f28 to b7e02b1 Compare July 12, 2022 18:38
@github-actions
Copy link

github-actions bot commented Jul 12, 2022 •
edited
Loading

PR #20600: Size comparison from afb0d91 to b7e02b1

Full report (20 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section afb0d91 b7e02b1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 626646 626646 0 0.0
.app_xip_area 529220 529220 0 0.0
.bss 80116 80116 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 621494 621494 0 0.0
.app_xip_area 525508 525508 0 0.0
.bss 78676 78676 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574626 574626 0 0.0
.app_xip_area 468996 468996 0 0.0
.bss 88024 88024 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907456 907456 0 0.0
(read/write) 135072 135072 0 0.0
.bss 133064 133064 0 0.0
.data 2008 2008 0 0.0
.text 907448 907448 0 0.0
BRD4161A+rpc (read only) 943324 943324 0 0.0
(read/write) 151940 151940 0 0.0
.bss 149728 149728 0 0.0
.data 2212 2212 0 0.0
.text 943316 943316 0 0.0
BRD4161A+rs911x (read only) 745804 745804 0 0.0
(read/write) 129308 129308 0 0.0
.bss 127372 127372 0 0.0
.data 1936 1936 0 0.0
.text 745796 745796 0 0.0
lock-app BRD4161A+wf200 (read only) 908748 908748 0 0.0
(read/write) 126300 126300 0 0.0
.bss 124380 124380 0 0.0
.data 1920 1920 0 0.0
.text 908740 908740 0 0.0
window-app BRD4161A (read only) 844888 844888 0 0.0
(read/write) 133200 133200 0 0.0
.bss 131240 131240 0 0.0
.data 1956 1956 0 0.0
.text 844880 844880 0 0.0
esp32 all-clusters-app c3devkit (read only) 999142 999142 0 0.0
(read/write) 1474442 1474442 0 0.0
.dram0.bss 69128 69128 0 0.0
.dram0.data 14356 14356 0 0.0
.flash.rodata 206496 206496 0 0.0
.flash.text 999142 999142 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1054531 1054531 0 0.0
(read/write) 476856 476856 0 0.0
.dram0.bss 74648 74648 0 0.0
.dram0.data 34096 34096 0 0.0
.flash.rodata 236276 236276 0 0.0
.flash.text 1049147 1049147 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 656064 656064 0 0.0
.bss 71076 71076 0 0.0
.data 1964 1964 0 0.0
.text 577224 577224 0 0.0
lock k32w061+release (read/write) 702916 702916 0 0.0
.bss 71500 71500 0 0.0
.data 1960 1960 0 0.0
.text 623656 623656 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8276308 8276308 0 0.0
(read/write) 539601 539601 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 479608 479608 0 0.0
.dynamic 560 560 0 0.0
.got 14088 14088 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 423604 423604 0 0.0
.text 6634356 6634356 0 0.0
thermostat-no-ble arm64 (read only) 2366700 2366700 0 0.0
(read/write) 174753 174753 0 0.0
.bss 86497 86497 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 79000 79000 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145980 145980 0 0.0
.text 1991664 1991664 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2412212 2412212 0 0.0
.bss 206068 206068 0 0.0
.data 5832 5832 0 0.0
.text 1374812 1374812 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179959 1179959 0 0.0
bss 142760 142760 0 0.0
rodata 150064 150064 0 0.0
text 808500 808500 0 0.0
p6 all-clusters-app default (read/write) 2526600 2526600 0 0.0
.bss 140024 140024 0 0.0
.data 2728 2728 0 0.0
.text 1484864 1484864 0 0.0
light-app default (read/write) 2418496 2418496 0 0.0
.bss 132720 132720 0 0.0
.data 2552 2552 0 0.0
.text 1376760 1376760 0 0.0
lock-app default (read/write) 2422816 2422816 0 0.0
.bss 132520 132520 0 0.0
.data 2544 2544 0 0.0
.text 1381080 1381080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807320 807320 0 0.0
bss 75420 75420 0 0.0
noinit 40416 40416 0 0.0
text 571094 571094 0 0.0

@cpagravel cpagravel force-pushed the interop_cherry_pick branch from b7e02b1 to 593c9a1 Compare July 13, 2022 21:22
mspang added 2 commits July 13, 2022 14:23
@mspang @cpagravel
Switch from readline to editline (project-chip#20330)
76ee4e7 
Readline is GPL'd software and may not be available in the build
environment.

Vendor editline which is permissively licensed and drop it in as a
replacement for readline.
@mspang @cpagravel
Don't sweat interactive mode in build_examples.py (project-chip#20389)
6bf45cf 
As of 3340fc2 ("Switch from readline to editline (project-chip#20330)") there is
no longer an issue with respect to the availability of libreadline.
@cpagravel cpagravel force-pushed the interop_cherry_pick branch from 593c9a1 to 6bf45cf Compare July 13, 2022 21:23
@cpagravel cpagravel marked this pull request as ready for review July 13, 2022 22:36
@andy31415 andy31415 merged commit 31909fb into project-chip:interop_testing_te9 Jul 14, 2022
rerasool pushed a commit to SiliconLabs/matter that referenced this pull request Sep 9, 2022
@cpagravel @mspang @danielsilabs
Cherry Pick - RPi builds no longer need no-interactive workaround (p…
03639a3 
…roject-chip#20600)

* Switch from readline to editline (project-chip#20330)

Readline is GPL'd software and may not be available in the build
environment.

Vendor editline which is permissively licensed and drop it in as a
replacement for readline.

* Don't sweat interactive mode in build_examples.py (project-chip#20389)

As of 3340fc2 ("Switch from readline to editline (project-chip#20330)") there is
no longer an issue with respect to the availability of libreadline.

* Target non-interactive Linux example build in CI (project-chip#20635)

Co-authored-by: Michael Spang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
examples github scripts workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpagravel @andy31415 @mspang