Move NewPairing from SessionEstablishDelegate to CASE/PASE session #17422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #17422: Size comparison from 737b702 to 988c822 Increases above 0.2%:
Increases (2 builds for cc13x2_26x2)
Decreases (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
kghost
changed the title
|
PR #17422: Size comparison from c503a97 to ddeb49c Increases above 0.2%:
Increases (4 builds for cc13x2_26x2, linux)
Decreases (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #17422: Size comparison from c503a97 to 486d6f7 Increases above 0.2%:
Increases (4 builds for cc13x2_26x2, linux)
Decreases (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis and
erjiaqing
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #17422: Size comparison from a3f636d to 8607fa5 Increases above 0.2%:
Increases (13 builds for cc13x2_26x2, linux)
Decreases (30 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #17422: Size comparison from a3f636d to ae26e05 Increases above 0.2%:
Increases (13 builds for cc13x2_26x2, linux)
Decreases (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
Apr 19, 2022
|
PR #17422: Size comparison from 03ea72d to 3834aa9 Increases above 0.2%:
Increases (13 builds for cc13x2_26x2, linux)
Decreases (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Apr 19, 2022
tcarmelveilleux
added a commit
to tcarmelveilleux/connectedhomeip
that referenced
this pull request
Apr 26, 2022
- From project-chip#17422 onwards, "previous" CASE sessions were not expired in terms of the session cache if sessions were constantly re-established. - A root cause solution will be to solve project-chip#17568, but in the meantime, cert testing started failing after N (where N is session manager pool size) runs. This PR cleans-up the previous sessions from same node (duplicate sessions that should not happen). This is a bit unclean but will do to unblock testing since it was good enough before, and the better method is not yet implemented. This PR also adds logging when this happens. Fixes project-chip#17698 Testing done: - Unit tests pass - Cert tests pass - Manual run of N > 16 `for i in {1..18}; do ./out/debug/standalone/chip-tool basic read vendor-name 115566 0 ; done` does not fail as before.
kghost
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Quick-fix running out of CASE sessions - From #17422 onwards, "previous" CASE sessions were not expired in terms of the session cache if sessions were constantly re-established. - A root cause solution will be to solve #17568, but in the meantime, cert testing started failing after N (where N is session manager pool size) runs. This PR cleans-up the previous sessions from same node (duplicate sessions that should not happen). This is a bit unclean but will do to unblock testing since it was good enough before, and the better method is not yet implemented. This PR also adds logging when this happens. Fixes #17698 Testing done: - Unit tests pass - Cert tests pass - Manual run of N > 16 `for i in {1..18}; do ./out/debug/standalone/chip-tool basic read vendor-name 115566 0 ; done` does not fail as before. * Restyled by clang-format * Fix CI Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SessionManager::NewPairingshould not be a public API.Change overview
OnSessionEstablishedwill receive anSessionHandleargument pointing to the newly created sessionSessionManager::AllocateSession(uint16_t)because it is only used by test-cases.CASEClient::EstablishSessionnow takes a delegate instead of function pointersPairingSessiona bitmRole: CryptoContext::SessionRolemLocalMRPConfigmMRPConfig=>mRemoteMRPConfigmSecureSessionTypewith a virtual function.mPeerNodeId,mPeerCATsbecause PASE session do not need themmPeerAddress, address is handled by the unsecure sessionNOTE: this PR includes PR #17411Testing
Passed unit-tests