Quick-fix running out of CASE sessions #17779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- From project-chip#17422 onwards, "previous" CASE sessions were not expired in terms of the session cache if sessions were constantly re-established. - A root cause solution will be to solve project-chip#17568, but in the meantime, cert testing started failing after N (where N is session manager pool size) runs. This PR cleans-up the previous sessions from same node (duplicate sessions that should not happen). This is a bit unclean but will do to unblock testing since it was good enough before, and the better method is not yet implemented. This PR also adds logging when this happens. Fixes project-chip#17698 Testing done: - Unit tests pass - Cert tests pass - Manual run of N > 16 `for i in {1..18}; do ./out/debug/standalone/chip-tool basic read vendor-name 115566 0 ; done` does not fail as before.
bzbarsky-apple
approved these changes
Apr 26, 2022
tcarmelveilleux
force-pushed
the
quick-fix-17698
branch
from
8ec66ad to
fa7dfe2
Compare
andy31415
approved these changes
Apr 26, 2022
pullapprove
bot
requested review from
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
hawk248,
harsha-rajendran,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
msandstedt,
saurabhst,
selissia,
tecimovic,
vijs,
wbschiller and
xylophone21
|
PR #17779: Size comparison from 6c54ab8 to fa7dfe2 Increases (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (4 builds for cc13x2_26x2)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmartinez-silabs
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
in terms of the session cache if sessions were constantly
re-established.
cert testing started failing after N (where N is session manager
pool size) runs.
Fixes #17698
Change overview
This PR cleans-up the previous sessions from same node (duplicate sessions
that should not happen). This is a bit unclean but will do to unblock
testing since it was good enough before, and the better method is not
yet implemented.
This PR also adds logging when this happens.
Testing
for i in {1..18}; do ./out/debug/standalone/chip-tool basic read vendor-name 115566 0 ; donedoes not fail as before.