-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IM] Implement supported CommandList #14299
[IM] Implement supported CommandList #14299
Conversation
/rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this! This is looking quite good. In addition to the nits, one other thing (followup probably ok): we should have YAML tests for this.
4f1b313
to
7c44f40
Compare
PR #14299: Size comparison from 92f8343 to cd4c07d Increases above 0.2%:
Increases (11 builds for cyw30739, efr32, esp32, k32w, linux, p6, qpg)
Decreases (6 builds for cyw30739, efr32, p6, qpg, telink)
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, p6, qpg, telink)
|
c5cdea4
to
3c14f41
Compare
PR #14299: Size comparison from 207453c to 3c14f41 Increases above 0.2%:
Increases (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg)
Decreases (11 builds for cyw30739, efr32, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #14299: Size comparison from 8b503ad to 47e5677 Increases (4 builds for cyw30739, k32w, qpg)
Decreases (3 builds for cyw30739, qpg, telink)
Full report (8 builds for cyw30739, k32w, qpg, telink)
|
47e5677
to
bbc2246
Compare
PR #14299: Size comparison from 8b503ad to bbc2246 Increases above 0.2%:
Increases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #14299: Size comparison from 39115b9 to 97a8bb2 Increases above 0.2%:
Increases (38 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (42 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #14299: Size comparison from 8bb93af to f03d9f4 Increases above 0.2%:
Increases (39 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Problem
Fixes #10780
CommandList is not implemented.
Each instance of a cluster shall support this attribute.
This attribute shall be a list of the command IDs for:
commands from the client that are received, supported and processed by the server
commands generated from the server that are in response to a processed client command
Change overview
Testing
TBD