Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit client side cluster related code #14508

Closed
erjiaqing opened this issue Jan 28, 2022 · 2 comments
Closed

Revisit client side cluster related code #14508

erjiaqing opened this issue Jan 28, 2022 · 2 comments

Comments

@erjiaqing
Copy link
Contributor

One more thing: this part does not look right to me.... Why are we generating things for client sides of clusters here?

Let's leave this as-is for now, but do a followup to not generate this... and probably not generate ClusterRevision for client clusters either, since it's not observable...

Originally posted by @bzbarsky-apple in #14299 (comment)

ZAP will generate meta for client cluster, but the client should not have cluster data per spec, should revisit related code in code base.

@bzbarsky-apple
Copy link
Contributor

We need some metadata for client clusters, because Descriptor Cluster needs to be able to show info about them existing, right?

What we should not be generating are:

  1. ClusterRevision attributes for client clusters, with space in the attr store and all that.
  2. CommandList metadata bits for client clusters.

And I guess we could try to handle the Descriptor bits via some mechanism other than EmberAfCluster entries, but that will take a bit more surgery, whereas not generating the above two is an easy space win.

@bzbarsky-apple
Copy link
Contributor

Fixed in #14677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants