Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace implementation of ServerClusterCommandExists() in ember-compatibility-functions.cpp by IM command catalog look-up #14022

Closed
woody-apple opened this issue Jan 25, 2022 · 1 comment · Fixed by #14806
Closed

Replace implementation of ServerClusterCommandExists() in ember-compatibility-functions.cpp by IM command catalog look-up #14022

woody-apple opened this issue Jan 25, 2022 · 1 comment · Fixed by #14806
Labels
Interaction Model Work todo 🗒️ V1.0

Comments

@woody-apple
Copy link
Contributor

false

connectedhomeip/src/app/InteractionModelEngine.h

Lines 264 to 269 in f0f5de0

* TODO: The implementation lives in ember-compatibility-functions.cpp, this should be replaced by IM command catalog look up
* function after we have a cluster catalog in interaction model engine.
* TODO: The endpoint id on response command (client side command) is unclear, so we don't have a ClientClusterCommandExists
* function. (Spec#3258)
*
* @retval True if the endpoint contains the server side of the given cluster and that cluster implements the given command, false

This issue was generated by todo-issue based on a TODO comment in f0f5de0.
@tcarmelveilleux
Copy link
Contributor

This is dependant on #14299

@tcarmelveilleux tcarmelveilleux changed the title The implementation lives in ember-compatibility-functions.cpp, this should be replaced by IM command catalog look up Replace implementation of ServerClusterCommandExists() in ember-compatibility-functions.cpp by IM command catalog look-up Jan 31, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 4, 2022
@bzbarsky-apple
Add correct checking for whether a command is supported.
6a0b9a5 
This also fixes the status reporting for unsupported endpoints and clusters.

Fixes project-chip#7612
Fixes project-chip#13920
Fixes project-chip#14022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 4, 2022
@bzbarsky-apple
Add correct checking for whether a command is supported.
aa17eb1 
This also fixes the status reporting for unsupported endpoints and clusters.

Fixes project-chip#7612
Fixes project-chip#13920
Fixes project-chip#14022
@bzbarsky-apple bzbarsky-apple mentioned this issue Feb 4, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 4, 2022
@bzbarsky-apple
Add correct checking for whether a command is supported.
e594aeb 
This also fixes the status reporting for unsupported endpoints and clusters.

Fixes project-chip#7612
Fixes project-chip#13920
Fixes project-chip#14022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 5, 2022
@bzbarsky-apple
Add correct checking for whether a command is supported.
d7717cc 
This also fixes the status reporting for unsupported endpoints and
clusters.  And fixes some tests to use the right endpoint, now that we
are checking that sort of thing.

Fixes project-chip#7612
Fixes project-chip#13920
Fixes project-chip#14022
Fixes project-chip#11578
Fixes project-chip#11185
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 5, 2022
@bzbarsky-apple
Add correct checking for whether a command is supported.
df971f0 
This also fixes the status reporting for unsupported endpoints and
clusters.  And fixes some tests to use the right endpoint, now that we
are checking that sort of thing.

Fixes project-chip#7612
Fixes project-chip#13920
Fixes project-chip#14022
Fixes project-chip#11578
Fixes project-chip#11185
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 5, 2022
@bzbarsky-apple
Add correct checking for whether a command is supported.
6eaf69a 
This also fixes the status reporting for unsupported endpoints and
clusters.  And fixes some tests to use the right endpoint, now that we
are checking that sort of thing.

Fixes project-chip#7612
Fixes project-chip#13920
Fixes project-chip#14022
Fixes project-chip#11578
Fixes project-chip#11185
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 5, 2022
@bzbarsky-apple
Add correct checking for whether a command is supported.
606d9d2 
This also fixes the status reporting for unsupported endpoints and
clusters.  And fixes some tests to use the right endpoint, now that we
are checking that sort of thing.

Fixes project-chip#7612
Fixes project-chip#13920
Fixes project-chip#14022
Fixes project-chip#11578
Fixes project-chip#11185
bzbarsky-apple added a commit that referenced this issue Feb 7, 2022
@bzbarsky-apple
Add correct checking for whether a command is supported. (#14806)
26fa3fa 
This also fixes the status reporting for unsupported endpoints and
clusters.  And fixes some tests to use the right endpoint, now that we
are checking that sort of thing.

Fixes #7612
Fixes #13920
Fixes #14022
Fixes #11578
Fixes #11185
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this issue Feb 7, 2022
@bzbarsky-apple @mkardous-silabs
Add correct checking for whether a command is supported. (project-chi…
9684468 
…p#14806)

This also fixes the status reporting for unsupported endpoints and
clusters.  And fixes some tests to use the right endpoint, now that we
are checking that sort of thing.

Fixes project-chip#7612
Fixes project-chip#13920
Fixes project-chip#14022
Fixes project-chip#11578
Fixes project-chip#11185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Interaction Model Work todo 🗒️ V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add correct checking for whether a command is supported. bzbarsky-apple/connectedhomeip
3 participants
@tcarmelveilleux @andy31415 @woody-apple