Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add correct checking for whether a command is supported. #14806

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Add correct checking for whether a command is supported. #14806

merged 1 commit into from
Feb 7, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Feb 4, 2022 •
edited
Loading

This also fixes the status reporting for unsupported endpoints and clusters.

Fixes #7612
Fixes #13920
Fixes #14022
Fixes #11578
Fixes #11185

Problem

  1. We are not correctly rejecting commands that are supported on the given cluster on some other endpoint but not on the targeted one.
  2. We are not reporting the right status for unsupported commands.

Change overview

Fix those issues by using the ClientGeneratedCommandList metadata we have.

Also fix the status bits for attributes.

Testing

Modified existing yaml tests to test the new status.

Modified existing yaml tests that were failing now due to trying to talk to the wrong endpoint.

@github-actions
Copy link

github-actions bot commented Feb 4, 2022 •
edited
Loading

PR #14806: Size comparison from 9423bb4 to aa17eb1

Increases (8 builds for cyw30739, k32w, qpg, telink)
platform target config section 9423bb4 aa17eb1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587614 587794 180 0.0
.app_xip_area 494212 494392 180 0.0
lock cyw930739m2evb_01 (read/write) 545538 545694 156 0.0
.app_xip_area 453688 453844 156 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569934 570086 152 0.0
.app_xip_area 468772 468924 152 0.0
k32w light k32w061+release (read/write) 672140 672292 152 0.0
.text 588624 588776 152 0.0
lock k32w061+release (read/write) 673704 673856 152 0.0
.text 589820 589972 152 0.0
qpg lighting-app qpg6105+debug (read only) 580288 580332 44 0.0
.text 574968 575012 44 0.0
lock-app qpg6105+debug (read only) 526368 526396 28 0.0
.text 521048 521076 28 0.0
telink lighting-app tlsr9518adk80d (read/write) 859086 859286 200 0.0
text 602070 602242 172 0.0
Full report (9 builds for cyw30739, k32w, qpg, telink)
platform target config section 9423bb4 aa17eb1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587614 587794 180 0.0
.app_xip_area 494212 494392 180 0.0
.bss 76124 76124 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545538 545694 156 0.0
.app_xip_area 453688 453844 156 0.0
.bss 74604 74604 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569934 570086 152 0.0
.app_xip_area 468772 468924 152 0.0
.bss 83588 83588 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 672140 672292 152 0.0
.bss 75832 75832 0 0.0
.data 1884 1884 0 0.0
.text 588624 588776 152 0.0
lock k32w061+release (read/write) 673704 673856 152 0.0
.bss 76160 76160 0 0.0
.data 1924 1924 0 0.0
.text 589820 589972 152 0.0
qpg lighting-app qpg6105+debug (read only) 580288 580332 44 0.0
(read/write) 146940 146940 0 0.0
.bss 88112 88112 0 0.0
.data 1088 1088 0 0.0
.text 574968 575012 44 0.0
lock-app qpg6105+debug (read only) 526368 526396 28 0.0
(read/write) 146940 146940 0 0.0
.bss 87560 87560 0 0.0
.data 1024 1024 0 0.0
.text 521048 521076 28 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 859086 859286 200 0.0
bss 88476 88476 0 0.0
noinit 37160 37160 0 0.0
text 602070 602242 172 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the fix-unknown-command-errors branch from aa17eb1 to e594aeb Compare February 4, 2022 21:34
@boring-cyborg boring-cyborg bot added the github label Feb 4, 2022
@github-actions
Copy link

github-actions bot commented Feb 4, 2022 •
edited
Loading

PR #14806: Size comparison from 9423bb4 to e594aeb

Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 9423bb4 e594aeb change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587614 587794 180 0.0
.app_xip_area 494212 494392 180 0.0
lock cyw930739m2evb_01 (read/write) 545538 545694 156 0.0
.app_xip_area 453688 453844 156 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569934 570086 152 0.0
.app_xip_area 468772 468924 152 0.0
efr32 lighting-app BRD4161A (read only) 857248 857432 184 0.0
.text 857240 857424 184 0.0
BRD4161A+rpc (read only) 844616 844784 168 0.0
.text 844608 844776 168 0.0
window-app BRD4161A (read only) 829484 829652 168 0.0
.text 829476 829644 168 0.0
esp32 all-clusters-app c3devkit (read only) 936818 936994 176 0.0
(read/write) 1401186 1401210 24 0.0
.flash.rodata 197944 197968 24 0.0
.flash.text 936818 936994 176 0.0
m5stack (read only) 984795 984955 160 0.0
(read/write) 465536 465560 24 0.0
.flash.rodata 224552 224576 24 0.0
.flash.text 979411 979571 160 0.0
k32w light k32w061+release (read/write) 672140 672292 152 0.0
.text 588624 588776 152 0.0
lock k32w061+release (read/write) 673704 673856 152 0.0
.text 589820 589972 152 0.0
linux chip-tool-ipv6only arm64 (read only) 7237668 7238020 352 0.0
.rodata 392684 392700 16 0.0
.text 6240244 6240580 336 0.0
thermostat-no-ble arm64 (read only) 2126276 2126708 432 0.0
.rodata 131220 131252 32 0.0
.text 1777104 1777504 400 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2388824 2388872 48 0.0
.text 1351424 1351472 48 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2348016 2348128 112 0.0
.text 1310616 1310728 112 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2312000 2312048 48 0.0
.text 1274600 1274648 48 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2302340 2302388 48 0.0
.text 1264912 1264960 48 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 998055 998243 188 0.0
rodata 117252 117280 28 0.0
text 681356 681504 148 0.0
nrf52840dk_nrf52840+rpc (read/write) 969411 969579 168 0.0
rodata 108640 108664 24 0.0
text 665916 666056 140 0.0
nrf52840dongle_nrf52840 (read/write) 1014747 1014915 168 0.0
rodata 116092 116116 24 0.0
text 686852 686996 144 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904750 904934 184 0.0
rodata 110512 110536 24 0.0
text 596372 596520 148 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930199 930367 168 0.0
rodata 105604 105628 24 0.0
text 627216 627348 132 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 837722 837874 152 0.0
rodata 98772 98796 24 0.0
text 543004 543136 132 0.0
pump-app nrf52840dk_nrf52840 (read/write) 932827 932995 168 0.0
rodata 106072 106096 24 0.0
text 629556 629700 144 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 927783 927935 152 0.0
rodata 105076 105100 24 0.0
text 625496 625624 128 0.0
p6 all-clusters-app default (read/write) 2450072 2450240 168 0.0
.text 1408336 1408504 168 0.0
light-app default (read/write) 2353488 2353672 184 0.0
.text 1311752 1311936 184 0.0
lock-app default (read/write) 2318712 2318864 152 0.0
.text 1276976 1277128 152 0.0
qpg lighting-app qpg6105+debug (read only) 580288 580332 44 0.0
.text 574968 575012 44 0.0
lock-app qpg6105+debug (read only) 526368 526396 28 0.0
.text 521048 521076 28 0.0
telink lighting-app tlsr9518adk80d (read/write) 859086 859286 200 0.0
text 602070 602242 172 0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 9423bb4 e594aeb change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587614 587794 180 0.0
.app_xip_area 494212 494392 180 0.0
.bss 76124 76124 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545538 545694 156 0.0
.app_xip_area 453688 453844 156 0.0
.bss 74604 74604 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569934 570086 152 0.0
.app_xip_area 468772 468924 152 0.0
.bss 83588 83588 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 857248 857432 184 0.0
(read/write) 125888 125888 0 0.0
.bss 123960 123960 0 0.0
.data 1924 1924 0 0.0
.text 857240 857424 184 0.0
BRD4161A+rpc (read only) 844616 844784 168 0.0
(read/write) 142544 142544 0 0.0
.bss 140520 140520 0 0.0
.data 2024 2024 0 0.0
.text 844608 844776 168 0.0
window-app BRD4161A (read only) 829484 829652 168 0.0
(read/write) 124528 124528 0 0.0
.bss 122648 122648 0 0.0
.data 1880 1880 0 0.0
.text 829476 829644 168 0.0
esp32 all-clusters-app c3devkit (read only) 936818 936994 176 0.0
(read/write) 1401186 1401210 24 0.0
.dram0.bss 70064 70064 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 197944 197968 24 0.0
.flash.text 936818 936994 176 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 984795 984955 160 0.0
(read/write) 465536 465560 24 0.0
.dram0.bss 74816 74816 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 224552 224576 24 0.0
.flash.text 979411 979571 160 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 672140 672292 152 0.0
.bss 75832 75832 0 0.0
.data 1884 1884 0 0.0
.text 588624 588776 152 0.0
lock k32w061+release (read/write) 673704 673856 152 0.0
.bss 76160 76160 0 0.0
.data 1924 1924 0 0.0
.text 589820 589972 152 0.0
linux chip-tool-ipv6only arm64 (read only) 7237668 7238020 352 0.0
(read/write) 287873 287873 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 186488 186488 0 0.0
.dynamic 560 560 0 0.0
.got 45776 45776 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 392684 392700 16 0.0
.text 6240244 6240580 336 0.0
thermostat-no-ble arm64 (read only) 2126276 2126708 432 0.0
(read/write) 140705 140705 0 0.0
.bss 57745 57745 0 0.0
.data 968 968 0 0.0
.data.rel.ro 74872 74872 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131220 131252 32 0.0
.text 1777104 1777504 400 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2388824 2388872 48 0.0
.bss 188972 188972 0 0.0
.data 5296 5296 0 0.0
.text 1351424 1351472 48 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348016 2348128 112 0.0
.bss 181072 181072 0 0.0
.data 5600 5600 0 0.0
.text 1310616 1310728 112 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312000 2312048 48 0.0
.bss 180960 180960 0 0.0
.data 5584 5584 0 0.0
.text 1274600 1274648 48 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302340 2302388 48 0.0
.bss 178244 178244 0 0.0
.data 5400 5400 0 0.0
.text 1264912 1264960 48 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 998055 998243 188 0.0
bss 120544 120544 0 0.0
rodata 117252 117280 28 0.0
text 681356 681504 148 0.0
nrf52840dk_nrf52840+rpc (read/write) 969411 969579 168 0.0
bss 116400 116400 0 0.0
rodata 108640 108664 24 0.0
text 665916 666056 140 0.0
nrf52840dongle_nrf52840 (read/write) 1014747 1014915 168 0.0
bss 121908 121908 0 0.0
rodata 116092 116116 24 0.0
text 686852 686996 144 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904750 904934 184 0.0
bss 117108 117108 0 0.0
rodata 110512 110536 24 0.0
text 596372 596520 148 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930199 930367 168 0.0
bss 118884 118884 0 0.0
rodata 105604 105628 24 0.0
text 627216 627348 132 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 837722 837874 152 0.0
bss 115476 115476 0 0.0
rodata 98772 98796 24 0.0
text 543004 543136 132 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 932827 932995 168 0.0
bss 118636 118636 0 0.0
rodata 106072 106096 24 0.0
text 629556 629700 144 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 927783 927935 152 0.0
bss 118636 118636 0 0.0
rodata 105076 105100 24 0.0
text 625496 625624 128 0.0
shell nrf52840dk_nrf52840 (read/write) 802779 802779 0 0.0
bss 110968 110968 0 0.0
rodata 78480 78480 0 0.0
text 535760 535760 0 0.0
p6 all-clusters-app default (read/write) 2450072 2450240 168 0.0
.bss 117128 117128 0 0.0
.data 2584 2584 0 0.0
.text 1408336 1408504 168 0.0
light-app default (read/write) 2353488 2353672 184 0.0
.bss 106272 106272 0 0.0
.data 2432 2432 0 0.0
.text 1311752 1311936 184 0.0
lock-app default (read/write) 2318712 2318864 152 0.0
.bss 105992 105992 0 0.0
.data 2392 2392 0 0.0
.text 1276976 1277128 152 0.0
qpg lighting-app qpg6105+debug (read only) 580288 580332 44 0.0
(read/write) 146940 146940 0 0.0
.bss 88112 88112 0 0.0
.data 1088 1088 0 0.0
.text 574968 575012 44 0.0
lock-app qpg6105+debug (read only) 526368 526396 28 0.0
(read/write) 146940 146940 0 0.0
.bss 87560 87560 0 0.0
.data 1024 1024 0 0.0
.text 521048 521076 28 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 859086 859286 200 0.0
bss 88476 88476 0 0.0
noinit 37160 37160 0 0.0
text 602070 602242 172 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the fix-unknown-command-errors branch from e594aeb to d7717cc Compare February 5, 2022 00:18
@github-actions
Copy link

github-actions bot commented Feb 5, 2022 •
edited
Loading

PR #14806: Size comparison from 4549ca8 to d7717cc

Increases above 0.2%:

platform target config section 4549ca8 d7717cc change % change
linux chip-tool-ipv6only arm64 (read only) 7238084 7268164 30080 0.4
.got 45784 46048 264 0.6
.rodata 392684 393756 1072 0.3
.text 6240564 6267988 27424 0.4
Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4549ca8 d7717cc change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587614 587794 180 0.0
.app_xip_area 494212 494392 180 0.0
lock cyw930739m2evb_01 (read/write) 545538 545694 156 0.0
.app_xip_area 453688 453844 156 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569934 570086 152 0.0
.app_xip_area 468772 468924 152 0.0
efr32 lighting-app BRD4161A (read only) 857248 857432 184 0.0
.text 857240 857424 184 0.0
BRD4161A+rpc (read only) 844616 844784 168 0.0
.text 844608 844776 168 0.0
window-app BRD4161A (read only) 829484 829652 168 0.0
.text 829476 829644 168 0.0
esp32 all-clusters-app c3devkit (read only) 936818 936994 176 0.0
(read/write) 1401186 1401210 24 0.0
.flash.rodata 197944 197968 24 0.0
.flash.text 936818 936994 176 0.0
m5stack (read only) 984795 984955 160 0.0
(read/write) 465536 465560 24 0.0
.flash.rodata 224552 224576 24 0.0
.flash.text 979411 979571 160 0.0
k32w light k32w061+release (read/write) 672140 672292 152 0.0
.text 588624 588776 152 0.0
lock k32w061+release (read/write) 673704 673856 152 0.0
.text 589820 589972 152 0.0
linux chip-tool-ipv6only arm64 (read only) 7238084 7268164 30080 0.4
(read/write) 287921 288593 672 0.2
.data.rel.ro 186528 186936 408 0.2
.got 45784 46048 264 0.6
.rodata 392684 393756 1072 0.3
.text 6240564 6267988 27424 0.4
thermostat-no-ble arm64 (read only) 2126276 2126708 432 0.0
.rodata 131220 131252 32 0.0
.text 1777104 1777504 400 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2388824 2388872 48 0.0
.text 1351424 1351472 48 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2348016 2348128 112 0.0
.text 1310616 1310728 112 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2312000 2312048 48 0.0
.text 1274600 1274648 48 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2302340 2302388 48 0.0
.text 1264912 1264960 48 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 998055 998243 188 0.0
rodata 117252 117280 28 0.0
text 681356 681504 148 0.0
nrf52840dk_nrf52840+rpc (read/write) 969411 969579 168 0.0
rodata 108640 108664 24 0.0
text 665916 666056 140 0.0
nrf52840dongle_nrf52840 (read/write) 1014747 1014915 168 0.0
rodata 116092 116116 24 0.0
text 686852 686996 144 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904750 904934 184 0.0
rodata 110512 110536 24 0.0
text 596372 596520 148 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930199 930367 168 0.0
rodata 105604 105628 24 0.0
text 627216 627348 132 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 837722 837874 152 0.0
rodata 98772 98796 24 0.0
text 543004 543136 132 0.0
pump-app nrf52840dk_nrf52840 (read/write) 932827 932995 168 0.0
rodata 106072 106096 24 0.0
text 629556 629700 144 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 927783 927935 152 0.0
rodata 105076 105100 24 0.0
text 625496 625624 128 0.0
p6 all-clusters-app default (read/write) 2450072 2450240 168 0.0
.text 1408336 1408504 168 0.0
light-app default (read/write) 2353488 2353672 184 0.0
.text 1311752 1311936 184 0.0
lock-app default (read/write) 2318712 2318864 152 0.0
.text 1276976 1277128 152 0.0
qpg lighting-app qpg6105+debug (read only) 580288 580332 44 0.0
.text 574968 575012 44 0.0
lock-app qpg6105+debug (read only) 526368 526396 28 0.0
.text 521048 521076 28 0.0
telink lighting-app tlsr9518adk80d (read/write) 859086 859286 200 0.0
text 602070 602242 172 0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4549ca8 d7717cc change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587614 587794 180 0.0
.app_xip_area 494212 494392 180 0.0
.bss 76124 76124 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545538 545694 156 0.0
.app_xip_area 453688 453844 156 0.0
.bss 74604 74604 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569934 570086 152 0.0
.app_xip_area 468772 468924 152 0.0
.bss 83588 83588 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 857248 857432 184 0.0
(read/write) 125888 125888 0 0.0
.bss 123960 123960 0 0.0
.data 1924 1924 0 0.0
.text 857240 857424 184 0.0
BRD4161A+rpc (read only) 844616 844784 168 0.0
(read/write) 142544 142544 0 0.0
.bss 140520 140520 0 0.0
.data 2024 2024 0 0.0
.text 844608 844776 168 0.0
window-app BRD4161A (read only) 829484 829652 168 0.0
(read/write) 124528 124528 0 0.0
.bss 122648 122648 0 0.0
.data 1880 1880 0 0.0
.text 829476 829644 168 0.0
esp32 all-clusters-app c3devkit (read only) 936818 936994 176 0.0
(read/write) 1401186 1401210 24 0.0
.dram0.bss 70064 70064 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 197944 197968 24 0.0
.flash.text 936818 936994 176 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 984795 984955 160 0.0
(read/write) 465536 465560 24 0.0
.dram0.bss 74816 74816 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 224552 224576 24 0.0
.flash.text 979411 979571 160 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 672140 672292 152 0.0
.bss 75832 75832 0 0.0
.data 1884 1884 0 0.0
.text 588624 588776 152 0.0
lock k32w061+release (read/write) 673704 673856 152 0.0
.bss 76160 76160 0 0.0
.data 1924 1924 0 0.0
.text 589820 589972 152 0.0
linux chip-tool-ipv6only arm64 (read only) 7238084 7268164 30080 0.4
(read/write) 287921 288593 672 0.2
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 186528 186936 408 0.2
.dynamic 560 560 0 0.0
.got 45784 46048 264 0.6
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 392684 393756 1072 0.3
.text 6240564 6267988 27424 0.4
thermostat-no-ble arm64 (read only) 2126276 2126708 432 0.0
(read/write) 140705 140705 0 0.0
.bss 57745 57745 0 0.0
.data 968 968 0 0.0
.data.rel.ro 74872 74872 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131220 131252 32 0.0
.text 1777104 1777504 400 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2388824 2388872 48 0.0
.bss 188972 188972 0 0.0
.data 5296 5296 0 0.0
.text 1351424 1351472 48 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348016 2348128 112 0.0
.bss 181072 181072 0 0.0
.data 5600 5600 0 0.0
.text 1310616 1310728 112 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312000 2312048 48 0.0
.bss 180960 180960 0 0.0
.data 5584 5584 0 0.0
.text 1274600 1274648 48 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302340 2302388 48 0.0
.bss 178244 178244 0 0.0
.data 5400 5400 0 0.0
.text 1264912 1264960 48 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 998055 998243 188 0.0
bss 120544 120544 0 0.0
rodata 117252 117280 28 0.0
text 681356 681504 148 0.0
nrf52840dk_nrf52840+rpc (read/write) 969411 969579 168 0.0
bss 116400 116400 0 0.0
rodata 108640 108664 24 0.0
text 665916 666056 140 0.0
nrf52840dongle_nrf52840 (read/write) 1014747 1014915 168 0.0
bss 121908 121908 0 0.0
rodata 116092 116116 24 0.0
text 686852 686996 144 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904750 904934 184 0.0
bss 117108 117108 0 0.0
rodata 110512 110536 24 0.0
text 596372 596520 148 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930199 930367 168 0.0
bss 118884 118884 0 0.0
rodata 105604 105628 24 0.0
text 627216 627348 132 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 837722 837874 152 0.0
bss 115476 115476 0 0.0
rodata 98772 98796 24 0.0
text 543004 543136 132 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 932827 932995 168 0.0
bss 118636 118636 0 0.0
rodata 106072 106096 24 0.0
text 629556 629700 144 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 927783 927935 152 0.0
bss 118636 118636 0 0.0
rodata 105076 105100 24 0.0
text 625496 625624 128 0.0
shell nrf52840dk_nrf52840 (read/write) 802779 802779 0 0.0
bss 110968 110968 0 0.0
rodata 78480 78480 0 0.0
text 535760 535760 0 0.0
p6 all-clusters-app default (read/write) 2450072 2450240 168 0.0
.bss 117128 117128 0 0.0
.data 2584 2584 0 0.0
.text 1408336 1408504 168 0.0
light-app default (read/write) 2353488 2353672 184 0.0
.bss 106272 106272 0 0.0
.data 2432 2432 0 0.0
.text 1311752 1311936 184 0.0
lock-app default (read/write) 2318712 2318864 152 0.0
.bss 105992 105992 0 0.0
.data 2392 2392 0 0.0
.text 1276976 1277128 152 0.0
qpg lighting-app qpg6105+debug (read only) 580288 580332 44 0.0
(read/write) 146940 146940 0 0.0
.bss 88112 88112 0 0.0
.data 1088 1088 0 0.0
.text 574968 575012 44 0.0
lock-app qpg6105+debug (read only) 526368 526396 28 0.0
(read/write) 146940 146940 0 0.0
.bss 87560 87560 0 0.0
.data 1024 1024 0 0.0
.text 521048 521076 28 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 859086 859286 200 0.0
bss 88476 88476 0 0.0
noinit 37160 37160 0 0.0
text 602070 602242 172 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the fix-unknown-command-errors branch from d7717cc to df971f0 Compare February 5, 2022 02:49
@github-actions
Copy link

github-actions bot commented Feb 5, 2022 •
edited
Loading

PR #14806: Size comparison from 740284a to df971f0

Increases above 0.2%:

platform target config section 740284a df971f0 change % change
linux chip-tool-ipv6only arm64 (read only) 7238660 7266868 28208 0.4
.got 45784 46016 232 0.5
.text 6241140 6266948 25808 0.4
Increases (16 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section 740284a df971f0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587722 587902 180 0.0
.app_xip_area 494320 494500 180 0.0
lock cyw930739m2evb_01 (read/write) 545646 545802 156 0.0
.app_xip_area 453796 453952 156 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570062 570214 152 0.0
.app_xip_area 468900 469052 152 0.0
efr32 lighting-app BRD4161A (read only) 857408 857576 168 0.0
.text 857400 857568 168 0.0
BRD4161A+rpc (read only) 844760 844944 184 0.0
.text 844752 844936 184 0.0
window-app BRD4161A (read only) 829644 829796 152 0.0
.text 829636 829788 152 0.0
k32w light k32w061+release (read/write) 672284 672436 152 0.0
.text 588768 588920 152 0.0
lock k32w061+release (read/write) 673816 673968 152 0.0
.text 589932 590084 152 0.0
linux chip-tool-ipv6only arm64 (read only) 7238660 7266868 28208 0.4
(read/write) 287921 288561 640 0.2
.data.rel.ro 186528 186936 408 0.2
.got 45784 46016 232 0.5
.rodata 392684 393596 912 0.2
.text 6241140 6266948 25808 0.4
thermostat-no-ble arm64 (read only) 2126852 2127284 432 0.0
.rodata 131220 131252 32 0.0
.text 1777680 1778080 400 0.0
p6 all-clusters-app default (read/write) 2450216 2450400 184 0.0
.text 1408480 1408664 184 0.0
light-app default (read/write) 2353648 2353832 184 0.0
.text 1311912 1312096 184 0.0
lock-app default (read/write) 2318856 2319024 168 0.0
.text 1277120 1277288 168 0.0
qpg lighting-app qpg6105+debug (read only) 580400 580444 44 0.0
.text 575080 575124 44 0.0
lock-app qpg6105+debug (read only) 526480 526508 28 0.0
.text 521160 521188 28 0.0
telink lighting-app tlsr9518adk80d (read/write) 859174 859366 192 0.0
text 602154 602326 172 0.0
Full report (17 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section 740284a df971f0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587722 587902 180 0.0
.app_xip_area 494320 494500 180 0.0
.bss 76124 76124 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545646 545802 156 0.0
.app_xip_area 453796 453952 156 0.0
.bss 74604 74604 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570062 570214 152 0.0
.app_xip_area 468900 469052 152 0.0
.bss 83588 83588 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 857408 857576 168 0.0
(read/write) 125888 125888 0 0.0
.bss 123960 123960 0 0.0
.data 1924 1924 0 0.0
.text 857400 857568 168 0.0
BRD4161A+rpc (read only) 844760 844944 184 0.0
(read/write) 142544 142544 0 0.0
.bss 140520 140520 0 0.0
.data 2024 2024 0 0.0
.text 844752 844936 184 0.0
window-app BRD4161A (read only) 829644 829796 152 0.0
(read/write) 124528 124528 0 0.0
.bss 122648 122648 0 0.0
.data 1880 1880 0 0.0
.text 829636 829788 152 0.0
k32w light k32w061+release (read/write) 672284 672436 152 0.0
.bss 75832 75832 0 0.0
.data 1884 1884 0 0.0
.text 588768 588920 152 0.0
lock k32w061+release (read/write) 673816 673968 152 0.0
.bss 76160 76160 0 0.0
.data 1924 1924 0 0.0
.text 589932 590084 152 0.0
linux chip-tool-ipv6only arm64 (read only) 7238660 7266868 28208 0.4
(read/write) 287921 288561 640 0.2
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 186528 186936 408 0.2
.dynamic 560 560 0 0.0
.got 45784 46016 232 0.5
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 392684 393596 912 0.2
.text 6241140 6266948 25808 0.4
thermostat-no-ble arm64 (read only) 2126852 2127284 432 0.0
(read/write) 140705 140705 0 0.0
.bss 57745 57745 0 0.0
.data 968 968 0 0.0
.data.rel.ro 74872 74872 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131220 131252 32 0.0
.text 1777680 1778080 400 0.0
p6 all-clusters-app default (read/write) 2450216 2450400 184 0.0
.bss 117128 117128 0 0.0
.data 2584 2584 0 0.0
.text 1408480 1408664 184 0.0
light-app default (read/write) 2353648 2353832 184 0.0
.bss 106272 106272 0 0.0
.data 2432 2432 0 0.0
.text 1311912 1312096 184 0.0
lock-app default (read/write) 2318856 2319024 168 0.0
.bss 105992 105992 0 0.0
.data 2392 2392 0 0.0
.text 1277120 1277288 168 0.0
qpg lighting-app qpg6105+debug (read only) 580400 580444 44 0.0
(read/write) 146940 146940 0 0.0
.bss 88112 88112 0 0.0
.data 1088 1088 0 0.0
.text 575080 575124 44 0.0
lock-app qpg6105+debug (read only) 526480 526508 28 0.0
(read/write) 146940 146940 0 0.0
.bss 87560 87560 0 0.0
.data 1024 1024 0 0.0
.text 521160 521188 28 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 859174 859366 192 0.0
bss 88476 88476 0 0.0
noinit 37160 37160 0 0.0
text 602154 602326 172 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the fix-unknown-command-errors branch from df971f0 to 6eaf69a Compare February 5, 2022 03:45
@github-actions
Copy link

github-actions bot commented Feb 5, 2022 •
edited
Loading

PR #14806: Size comparison from 740284a to 6eaf69a

Increases above 0.2%:

platform target config section 740284a 6eaf69a change % change
linux chip-tool-ipv6only arm64 (read only) 7238660 7260644 21984 0.3
.got 45784 45904 120 0.3
.text 6241140 6261700 20560 0.3
Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 740284a 6eaf69a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587722 587902 180 0.0
.app_xip_area 494320 494500 180 0.0
lock cyw930739m2evb_01 (read/write) 545646 545802 156 0.0
.app_xip_area 453796 453952 156 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570062 570214 152 0.0
.app_xip_area 468900 469052 152 0.0
efr32 lighting-app BRD4161A (read only) 857408 857576 168 0.0
.text 857400 857568 168 0.0
BRD4161A+rpc (read only) 844760 844944 184 0.0
.text 844752 844936 184 0.0
window-app BRD4161A (read only) 829644 829796 152 0.0
.text 829636 829788 152 0.0
esp32 all-clusters-app c3devkit (read only) 936958 937134 176 0.0
(read/write) 1401186 1401210 24 0.0
.flash.rodata 197944 197968 24 0.0
.flash.text 936958 937134 176 0.0
m5stack (read only) 984947 985103 156 0.0
(read/write) 465536 465560 24 0.0
.flash.rodata 224552 224576 24 0.0
.flash.text 979563 979719 156 0.0
k32w light k32w061+release (read/write) 672284 672436 152 0.0
.text 588768 588920 152 0.0
lock k32w061+release (read/write) 673816 673968 152 0.0
.text 589932 590084 152 0.0
linux chip-tool-ipv6only arm64 (read only) 7238660 7260644 21984 0.3
(read/write) 287921 288385 464 0.2
.data.rel.ro 186528 186872 344 0.2
.got 45784 45904 120 0.3
.rodata 392684 393052 368 0.1
.text 6241140 6261700 20560 0.3
thermostat-no-ble arm64 (read only) 2126852 2127284 432 0.0
.rodata 131220 131252 32 0.0
.text 1777680 1778080 400 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2389136 2389184 48 0.0
.text 1351736 1351784 48 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2348328 2348440 112 0.0
.text 1310928 1311040 112 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2312312 2312360 48 0.0
.text 1274912 1274960 48 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2302652 2302700 48 0.0
.text 1265224 1265272 48 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 998135 998307 172 0.0
rodata 117252 117280 28 0.0
text 681432 681580 148 0.0
nrf52840dk_nrf52840+rpc (read/write) 969491 969659 168 0.0
rodata 108640 108664 24 0.0
text 665992 666132 140 0.0
nrf52840dongle_nrf52840 (read/write) 1014827 1014995 168 0.0
rodata 116092 116116 24 0.0
text 686928 687072 144 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904830 904998 168 0.0
rodata 110512 110536 24 0.0
text 596444 596592 148 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930279 930431 152 0.0
rodata 105604 105628 24 0.0
text 627292 627424 132 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 837802 837954 152 0.0
rodata 98772 98796 24 0.0
text 543076 543208 132 0.0
pump-app nrf52840dk_nrf52840 (read/write) 932907 933075 168 0.0
rodata 106072 106096 24 0.0
text 629632 629776 144 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 927863 928015 152 0.0
rodata 105076 105100 24 0.0
text 625572 625700 128 0.0
p6 all-clusters-app default (read/write) 2450216 2450400 184 0.0
.text 1408480 1408664 184 0.0
light-app default (read/write) 2353648 2353832 184 0.0
.text 1311912 1312096 184 0.0
lock-app default (read/write) 2318856 2319024 168 0.0
.text 1277120 1277288 168 0.0
qpg lighting-app qpg6105+debug (read only) 580400 580444 44 0.0
.text 575080 575124 44 0.0
lock-app qpg6105+debug (read only) 526480 526508 28 0.0
.text 521160 521188 28 0.0
telink lighting-app tlsr9518adk80d (read/write) 859174 859366 192 0.0
text 602154 602326 172 0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 740284a 6eaf69a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587722 587902 180 0.0
.app_xip_area 494320 494500 180 0.0
.bss 76124 76124 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545646 545802 156 0.0
.app_xip_area 453796 453952 156 0.0
.bss 74604 74604 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570062 570214 152 0.0
.app_xip_area 468900 469052 152 0.0
.bss 83588 83588 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 857408 857576 168 0.0
(read/write) 125888 125888 0 0.0
.bss 123960 123960 0 0.0
.data 1924 1924 0 0.0
.text 857400 857568 168 0.0
BRD4161A+rpc (read only) 844760 844944 184 0.0
(read/write) 142544 142544 0 0.0
.bss 140520 140520 0 0.0
.data 2024 2024 0 0.0
.text 844752 844936 184 0.0
window-app BRD4161A (read only) 829644 829796 152 0.0
(read/write) 124528 124528 0 0.0
.bss 122648 122648 0 0.0
.data 1880 1880 0 0.0
.text 829636 829788 152 0.0
esp32 all-clusters-app c3devkit (read only) 936958 937134 176 0.0
(read/write) 1401186 1401210 24 0.0
.dram0.bss 70064 70064 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 197944 197968 24 0.0
.flash.text 936958 937134 176 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 984947 985103 156 0.0
(read/write) 465536 465560 24 0.0
.dram0.bss 74816 74816 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 224552 224576 24 0.0
.flash.text 979563 979719 156 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 672284 672436 152 0.0
.bss 75832 75832 0 0.0
.data 1884 1884 0 0.0
.text 588768 588920 152 0.0
lock k32w061+release (read/write) 673816 673968 152 0.0
.bss 76160 76160 0 0.0
.data 1924 1924 0 0.0
.text 589932 590084 152 0.0
linux chip-tool-ipv6only arm64 (read only) 7238660 7260644 21984 0.3
(read/write) 287921 288385 464 0.2
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 186528 186872 344 0.2
.dynamic 560 560 0 0.0
.got 45784 45904 120 0.3
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 392684 393052 368 0.1
.text 6241140 6261700 20560 0.3
thermostat-no-ble arm64 (read only) 2126852 2127284 432 0.0
(read/write) 140705 140705 0 0.0
.bss 57745 57745 0 0.0
.data 968 968 0 0.0
.data.rel.ro 74872 74872 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131220 131252 32 0.0
.text 1777680 1778080 400 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389136 2389184 48 0.0
.bss 188972 188972 0 0.0
.data 5296 5296 0 0.0
.text 1351736 1351784 48 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348328 2348440 112 0.0
.bss 181072 181072 0 0.0
.data 5600 5600 0 0.0
.text 1310928 1311040 112 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312312 2312360 48 0.0
.bss 180960 180960 0 0.0
.data 5584 5584 0 0.0
.text 1274912 1274960 48 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302652 2302700 48 0.0
.bss 178244 178244 0 0.0
.data 5400 5400 0 0.0
.text 1265224 1265272 48 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 998135 998307 172 0.0
bss 120544 120544 0 0.0
rodata 117252 117280 28 0.0
text 681432 681580 148 0.0
nrf52840dk_nrf52840+rpc (read/write) 969491 969659 168 0.0
bss 116400 116400 0 0.0
rodata 108640 108664 24 0.0
text 665992 666132 140 0.0
nrf52840dongle_nrf52840 (read/write) 1014827 1014995 168 0.0
bss 121908 121908 0 0.0
rodata 116092 116116 24 0.0
text 686928 687072 144 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904830 904998 168 0.0
bss 117108 117108 0 0.0
rodata 110512 110536 24 0.0
text 596444 596592 148 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930279 930431 152 0.0
bss 118884 118884 0 0.0
rodata 105604 105628 24 0.0
text 627292 627424 132 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 837802 837954 152 0.0
bss 115476 115476 0 0.0
rodata 98772 98796 24 0.0
text 543076 543208 132 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 932907 933075 168 0.0
bss 118636 118636 0 0.0
rodata 106072 106096 24 0.0
text 629632 629776 144 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 927863 928015 152 0.0
bss 118636 118636 0 0.0
rodata 105076 105100 24 0.0
text 625572 625700 128 0.0
shell nrf52840dk_nrf52840 (read/write) 802811 802811 0 0.0
bss 110968 110968 0 0.0
rodata 78480 78480 0 0.0
text 535792 535792 0 0.0
p6 all-clusters-app default (read/write) 2450216 2450400 184 0.0
.bss 117128 117128 0 0.0
.data 2584 2584 0 0.0
.text 1408480 1408664 184 0.0
light-app default (read/write) 2353648 2353832 184 0.0
.bss 106272 106272 0 0.0
.data 2432 2432 0 0.0
.text 1311912 1312096 184 0.0
lock-app default (read/write) 2318856 2319024 168 0.0
.bss 105992 105992 0 0.0
.data 2392 2392 0 0.0
.text 1277120 1277288 168 0.0
qpg lighting-app qpg6105+debug (read only) 580400 580444 44 0.0
(read/write) 146940 146940 0 0.0
.bss 88112 88112 0 0.0
.data 1088 1088 0 0.0
.text 575080 575124 44 0.0
lock-app qpg6105+debug (read only) 526480 526508 28 0.0
(read/write) 146940 146940 0 0.0
.bss 87560 87560 0 0.0
.data 1024 1024 0 0.0
.text 521160 521188 28 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 859174 859366 192 0.0
bss 88476 88476 0 0.0
noinit 37160 37160 0 0.0
text 602154 602326 172 0.0

@bzbarsky-apple
Add correct checking for whether a command is supported.
606d9d2 
This also fixes the status reporting for unsupported endpoints and
clusters.  And fixes some tests to use the right endpoint, now that we
are checking that sort of thing.

Fixes project-chip#7612
Fixes project-chip#13920
Fixes project-chip#14022
Fixes project-chip#11578
Fixes project-chip#11185
@bzbarsky-apple bzbarsky-apple force-pushed the fix-unknown-command-errors branch from 6eaf69a to 606d9d2 Compare February 5, 2022 06:52
@github-actions
Copy link

github-actions bot commented Feb 5, 2022 •
edited
Loading

PR #14806: Size comparison from 740284a to 606d9d2

Increases above 0.2%:

platform target config section 740284a 606d9d2 change % change
linux chip-tool debug (read only) 7298237 7321493 23256 0.3
.text 6518133 6540597 22464 0.3
chip-tool-ipv6only arm64 (read only) 7238660 7260644 21984 0.3
.got 45784 45904 120 0.3
.text 6241140 6261700 20560 0.3
Increases (39 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 740284a 606d9d2 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587722 587902 180 0.0
.app_xip_area 494320 494500 180 0.0
lock cyw930739m2evb_01 (read/write) 545646 545802 156 0.0
.app_xip_area 453796 453952 156 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570062 570214 152 0.0
.app_xip_area 468900 469052 152 0.0
efr32 lighting-app BRD4161A (read only) 857408 857576 168 0.0
.text 857400 857568 168 0.0
BRD4161A+rpc (read only) 844760 844944 184 0.0
.text 844752 844936 184 0.0
window-app BRD4161A (read only) 829644 829796 152 0.0
.text 829636 829788 152 0.0
esp32 all-clusters-app c3devkit (read only) 936958 937134 176 0.0
(read/write) 1401186 1401210 24 0.0
.flash.rodata 197944 197968 24 0.0
.flash.text 936958 937134 176 0.0
m5stack (read only) 984947 985103 156 0.0
(read/write) 465536 465560 24 0.0
.flash.rodata 224552 224576 24 0.0
.flash.text 979563 979719 156 0.0
k32w light k32w061+release (read/write) 672284 672436 152 0.0
.text 588768 588920 152 0.0
lock k32w061+release (read/write) 673816 673968 152 0.0
.text 589932 590084 152 0.0
linux all-clusters-app debug (read only) 2323905 2324241 336 0.0
.rodata 204197 204229 32 0.0
.text 1957506 1957810 304 0.0
bridge-app debug+rpc (read only) 1700453 1700813 360 0.0
.rodata 139476 139508 32 0.0
.text 1444549 1444853 304 0.0
chip-tool debug (read only) 7298237 7321493 23256 0.3
(read/write) 184592 184816 224 0.1
.data.rel.ro 145072 145312 240 0.2
.rodata 410165 410357 192 0.0
.text 6518133 6540597 22464 0.3
chip-tool-ipv6only arm64 (read only) 7238660 7260644 21984 0.3
(read/write) 287921 288385 464 0.2
.data.rel.ro 186528 186872 344 0.2
.got 45784 45904 120 0.3
.rodata 392684 393052 368 0.1
.text 6241140 6261700 20560 0.3
door-lock-app debug (read only) 1904489 1904777 288 0.0
.rodata 171996 172028 32 0.0
.text 1584098 1584354 256 0.0
lighting-app debug+rpc (read only) 1999313 1999649 336 0.0
.rodata 162097 162129 32 0.0
.text 1682690 1682994 304 0.0
ota-provider-app debug (read only) 1708553 1708841 288 0.0
.rodata 150054 150086 32 0.0
.text 1439922 1440178 256 0.0
ota-requestor-app debug (read only) 1700001 1700289 288 0.0
.rodata 144535 144567 32 0.0
.text 1438690 1438946 256 0.0
shell debug (read only) 2297961 2298297 336 0.0
.rodata 205074 205106 32 0.0
.text 1936466 1936770 304 0.0
thermostat-no-ble arm64 (read only) 2126852 2127284 432 0.0
.rodata 131220 131252 32 0.0
.text 1777680 1778080 400 0.0
tv-app debug (read only) 2518417 2519281 864 0.0
.rodata 193492 193716 224 0.1
.text 2151890 2152194 304 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2389136 2389184 48 0.0
.text 1351736 1351784 48 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2348328 2348440 112 0.0
.text 1310928 1311040 112 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2312312 2312360 48 0.0
.text 1274912 1274960 48 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2302652 2302700 48 0.0
.text 1265224 1265272 48 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 998135 998307 172 0.0
rodata 117252 117280 28 0.0
text 681432 681580 148 0.0
nrf52840dk_nrf52840+rpc (read/write) 969491 969659 168 0.0
rodata 108640 108664 24 0.0
text 665992 666132 140 0.0
nrf52840dongle_nrf52840 (read/write) 1014827 1014995 168 0.0
rodata 116092 116116 24 0.0
text 686928 687072 144 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904830 904998 168 0.0
rodata 110512 110536 24 0.0
text 596444 596592 148 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930279 930431 152 0.0
rodata 105604 105628 24 0.0
text 627292 627424 132 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 837802 837954 152 0.0
rodata 98772 98796 24 0.0
text 543076 543208 132 0.0
pump-app nrf52840dk_nrf52840 (read/write) 932907 933075 168 0.0
rodata 106072 106096 24 0.0
text 629632 629776 144 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 927863 928015 152 0.0
rodata 105076 105100 24 0.0
text 625572 625700 128 0.0
p6 all-clusters-app default (read/write) 2450216 2450400 184 0.0
.text 1408480 1408664 184 0.0
light-app default (read/write) 2353648 2353832 184 0.0
.text 1311912 1312096 184 0.0
lock-app default (read/write) 2318856 2319024 168 0.0
.text 1277120 1277288 168 0.0
qpg lighting-app qpg6105+debug (read only) 580400 580444 44 0.0
.text 575080 575124 44 0.0
lock-app qpg6105+debug (read only) 526480 526508 28 0.0
.text 521160 521188 28 0.0
telink lighting-app tlsr9518adk80d (read/write) 859174 859366 192 0.0
text 602154 602326 172 0.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 740284a 606d9d2 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587722 587902 180 0.0
.app_xip_area 494320 494500 180 0.0
.bss 76124 76124 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545646 545802 156 0.0
.app_xip_area 453796 453952 156 0.0
.bss 74604 74604 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570062 570214 152 0.0
.app_xip_area 468900 469052 152 0.0
.bss 83588 83588 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 857408 857576 168 0.0
(read/write) 125888 125888 0 0.0
.bss 123960 123960 0 0.0
.data 1924 1924 0 0.0
.text 857400 857568 168 0.0
BRD4161A+rpc (read only) 844760 844944 184 0.0
(read/write) 142544 142544 0 0.0
.bss 140520 140520 0 0.0
.data 2024 2024 0 0.0
.text 844752 844936 184 0.0
window-app BRD4161A (read only) 829644 829796 152 0.0
(read/write) 124528 124528 0 0.0
.bss 122648 122648 0 0.0
.data 1880 1880 0 0.0
.text 829636 829788 152 0.0
esp32 all-clusters-app c3devkit (read only) 936958 937134 176 0.0
(read/write) 1401186 1401210 24 0.0
.dram0.bss 70064 70064 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 197944 197968 24 0.0
.flash.text 936958 937134 176 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 984947 985103 156 0.0
(read/write) 465536 465560 24 0.0
.dram0.bss 74816 74816 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 224552 224576 24 0.0
.flash.text 979563 979719 156 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 672284 672436 152 0.0
.bss 75832 75832 0 0.0
.data 1884 1884 0 0.0
.text 588768 588920 152 0.0
lock k32w061+release (read/write) 673816 673968 152 0.0
.bss 76160 76160 0 0.0
.data 1924 1924 0 0.0
.text 589932 590084 152 0.0
linux all-clusters-app debug (read only) 2323905 2324241 336 0.0
(read/write) 140032 140032 0 0.0
.bss 54656 54656 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 78504 78504 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 204197 204229 32 0.0
.text 1957506 1957810 304 0.0
bridge-app debug+rpc (read only) 1700453 1700813 360 0.0
(read/write) 84504 84504 0 0.0
.bss 39264 39264 0 0.0
.data 1986 1986 0 0.0
.data.rel.ro 38088 38088 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 139476 139508 32 0.0
.text 1444549 1444853 304 0.0
chip-tool debug (read only) 7298237 7321493 23256 0.3
(read/write) 184592 184816 224 0.1
.bss 32360 32360 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 145072 145312 240 0.2
.dynamic 608 608 0 0.0
.got 4760 4760 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 410165 410357 192 0.0
.text 6518133 6540597 22464 0.3
chip-tool-ipv6only arm64 (read only) 7238660 7260644 21984 0.3
(read/write) 287921 288385 464 0.2
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 186528 186872 344 0.2
.dynamic 560 560 0 0.0
.got 45784 45904 120 0.3
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 392684 393052 368 0.1
.text 6241140 6261700 20560 0.3
door-lock-app debug (read only) 1904489 1904777 288 0.0
(read/write) 110760 110760 0 0.0
.bss 42272 42272 0 0.0
.data 962 962 0 0.0
.data.rel.ro 62088 62088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171996 172028 32 0.0
.text 1584098 1584354 256 0.0
lighting-app debug+rpc (read only) 1999313 1999649 336 0.0
(read/write) 115784 115784 0 0.0
.bss 43256 43256 0 0.0
.data 1384 1384 0 0.0
.data.rel.ro 65640 65640 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 162097 162129 32 0.0
.text 1682690 1682994 304 0.0
ota-provider-app debug (read only) 1708553 1708841 288 0.0
(read/write) 81400 81400 0 0.0
.bss 41248 41248 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 33528 33528 0 0.0
.dynamic 608 608 0 0.0
.got 4248 4248 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 150054 150086 32 0.0
.text 1439922 1440178 256 0.0
ota-requestor-app debug (read only) 1700001 1700289 288 0.0
(read/write) 83448 83448 0 0.0
.bss 42432 42432 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 34584 34584 0 0.0
.dynamic 592 592 0 0.0
.got 4040 4040 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 144535 144567 32 0.0
.text 1438690 1438946 256 0.0
shell debug (read only) 2297961 2298297 336 0.0
(read/write) 141552 141552 0 0.0
.bss 62016 62016 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73040 73040 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205074 205106 32 0.0
.text 1936466 1936770 304 0.0
thermostat-no-ble arm64 (read only) 2126852 2127284 432 0.0
(read/write) 140705 140705 0 0.0
.bss 57745 57745 0 0.0
.data 968 968 0 0.0
.data.rel.ro 74872 74872 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131220 131252 32 0.0
.text 1777680 1778080 400 0.0
tv-app debug (read only) 2518417 2519281 864 0.0
(read/write) 139704 139704 0 0.0
.bss 57280 57280 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73224 73224 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 193492 193716 224 0.1
.text 2151890 2152194 304 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389136 2389184 48 0.0
.bss 188972 188972 0 0.0
.data 5296 5296 0 0.0
.text 1351736 1351784 48 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348328 2348440 112 0.0
.bss 181072 181072 0 0.0
.data 5600 5600 0 0.0
.text 1310928 1311040 112 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312312 2312360 48 0.0
.bss 180960 180960 0 0.0
.data 5584 5584 0 0.0
.text 1274912 1274960 48 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302652 2302700 48 0.0
.bss 178244 178244 0 0.0
.data 5400 5400 0 0.0
.text 1265224 1265272 48 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 998135 998307 172 0.0
bss 120544 120544 0 0.0
rodata 117252 117280 28 0.0
text 681432 681580 148 0.0
nrf52840dk_nrf52840+rpc (read/write) 969491 969659 168 0.0
bss 116400 116400 0 0.0
rodata 108640 108664 24 0.0
text 665992 666132 140 0.0
nrf52840dongle_nrf52840 (read/write) 1014827 1014995 168 0.0
bss 121908 121908 0 0.0
rodata 116092 116116 24 0.0
text 686928 687072 144 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904830 904998 168 0.0
bss 117108 117108 0 0.0
rodata 110512 110536 24 0.0
text 596444 596592 148 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930279 930431 152 0.0
bss 118884 118884 0 0.0
rodata 105604 105628 24 0.0
text 627292 627424 132 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 837802 837954 152 0.0
bss 115476 115476 0 0.0
rodata 98772 98796 24 0.0
text 543076 543208 132 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 932907 933075 168 0.0
bss 118636 118636 0 0.0
rodata 106072 106096 24 0.0
text 629632 629776 144 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 927863 928015 152 0.0
bss 118636 118636 0 0.0
rodata 105076 105100 24 0.0
text 625572 625700 128 0.0
shell nrf52840dk_nrf52840 (read/write) 802811 802811 0 0.0
bss 110968 110968 0 0.0
rodata 78480 78480 0 0.0
text 535792 535792 0 0.0
p6 all-clusters-app default (read/write) 2450216 2450400 184 0.0
.bss 117128 117128 0 0.0
.data 2584 2584 0 0.0
.text 1408480 1408664 184 0.0
light-app default (read/write) 2353648 2353832 184 0.0
.bss 106272 106272 0 0.0
.data 2432 2432 0 0.0
.text 1311912 1312096 184 0.0
lock-app default (read/write) 2318856 2319024 168 0.0
.bss 105992 105992 0 0.0
.data 2392 2392 0 0.0
.text 1277120 1277288 168 0.0
qpg lighting-app qpg6105+debug (read only) 580400 580444 44 0.0
(read/write) 146940 146940 0 0.0
.bss 88112 88112 0 0.0
.data 1088 1088 0 0.0
.text 575080 575124 44 0.0
lock-app qpg6105+debug (read only) 526480 526508 28 0.0
(read/write) 146940 146940 0 0.0
.bss 87560 87560 0 0.0
.data 1024 1024 0 0.0
.text 521160 521188 28 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 859174 859366 192 0.0
bss 88476 88476 0 0.0
noinit 37160 37160 0 0.0
text 602154 602326 172 0.0

mrjerryjohns
mrjerryjohns approved these changes Feb 7, 2022
View reviewed changes
examples/bridge-app/esp32/main/main.cpp Show resolved Hide resolved
examples/tv-app/linux/AppImpl.cpp Show resolved Hide resolved
@bzbarsky-apple bzbarsky-apple merged commit 26fa3fa into project-chip:master Feb 7, 2022
@bzbarsky-apple bzbarsky-apple deleted the fix-unknown-command-errors branch February 7, 2022 20:11
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Feb 7, 2022
@bzbarsky-apple @mkardous-silabs
Add correct checking for whether a command is supported. (project-chi…
9684468 
…p#14806)

This also fixes the status reporting for unsupported endpoints and
clusters.  And fixes some tests to use the right endpoint, now that we
are checking that sort of thing.

Fixes project-chip#7612
Fixes project-chip#13920
Fixes project-chip#14022
Fixes project-chip#11578
Fixes project-chip#11185
@bzbarsky-apple bzbarsky-apple mentioned this pull request May 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller darwin examples github review - approved
Projects
None yet
Milestone
No milestone
4 participants
@bzbarsky-apple @msandstedt @mrjerryjohns @jmartinez-silabs