Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bdx] Added BlockQueryWithSkip message and BlockCounter field to BlockData #12767

Merged
merged 3 commits into from
Dec 13, 2021
Merged

[bdx] Added BlockQueryWithSkip message and BlockCounter field to BlockData #12767

merged 3 commits into from
Dec 13, 2021

Conversation

shubhamdp
Copy link
Contributor

Problem

Change overview

Added BlockCounter field to BlockData
Added BlockQueryWithSkip message to BDX messages

Testing

  • Added unit tests to validate the block counter
  • Added unit test to validate the BlockQueryWithSkip message
  • Manually tested the BlockQueryWithSkip message with Linux OTA Requestor and Provider example.

@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12767: Size comparison from bba082b to 6507309

Increases (1 build for esp32)
platform target config section bba082b 6507309 change % change
esp32 all-clusters-app m5stack (read only) 962535 962975 440 0.0
(read/write) 450980 451084 104 0.0
.dram0.bss 75000 75008 8 0.0
.flash.rodata 210144 210240 96 0.0
.flash.text 957151 957591 440 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bba082b 6507309 change % change
efr32 lighting-app BRD4161A (read only) 804020 804020 0 0.0
(read/write) 122988 122988 0 0.0
.bss 121168 121168 0 0.0
.data 1820 1820 0 0.0
.text 804012 804012 0 0.0
BRD4161A+rpc (read only) 791616 791616 0 0.0
(read/write) 139672 139672 0 0.0
.bss 137744 137744 0 0.0
.data 1928 1928 0 0.0
.text 791608 791608 0 0.0
window-app BRD4161A (read only) 780732 780732 0 0.0
(read/write) 121120 121120 0 0.0
.bss 119336 119336 0 0.0
.data 1784 1784 0 0.0
.text 780724 780724 0 0.0
esp32 all-clusters-app c3devkit (read only) 859206 859206 0 0.0
(read/write) 1306706 1306706 0 0.0
.dram0.bss 67632 67632 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 171920 171920 0 0.0
.flash.text 859206 859206 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 962535 962975 440 0.0
(read/write) 450980 451084 104 0.0
.dram0.bss 75000 75008 8 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210144 210240 96 0.0
.flash.text 957151 957591 440 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724652 724652 0 0.0
.bss 81232 81232 0 0.0
.data 1852 1852 0 0.0
.text 635768 635768 0 0.0
lock-app k32w061+debug (read/write) 615812 615812 0 0.0
.bss 71896 71896 0 0.0
.data 1820 1820 0 0.0
.text 536296 536296 0 0.0
shell k32w061+debug (read/write) 679068 679068 0 0.0
.bss 81596 81596 0 0.0
.data 1792 1792 0 0.0
.text 589880 589880 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6786172 6786172 0 0.0
(read/write) 312337 312337 0 0.0
.bss 51633 51633 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 207632 207632 0 0.0
.dynamic 560 560 0 0.0
.got 48384 48384 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 342396 342396 0 0.0
.text 5782132 5782132 0 0.0
thermostat-no-ble arm64 (read only) 1931988 1931988 0 0.0
(read/write) 136337 136337 0 0.0
.bss 59441 59441 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69736 69736 0 0.0
.dynamic 560 560 0 0.0
.got 3520 3520 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124820 124820 0 0.0
.text 1601440 1601440 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2320200 2320200 0 0.0
.bss 186884 186884 0 0.0
.data 5232 5232 0 0.0
.heap 844328 844328 0 0.0
.text 1282776 1282776 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305992 2305992 0 0.0
.bss 175696 175696 0 0.0
.data 5488 5488 0 0.0
.heap 855264 855264 0 0.0
.text 1268592 1268592 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2278720 2278720 0 0.0
.bss 174736 174736 0 0.0
.data 5488 5488 0 0.0
.heap 856224 856224 0 0.0
.text 1241320 1241320 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047808 2047808 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010408 1010408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 903299 903299 0 0.0
bss 116168 116168 0 0.0
rodata 101164 101164 0 0.0
text 610392 610392 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 866323 866323 0 0.0
bss 112516 112516 0 0.0
rodata 92460 92460 0 0.0
text 585120 585120 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 829290 829290 0 0.0
bss 117544 117544 0 0.0
rodata 96420 96420 0 0.0
text 540820 540820 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 875527 875527 0 0.0
bss 113432 113432 0 0.0
rodata 97280 97280 0 0.0
text 589452 589452 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801774 801774 0 0.0
bss 114840 114840 0 0.0
rodata 92568 92568 0 0.0
text 519976 519976 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 880455 880455 0 0.0
bss 113344 113344 0 0.0
rodata 98632 98632 0 0.0
text 593044 593044 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 873667 873667 0 0.0
bss 113220 113220 0 0.0
rodata 96772 96772 0 0.0
text 588204 588204 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781627 781627 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523280 523280 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696702 696702 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443924 443924 0 0.0
p6 all-clusters-app default (read/write) 2356232 2356232 0 0.0
.bss 113116 113116 0 0.0
.data 2512 2512 0 0.0
.heap 917712 917712 0 0.0
.text 1314496 1314496 0 0.0
light-app default (read/write) 2290528 2290528 0 0.0
.bss 100888 100888 0 0.0
.data 2328 2328 0 0.0
.heap 930128 930128 0 0.0
.text 1248792 1248792 0 0.0
lock-app default (read/write) 2266392 2266392 0 0.0
.bss 99768 99768 0 0.0
.data 2288 2288 0 0.0
.heap 931288 931288 0 0.0
.text 1224656 1224656 0 0.0
qpg lighting-app qpg6100+debug (read only) 517960 517960 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82616 0 0.0
.data 956 956 0 0.0
.text 512640 512640 0 0.0
lock-app qpg6100+debug (read only) 491960 491960 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81752 0 0.0
.data 912 912 0 0.0
.text 486640 486640 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807478 807478 0 0.0
bss 82748 82748 0 0.0
noinit 37160 37160 0 0.0
text 563540 563540 0 0.0

@woody-apple
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12767: Size comparison from d9e7e54 to 752e38c

Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d9e7e54 752e38c change % change
efr32 lighting-app BRD4161A (read only) 807372 807372 0 0.0
(read/write) 123008 123008 0 0.0
.bss 121160 121160 0 0.0
.data 1848 1848 0 0.0
.text 807364 807364 0 0.0
BRD4161A+rpc (read only) 795008 795008 0 0.0
(read/write) 139696 139696 0 0.0
.bss 137736 137736 0 0.0
.data 1956 1956 0 0.0
.text 795000 795000 0 0.0
window-app BRD4161A (read only) 784348 784348 0 0.0
(read/write) 121140 121140 0 0.0
.bss 119328 119328 0 0.0
.data 1812 1812 0 0.0
.text 784340 784340 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 668468 668468 0 0.0
.bss 73744 73744 0 0.0
.data 1880 1880 0 0.0
.text 587044 587044 0 0.0
lock-app k32w061+debug (read/write) 618428 618428 0 0.0
.bss 71896 71896 0 0.0
.data 1848 1848 0 0.0
.text 538884 538884 0 0.0
shell k32w061+debug (read/write) 623520 623520 0 0.0
.bss 74124 74124 0 0.0
.data 1820 1820 0 0.0
.text 541776 541776 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6792492 6792492 0 0.0
(read/write) 318273 318273 0 0.0
.bss 51713 51713 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208720 208720 0 0.0
.dynamic 560 560 0 0.0
.got 53048 53048 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 363884 363884 0 0.0
.text 5749668 5749668 0 0.0
thermostat-no-ble arm64 (read only) 1943060 1943060 0 0.0
(read/write) 136865 136865 0 0.0
.bss 59441 59441 0 0.0
.data 824 824 0 0.0
.data.rel.ro 70160 70160 0 0.0
.dynamic 560 560 0 0.0
.got 3568 3568 0 0.0
.init 24 24 0 0.0
.init_array 264 264 0 0.0
.rodata 125300 125300 0 0.0
.text 1610608 1610608 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2323312 2323312 0 0.0
.bss 184972 184972 0 0.0
.data 5232 5232 0 0.0
.heap 846240 846240 0 0.0
.text 1285888 1285888 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307944 2307944 0 0.0
.bss 175688 175688 0 0.0
.data 5520 5520 0 0.0
.heap 855240 855240 0 0.0
.text 1270544 1270544 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281056 2281056 0 0.0
.bss 174728 174728 0 0.0
.data 5520 5520 0 0.0
.heap 856200 856200 0 0.0
.text 1243656 1243656 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053344 2053344 0 0.0
.bss 156892 156892 0 0.0
.data 4864 4864 0 0.0
.heap 874688 874688 0 0.0
.text 1015944 1015944 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 905563 905563 0 0.0
bss 116168 116168 0 0.0
rodata 101676 101676 0 0.0
text 612128 612128 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 868603 868603 0 0.0
bss 112516 112516 0 0.0
rodata 92972 92972 0 0.0
text 586856 586856 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831570 831570 0 0.0
bss 117544 117544 0 0.0
rodata 96932 96932 0 0.0
text 542556 542556 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 878191 878191 0 0.0
bss 113432 113432 0 0.0
rodata 97792 97792 0 0.0
text 591572 591572 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 804438 804438 0 0.0
bss 114840 114840 0 0.0
rodata 93080 93080 0 0.0
text 522092 522092 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 883119 883119 0 0.0
bss 113344 113344 0 0.0
rodata 99144 99144 0 0.0
text 595160 595160 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 876363 876363 0 0.0
bss 113220 113220 0 0.0
rodata 97284 97284 0 0.0
text 590360 590360 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781947 781947 0 0.0
bss 109544 109544 0 0.0
rodata 74280 74280 0 0.0
text 523604 523604 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696994 696994 0 0.0
bss 110524 110524 0 0.0
rodata 68924 68924 0 0.0
text 444244 444244 0 0.0
p6 all-clusters-app default (read/write) 2360072 2360072 0 0.0
.bss 113108 113108 0 0.0
.data 2512 2512 0 0.0
.heap 917720 917720 0 0.0
.text 1318336 1318336 0 0.0
light-app default (read/write) 2292872 2292872 0 0.0
.bss 100880 100880 0 0.0
.data 2352 2352 0 0.0
.heap 930112 930112 0 0.0
.text 1251136 1251136 0 0.0
lock-app default (read/write) 2268936 2268936 0 0.0
.bss 99760 99760 0 0.0
.data 2320 2320 0 0.0
.heap 931264 931264 0 0.0
.text 1227200 1227200 0 0.0
qpg lighting-app qpg6100+debug (read only) 520260 520260 0 0.0
(read/write) 122336 122336 0 0.0
.bss 82616 82616 0 0.0
.data 984 984 0 0.0
.text 514940 514940 0 0.0
lock-app qpg6100+debug (read only) 494636 494636 0 0.0
(read/write) 122332 122332 0 0.0
.bss 81752 81752 0 0.0
.data 940 940 0 0.0
.text 489316 489316 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 809658 809658 0 0.0
bss 82736 82736 0 0.0
noinit 37160 37160 0 0.0
text 565164 565164 0 0.0

@woody-apple
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12767: Size comparison from 586aca7 to c522abd

Increases (1 build for esp32)
platform target config section 586aca7 c522abd change % change
esp32 all-clusters-app m5stack (read only) 966015 966447 432 0.0
(read/write) 451744 451848 104 0.0
.dram0.bss 75128 75136 8 0.0
.flash.rodata 210772 210868 96 0.0
.flash.text 960631 961063 432 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 586aca7 c522abd change % change
efr32 lighting-app BRD4161A (read only) 809204 809204 0 0.0
(read/write) 123148 123148 0 0.0
.bss 121288 121288 0 0.0
.data 1860 1860 0 0.0
.text 809196 809196 0 0.0
BRD4161A+rpc (read only) 796824 796824 0 0.0
(read/write) 139824 139824 0 0.0
.bss 137864 137864 0 0.0
.data 1960 1960 0 0.0
.text 796816 796816 0 0.0
window-app BRD4161A (read only) 786180 786180 0 0.0
(read/write) 121280 121280 0 0.0
.bss 119456 119456 0 0.0
.data 1824 1824 0 0.0
.text 786172 786172 0 0.0
esp32 all-clusters-app c3devkit (read only) 862792 862792 0 0.0
(read/write) 1306058 1306058 0 0.0
.dram0.bss 65832 65832 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 173064 173064 0 0.0
.flash.text 862792 862792 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 966015 966447 432 0.0
(read/write) 451744 451848 104 0.0
.dram0.bss 75128 75136 8 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 210772 210868 96 0.0
.flash.text 960631 961063 432 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669560 669560 0 0.0
.bss 73872 73872 0 0.0
.data 1892 1892 0 0.0
.text 587996 587996 0 0.0
lock-app k32w061+debug (read/write) 619508 619508 0 0.0
.bss 72024 72024 0 0.0
.data 1852 1852 0 0.0
.text 539832 539832 0 0.0
shell k32w061+debug (read/write) 624608 624608 0 0.0
.bss 74252 74252 0 0.0
.data 1832 1832 0 0.0
.text 542724 542724 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6864988 6864988 0 0.0
(read/write) 318785 318785 0 0.0
.bss 51985 51985 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208776 208776 0 0.0
.dynamic 560 560 0 0.0
.got 53096 53096 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364764 364764 0 0.0
.text 5820564 5820564 0 0.0
thermostat-no-ble arm64 (read only) 1947444 1947444 0 0.0
(read/write) 137201 137201 0 0.0
.bss 59601 59601 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70304 70304 0 0.0
.dynamic 560 560 0 0.0
.got 3592 3592 0 0.0
.init 24 24 0 0.0
.init_array 272 272 0 0.0
.rodata 125508 125508 0 0.0
.text 1614432 1614432 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2324328 2324328 0 0.0
.bss 185108 185108 0 0.0
.data 5240 5240 0 0.0
.heap 846096 846096 0 0.0
.text 1286904 1286904 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308944 2308944 0 0.0
.bss 175824 175824 0 0.0
.data 5528 5528 0 0.0
.heap 855096 855096 0 0.0
.text 1271544 1271544 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282064 2282064 0 0.0
.bss 174864 174864 0 0.0
.data 5520 5520 0 0.0
.heap 856064 856064 0 0.0
.text 1244664 1244664 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053336 2053336 0 0.0
.bss 156900 156900 0 0.0
.data 4864 4864 0 0.0
.heap 874680 874680 0 0.0
.text 1015936 1015936 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906747 906747 0 0.0
bss 116296 116296 0 0.0
rodata 101980 101980 0 0.0
text 612876 612876 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 869795 869795 0 0.0
bss 112644 112644 0 0.0
rodata 93276 93276 0 0.0
text 587604 587604 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832762 832762 0 0.0
bss 117672 117672 0 0.0
rodata 97236 97236 0 0.0
text 543304 543304 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 879375 879375 0 0.0
bss 113560 113560 0 0.0
rodata 98096 98096 0 0.0
text 592320 592320 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 805634 805634 0 0.0
bss 114968 114968 0 0.0
rodata 93388 93388 0 0.0
text 522840 522840 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 884315 884315 0 0.0
bss 113472 113472 0 0.0
rodata 99452 99452 0 0.0
text 595912 595912 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 877555 877555 0 0.0
bss 113348 113348 0 0.0
rodata 97588 97588 0 0.0
text 591108 591108 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781927 781927 0 0.0
bss 109544 109544 0 0.0
rodata 74276 74276 0 0.0
text 523588 523588 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696974 696974 0 0.0
bss 110524 110524 0 0.0
rodata 68920 68920 0 0.0
text 444228 444228 0 0.0
p6 all-clusters-app default (read/write) 2361904 2361904 0 0.0
.bss 113244 113244 0 0.0
.data 2520 2520 0 0.0
.heap 917576 917576 0 0.0
.text 1320168 1320168 0 0.0
light-app default (read/write) 2294704 2294704 0 0.0
.bss 101016 101016 0 0.0
.data 2360 2360 0 0.0
.heap 929968 929968 0 0.0
.text 1252968 1252968 0 0.0
lock-app default (read/write) 2270784 2270784 0 0.0
.bss 99896 99896 0 0.0
.data 2328 2328 0 0.0
.heap 931120 931120 0 0.0
.text 1229048 1229048 0 0.0
qpg lighting-app qpg6100+debug (read only) 521320 521320 0 0.0
(read/write) 122336 122336 0 0.0
.bss 82712 82712 0 0.0
.data 992 992 0 0.0
.text 516000 516000 0 0.0
lock-app qpg6100+debug (read only) 495688 495688 0 0.0
(read/write) 122332 122332 0 0.0
.bss 81848 81848 0 0.0
.data 948 948 0 0.0
.text 490368 490368 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 810954 810954 0 0.0
bss 82864 82864 0 0.0
noinit 37160 37160 0 0.0
text 566006 566006 0 0.0

andy31415
andy31415 approved these changes Dec 10, 2021
View reviewed changes
src/protocols/bdx/BdxMessages.h Outdated Show resolved Hide resolved
src/protocols/bdx/BdxMessages.h Outdated Show resolved Hide resolved
@shubhamdp
Copy link
Contributor Author

/rebase

@github-actions
Copy link

github-actions bot commented Dec 11, 2021 •
edited
Loading

PR #12767: Size comparison from 654c3e1 to 3723894

Increases (1 build for esp32)
platform target config section 654c3e1 3723894 change % change
esp32 all-clusters-app m5stack (read only) 960079 960535 456 0.0
(read/write) 449992 450096 104 0.0
.dram0.bss 73960 73968 8 0.0
.flash.rodata 210196 210292 96 0.0
.flash.text 954695 955151 456 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 654c3e1 3723894 change % change
efr32 lighting-app BRD4161A (read only) 814844 814844 0 0.0
(read/write) 123132 123132 0 0.0
.bss 121272 121272 0 0.0
.data 1860 1860 0 0.0
.text 814836 814836 0 0.0
BRD4161A+rpc (read only) 802476 802476 0 0.0
(read/write) 139808 139808 0 0.0
.bss 137848 137848 0 0.0
.data 1960 1960 0 0.0
.text 802468 802468 0 0.0
window-app BRD4161A (read only) 791920 791920 0 0.0
(read/write) 122080 122080 0 0.0
.bss 120256 120256 0 0.0
.data 1824 1824 0 0.0
.text 791912 791912 0 0.0
esp32 all-clusters-app c3devkit (read only) 856438 856438 0 0.0
(read/write) 1304266 1304266 0 0.0
.dram0.bss 64680 64680 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 172424 172424 0 0.0
.flash.text 856438 856438 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 960079 960535 456 0.0
(read/write) 449992 450096 104 0.0
.dram0.bss 73960 73968 8 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210196 210292 96 0.0
.flash.text 954695 955151 456 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669632 669632 0 0.0
.bss 73856 73856 0 0.0
.data 1892 1892 0 0.0
.text 588084 588084 0 0.0
lock-app k32w061+debug (read/write) 619584 619584 0 0.0
.bss 72008 72008 0 0.0
.data 1852 1852 0 0.0
.text 539924 539924 0 0.0
shell k32w061+debug (read/write) 624904 624904 0 0.0
.bss 74316 74316 0 0.0
.data 1832 1832 0 0.0
.text 542956 542956 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6861276 6861276 0 0.0
(read/write) 318657 318657 0 0.0
.bss 51889 51889 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208384 208384 0 0.0
.dynamic 560 560 0 0.0
.got 53456 53456 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364972 364972 0 0.0
.text 5816212 5816212 0 0.0
thermostat-no-ble arm64 (read only) 1947956 1947956 0 0.0
(read/write) 137185 137185 0 0.0
.bss 59505 59505 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70344 70344 0 0.0
.dynamic 560 560 0 0.0
.got 3624 3624 0 0.0
.init 24 24 0 0.0
.init_array 272 272 0 0.0
.rodata 125476 125476 0 0.0
.text 1614704 1614704 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313248 2313248 0 0.0
.bss 183948 183948 0 0.0
.data 5232 5232 0 0.0
.heap 847264 847264 0 0.0
.text 1275824 1275824 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309104 2309104 0 0.0
.bss 175808 175808 0 0.0
.data 5528 5528 0 0.0
.heap 855112 855112 0 0.0
.text 1271704 1271704 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282224 2282224 0 0.0
.bss 174848 174848 0 0.0
.data 5520 5520 0 0.0
.heap 856080 856080 0 0.0
.text 1244824 1244824 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053672 2053672 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016272 1016272 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906939 906939 0 0.0
bss 116280 116280 0 0.0
rodata 101932 101932 0 0.0
text 613144 613144 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 870003 870003 0 0.0
bss 112628 112628 0 0.0
rodata 93228 93228 0 0.0
text 587888 587888 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832938 832938 0 0.0
bss 117656 117656 0 0.0
rodata 97188 97188 0 0.0
text 543572 543572 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 879599 879599 0 0.0
bss 113544 113544 0 0.0
rodata 98048 98048 0 0.0
text 592588 592588 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 805838 805838 0 0.0
bss 114952 114952 0 0.0
rodata 93336 93336 0 0.0
text 523108 523108 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 884535 884535 0 0.0
bss 113456 113456 0 0.0
rodata 99400 99400 0 0.0
text 596180 596180 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 877747 877747 0 0.0
bss 113332 113332 0 0.0
rodata 97540 97540 0 0.0
text 591376 591376 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782283 782283 0 0.0
bss 109624 109624 0 0.0
rodata 74296 74296 0 0.0
text 523852 523852 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697362 697362 0 0.0
bss 110604 110604 0 0.0
rodata 68940 68940 0 0.0
text 444492 444492 0 0.0
p6 all-clusters-app default (read/write) 2359800 2359800 0 0.0
.bss 112148 112148 0 0.0
.data 2520 2520 0 0.0
.heap 918672 918672 0 0.0
.text 1318064 1318064 0 0.0
light-app default (read/write) 2300384 2300384 0 0.0
.bss 101064 101064 0 0.0
.data 2360 2360 0 0.0
.heap 929920 929920 0 0.0
.text 1258648 1258648 0 0.0
lock-app default (read/write) 2276456 2276456 0 0.0
.bss 99944 99944 0 0.0
.data 2328 2328 0 0.0
.heap 931072 931072 0 0.0
.text 1234720 1234720 0 0.0
qpg lighting-app qpg6100+debug (read only) 521412 521412 0 0.0
(read/write) 122336 122336 0 0.0
.bss 82696 82696 0 0.0
.data 992 992 0 0.0
.text 516092 516092 0 0.0
lock-app qpg6100+debug (read only) 495800 495800 0 0.0
(read/write) 122332 122332 0 0.0
.bss 81832 81832 0 0.0
.data 948 948 0 0.0
.text 490480 490480 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 811418 811418 0 0.0
bss 82848 82848 0 0.0
noinit 37160 37160 0 0.0
text 566528 566528 0 0.0

@andy31415 andy31415 merged commit 6c928f4 into project-chip:master Dec 13, 2021
@shubhamdp shubhamdp deleted the bdx_fixes branch December 17, 2021 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chshu chshu Awaiting requested review from chshu

@dhrishi dhrishi Awaiting requested review from dhrishi

@gjc13 gjc13 Awaiting requested review from gjc13

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BDX: Add BlockCount field to BlockData Add BlockQueryWithSkip to BDX messages
3 participants
@shubhamdp @woody-apple @andy31415