Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDX: Add BlockCount field to BlockData #11292

Closed
holbrookt opened this issue Nov 1, 2021 · 0 comments · Fixed by #12767
Closed

BDX: Add BlockCount field to BlockData #11292

holbrookt opened this issue Nov 1, 2021 · 0 comments · Fixed by #12767

Comments

@holbrookt
Copy link
Contributor

Problem

TransferSession emits BlockData structs when it receives a Block message from a BDX exchange. This BlockData struct does not currently include the BlockCount field, since only Synchronous BDX is implemented right now, so Blocks will always come one at a time.

Once Asynchronous BDX is implemented, BlockData will need to also contain the BlockCount field, since it is not guaranteed that messages will come in order. The application will need to order them using BlockCount.

Proposed Solution

  • add BlockCount to BlockData struct
  • make sure BlockCount is filled in when Block messages are received, and also modify existing unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant