Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTA] Use CASESessionManager to establish CASE sessions from OTARequestor class #12636

Merged
merged 1 commit into from
Dec 9, 2021
Merged

[OTA] Use CASESessionManager to establish CASE sessions from OTARequestor class #12636

merged 1 commit into from
Dec 9, 2021

Conversation

carol-apple
Copy link
Contributor

Problem

The ota-requestor-app requires the users of this app to pass in the IP address of the provider it wants to query image from. It uses OperationalDeviceProxy object directly and passes the IP address to that object. This should not be needed as IP address should be resolved from a node ID.

Fixes: #11060

Change overview

The ota-requestor-app now uses the CASESessionManager to establish a CASE session to the provider.

Testing

Manually testing on Linux:

./out/debug/chip-ota-provider-app -f test.bin
./out/chip-tool pairing onnetwork 1 20202021
./out/debug/chip-ota-requestor-app -d 30 -u 5550
./out/chip-tool pairing onnetwork-long 2 20202021 30
./out/chip-tool otasoftwareupdaterequestor announce-ota-provider 1 0 0 2 0

@todo
Copy link

todo bot commented Dec 6, 2021

This uses the current node as the provider to supply the OTA image. This can be configurable such that the provider

connectedhomeip/examples/ota-provider-app/ota-provider-common/OTAProviderExample.cpp

Lines 122 to 132 in bc59676

// TODO: This uses the current node as the provider to supply the OTA image. This can be configurable such that the provider
// supplying the response is not the provider supplying the OTA image.
FabricIndex fabricIndex = commandObj->GetExchangeContext()->GetSessionHandle().GetFabricIndex();
FabricInfo * fabricInfo = Server::GetInstance().GetFabricTable().FindFabricWithIndex(fabricIndex);
NodeId nodeId = fabricInfo->GetPeerId().GetNodeId();
// Only doing BDX transport for now
GenerateBdxUri(nodeId, Span<char>(mOTAFilePath, strlen(mOTAFilePath)), Span<char>(uriBuf, kUriMaxLen), kUriMaxLen);
ChipLogDetail(SoftwareUpdate, "generated URI: %.*s", static_cast<int>(strlen(uriBuf)), uriBuf);
}

This comment was generated by todo based on a TODO comment in bc59676 in #12636. cc @carol-apple.

@todo
Copy link

todo bot commented Dec 6, 2021

Revisit who should be set as the resolver delegate

connectedhomeip/src/app/CASESessionManager.h

Lines 57 to 61 in bc59676

// TODO: Revisit who should be set as the resolver delegate
Dnssd::Resolver::Instance().SetResolverDelegate(this);
}
virtual ~CASESessionManager() {}

This comment was generated by todo based on a TODO comment in bc59676 in #12636. cc @carol-apple.

@todo
Copy link

todo bot commented Dec 6, 2021

Add unit tests for parsing BDX URI

connectedhomeip/src/app/clusters/ota-requestor/OTARequestor.cpp

Lines 95 to 105 in bc59676

// TODO: Add unit tests for parsing BDX URI
CHIP_ERROR OTARequestor::ParseBdxUri(CharSpan uri, NodeId & nodeId, CharSpan & fileDesignator)
{
// Check against minimum length of a valid BDX URI
if (uri.size() < kValidBdxUriMinLen)
{
ChipLogError(SoftwareUpdate, "Expect BDX URI to be at least %d in length, actual length is %zu", kValidBdxUriMinLen,
uri.size());
return CHIP_ERROR_INVALID_STRING_LENGTH;
}

This comment was generated by todo based on a TODO comment in bc59676 in #12636. cc @carol-apple.

@todo
Copy link

todo bot commented Dec 6, 2021

Add download protocol not supported

connectedhomeip/src/app/clusters/ota-requestor/OTARequestor.cpp

Lines 176 to 186 in bc59676

// TODO: Add download protocol not supported
default:
break;
}
}
void OTARequestor::OnQueryImageFailure(void * context, EmberAfStatus status)
{
ChipLogDetail(SoftwareUpdate, "QueryImage failure response %" PRIu8, status);
}

This comment was generated by todo based on a TODO comment in bc59676 in #12636. cc @carol-apple.

@todo
Copy link

todo bot commented Dec 6, 2021

this should be OTADownloader

connectedhomeip/src/app/clusters/ota-requestor/OTARequestor.h

Lines 193 to 197 in bc59676

BDXDownloader * mBdxDownloader = nullptr; // TODO: this should be OTADownloader
BDXMessenger mBdxMessenger; // TODO: ideally this is held by the application
};
} // namespace chip

This comment was generated by todo based on a TODO comment in bc59676 in #12636. cc @carol-apple.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12636: Size comparison from e4f3246 to b3c775e

Increases above 0.2%:

platform target config section e4f3246 b3c775e change % change
linux chip-tool-ipv6only arm64 (read/write) 310977 350641 39664 12.8
.bss 51665 91329 39664 76.8
thermostat-no-ble arm64 (read only) 1932044 1959324 27280 1.4
(read/write) 136465 179041 42576 31.2
.bss 59457 101073 41616 70.0
.data.rel.ro 69840 70704 864 1.2
.got 3528 3624 96 2.7
.rodata 124988 125884 896 0.7
.text 1601088 1625312 24224 1.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2319536 2333352 13816 0.6
.bss 186900 221156 34256 18.3
.text 1282112 1295928 13816 1.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2305736 2319816 14080 0.6
.bss 175712 211888 36176 20.6
.text 1268336 1282416 14080 1.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2278720 2292736 14016 0.6
.bss 174752 210928 36176 20.7
.text 1241320 1255336 14016 1.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 903055 942883 39828 4.4
bss 116184 149544 33360 28.7
rodata 101208 101772 564 0.6
text 610104 615996 5892 1.0
nrf52840dk_nrf52840+rpc (read/write) 866079 905907 39828 4.6
bss 112532 145892 33360 29.6
rodata 92504 93068 564 0.6
text 584832 590724 5892 1.0
nrf5340dk_nrf5340_cpuapp (read/write) 829046 868874 39828 4.8
bss 117560 150920 33360 28.4
rodata 96464 97028 564 0.6
text 540532 546428 5896 1.1
lock-app nrf52840dk_nrf52840 (read/write) 875523 917447 41924 4.8
bss 113448 148724 35276 31.1
rodata 97324 97888 564 0.6
text 589364 595456 6092 1.0
nrf5340dk_nrf5340_cpuapp (read/write) 801754 843682 41928 5.2
bss 114856 150132 35276 30.7
rodata 92612 93180 568 0.6
text 519884 525980 6096 1.2
pump-app nrf52840dk_nrf52840 (read/write) 880371 922299 41928 4.8
bss 113360 148636 35276 31.1
rodata 98676 99244 568 0.6
text 592880 598972 6092 1.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 873599 915523 41924 4.8
bss 113236 148512 35276 31.2
rodata 96816 97380 564 0.6
text 588100 594192 6092 1.0
p6 all-clusters-app default (read/write) 2355624 2373136 17512 0.7
.bss 113132 149308 36176 32.0
.text 1313888 1331400 17512 1.3
light-app default (read/write) 2290408 2307928 17520 0.8
.bss 100904 137080 36176 35.9
.text 1248672 1266192 17520 1.4
lock-app default (read/write) 2266512 2284008 17496 0.8
.bss 99784 135960 36176 36.3
.data 2288 2296 8 0.3
.text 1224776 1242272 17496 1.4
Increases (15 builds for linux, mbed, nrfconnect, p6)
platform target config section e4f3246 b3c775e change % change
linux chip-tool-ipv6only arm64 (read only) 6732084 6732164 80 0.0
(read/write) 310977 350641 39664 12.8
.bss 51665 91329 39664 76.8
.text 5731988 5732068 80 0.0
thermostat-no-ble arm64 (read only) 1932044 1959324 27280 1.4
(read/write) 136465 179041 42576 31.2
.bss 59457 101073 41616 70.0
.data.rel.ro 69840 70704 864 1.2
.got 3528 3624 96 2.7
.rodata 124988 125884 896 0.7
.text 1601088 1625312 24224 1.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2319536 2333352 13816 0.6
.bss 186900 221156 34256 18.3
.data 5232 5240 8 0.2
.text 1282112 1295928 13816 1.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2305736 2319816 14080 0.6
.bss 175712 211888 36176 20.6
.data 5488 5496 8 0.1
.text 1268336 1282416 14080 1.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2278720 2292736 14016 0.6
.bss 174752 210928 36176 20.7
.data 5488 5496 8 0.1
.text 1241320 1255336 14016 1.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 903055 942883 39828 4.4
bss 116184 149544 33360 28.7
rodata 101208 101772 564 0.6
text 610104 615996 5892 1.0
nrf52840dk_nrf52840+rpc (read/write) 866079 905907 39828 4.6
bss 112532 145892 33360 29.6
rodata 92504 93068 564 0.6
text 584832 590724 5892 1.0
nrf5340dk_nrf5340_cpuapp (read/write) 829046 868874 39828 4.8
bss 117560 150920 33360 28.4
rodata 96464 97028 564 0.6
text 540532 546428 5896 1.1
lock-app nrf52840dk_nrf52840 (read/write) 875523 917447 41924 4.8
bss 113448 148724 35276 31.1
rodata 97324 97888 564 0.6
text 589364 595456 6092 1.0
nrf5340dk_nrf5340_cpuapp (read/write) 801754 843682 41928 5.2
bss 114856 150132 35276 30.7
rodata 92612 93180 568 0.6
text 519884 525980 6096 1.2
pump-app nrf52840dk_nrf52840 (read/write) 880371 922299 41928 4.8
bss 113360 148636 35276 31.1
rodata 98676 99244 568 0.6
text 592880 598972 6092 1.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 873599 915523 41924 4.8
bss 113236 148512 35276 31.2
rodata 96816 97380 564 0.6
text 588100 594192 6092 1.0
p6 all-clusters-app default (read/write) 2355624 2373136 17512 0.7
.bss 113132 149308 36176 32.0
.text 1313888 1331400 17512 1.3
light-app default (read/write) 2290408 2307928 17520 0.8
.bss 100904 137080 36176 35.9
.text 1248672 1266192 17520 1.4
lock-app default (read/write) 2266512 2284008 17496 0.8
.bss 99784 135960 36176 36.3
.data 2288 2296 8 0.3
.text 1224776 1242272 17496 1.4
Decreases (6 builds for mbed, p6)
platform target config section e4f3246 b3c775e change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 844312 810048 -34264 -4.1
lighting-app CY8CPROTO_062_4343W+release .heap 855248 819064 -36184 -4.2
lock-app CY8CPROTO_062_4343W+release .heap 856208 820024 -36184 -4.2
p6 all-clusters-app default .heap 917696 881520 -36176 -3.9
light-app default .heap 930112 893936 -36176 -3.9
lock-app default .heap 931272 895088 -36184 -3.9
Full report (20 builds for linux, mbed, nrfconnect, p6)
platform target config section e4f3246 b3c775e change % change
linux chip-tool-ipv6only arm64 (read only) 6732084 6732164 80 0.0
(read/write) 310977 350641 39664 12.8
.bss 51665 91329 39664 76.8
.data 1048 1048 0 0.0
.data.rel.ro 206592 206592 0 0.0
.dynamic 560 560 0 0.0
.got 48040 48040 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 341796 341796 0 0.0
.text 5731988 5732068 80 0.0
thermostat-no-ble arm64 (read only) 1932044 1959324 27280 1.4
(read/write) 136465 179041 42576 31.2
.bss 59457 101073 41616 70.0
.data 776 776 0 0.0
.data.rel.ro 69840 70704 864 1.2
.dynamic 560 560 0 0.0
.got 3528 3624 96 2.7
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124988 125884 896 0.7
.text 1601088 1625312 24224 1.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319536 2333352 13816 0.6
.bss 186900 221156 34256 18.3
.data 5232 5240 8 0.2
.heap 844312 810048 -34264 -4.1
.text 1282112 1295928 13816 1.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305736 2319816 14080 0.6
.bss 175712 211888 36176 20.6
.data 5488 5496 8 0.1
.heap 855248 819064 -36184 -4.2
.text 1268336 1282416 14080 1.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2278720 2292736 14016 0.6
.bss 174752 210928 36176 20.7
.data 5488 5496 8 0.1
.heap 856208 820024 -36184 -4.2
.text 1241320 1255336 14016 1.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047808 2047808 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010408 1010408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 903055 942883 39828 4.4
bss 116184 149544 33360 28.7
rodata 101208 101772 564 0.6
text 610104 615996 5892 1.0
nrf52840dk_nrf52840+rpc (read/write) 866079 905907 39828 4.6
bss 112532 145892 33360 29.6
rodata 92504 93068 564 0.6
text 584832 590724 5892 1.0
nrf5340dk_nrf5340_cpuapp (read/write) 829046 868874 39828 4.8
bss 117560 150920 33360 28.4
rodata 96464 97028 564 0.6
text 540532 546428 5896 1.1
lock-app nrf52840dk_nrf52840 (read/write) 875523 917447 41924 4.8
bss 113448 148724 35276 31.1
rodata 97324 97888 564 0.6
text 589364 595456 6092 1.0
nrf5340dk_nrf5340_cpuapp (read/write) 801754 843682 41928 5.2
bss 114856 150132 35276 30.7
rodata 92612 93180 568 0.6
text 519884 525980 6096 1.2
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 880371 922299 41928 4.8
bss 113360 148636 35276 31.1
rodata 98676 99244 568 0.6
text 592880 598972 6092 1.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 873599 915523 41924 4.8
bss 113236 148512 35276 31.2
rodata 96816 97380 564 0.6
text 588100 594192 6092 1.0
shell nrf52840dk_nrf52840 (read/write) 781611 781611 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523264 523264 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696686 696686 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443904 443904 0 0.0
p6 all-clusters-app default (read/write) 2355624 2373136 17512 0.7
.bss 113132 149308 36176 32.0
.data 2512 2512 0 0.0
.heap 917696 881520 -36176 -3.9
.text 1313888 1331400 17512 1.3
light-app default (read/write) 2290408 2307928 17520 0.8
.bss 100904 137080 36176 35.9
.data 2328 2328 0 0.0
.heap 930112 893936 -36176 -3.9
.text 1248672 1266192 17520 1.4
lock-app default (read/write) 2266512 2284008 17496 0.8
.bss 99784 135960 36176 36.3
.data 2288 2296 8 0.3
.heap 931272 895088 -36184 -3.9
.text 1224776 1242272 17496 1.4

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

PR #12636: Size comparison from 4584707 to 139f0ac

Increases above 0.2%:

platform target config section 4584707 139f0ac change % change
linux chip-tool-ipv6only arm64 (read/write) 312337 317697 5360 1.7
.bss 51633 56849 5216 10.1
thermostat-no-ble arm64 (read only) 1932068 1959868 27800 1.4
(read/write) 136321 144417 8096 5.9
.bss 59425 66593 7168 12.1
.data.rel.ro 69736 70576 840 1.2
.got 3520 3616 96 2.7
.rodata 124820 125740 920 0.7
.text 1601520 1626256 24736 1.5
telink lighting-app tlsr9518adk80d (read/write) 807462 821826 14364 1.8
bss 82748 89052 6304 7.6
text 563528 570884 7356 1.3
Increases (3 builds for linux, telink)
platform target config section 4584707 139f0ac change % change
linux chip-tool-ipv6only arm64 (read only) 6786028 6788860 2832 0.0
(read/write) 312337 317697 5360 1.7
.bss 51633 56849 5216 10.1
.data.rel.ro 207632 207752 120 0.1
.got 48384 48416 32 0.1
.text 5782004 5784484 2480 0.0
thermostat-no-ble arm64 (read only) 1932068 1959868 27800 1.4
(read/write) 136321 144417 8096 5.9
.bss 59425 66593 7168 12.1
.data.rel.ro 69736 70576 840 1.2
.got 3520 3616 96 2.7
.rodata 124820 125740 920 0.7
.text 1601520 1626256 24736 1.5
telink lighting-app tlsr9518adk80d (read/write) 807462 821826 14364 1.8
bss 82748 89052 6304 7.6
text 563528 570884 7356 1.3
Full report (3 builds for linux, telink)
platform target config section 4584707 139f0ac change % change
linux chip-tool-ipv6only arm64 (read only) 6786028 6788860 2832 0.0
(read/write) 312337 317697 5360 1.7
.bss 51633 56849 5216 10.1
.data 1048 1048 0 0.0
.data.rel.ro 207632 207752 120 0.1
.dynamic 560 560 0 0.0
.got 48384 48416 32 0.1
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 342380 342380 0 0.0
.text 5782004 5784484 2480 0.0
thermostat-no-ble arm64 (read only) 1932068 1959868 27800 1.4
(read/write) 136321 144417 8096 5.9
.bss 59425 66593 7168 12.1
.data 776 776 0 0.0
.data.rel.ro 69736 70576 840 1.2
.dynamic 560 560 0 0.0
.got 3520 3616 96 2.7
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124820 125740 920 0.7
.text 1601520 1626256 24736 1.5
telink lighting-app tlsr9518adk80d (read/write) 807462 821826 14364 1.8
bss 82748 89052 6304 7.6
noinit 37160 37160 0 0.0
text 563528 570884 7356 1.3

@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12636: Size comparison from 4584707 to 2035642

Increases above 0.2%:

platform target config section 4584707 2035642 change % change
linux chip-tool-ipv6only arm64 (read/write) 312337 316417 4080 1.3
.bss 51633 55569 3936 7.6
thermostat-no-ble arm64 (read only) 1932068 1959868 27800 1.4
(read/write) 136321 143137 6816 5.0
.bss 59425 65313 5888 9.9
.data.rel.ro 69736 70576 840 1.2
.got 3520 3616 96 2.7
.rodata 124820 125740 920 0.7
.text 1601520 1626256 24736 1.5
p6 all-clusters-app default (read/write) 2356128 2373624 17496 0.7
.bss 113116 119324 6208 5.5
.text 1314392 1331888 17496 1.3
light-app default (read/write) 2290512 2308016 17504 0.8
.bss 100888 107096 6208 6.2
.text 1248776 1266280 17504 1.4
lock-app default (read/write) 2266376 2283872 17496 0.8
.bss 99768 105976 6208 6.2
.data 2288 2296 8 0.3
.text 1224640 1242136 17496 1.4
qpg lighting-app qpg6100+debug (read only) 517944 524640 6696 1.3
.bss 82616 87928 5312 6.4
.text 512624 519320 6696 1.3
lock-app qpg6100+debug (read only) 491944 498628 6684 1.4
.bss 81752 87064 5312 6.5
.text 486624 493308 6684 1.4
telink lighting-app tlsr9518adk80d (read/write) 807462 820842 13380 1.7
bss 82748 88060 5312 6.4
text 563528 570886 7358 1.3
Increases (8 builds for linux, p6, qpg, telink)
platform target config section 4584707 2035642 change % change
linux chip-tool-ipv6only arm64 (read only) 6786028 6788860 2832 0.0
(read/write) 312337 316417 4080 1.3
.bss 51633 55569 3936 7.6
.data.rel.ro 207632 207752 120 0.1
.got 48384 48416 32 0.1
.text 5782004 5784484 2480 0.0
thermostat-no-ble arm64 (read only) 1932068 1959868 27800 1.4
(read/write) 136321 143137 6816 5.0
.bss 59425 65313 5888 9.9
.data.rel.ro 69736 70576 840 1.2
.got 3520 3616 96 2.7
.rodata 124820 125740 920 0.7
.text 1601520 1626256 24736 1.5
p6 all-clusters-app default (read/write) 2356128 2373624 17496 0.7
.bss 113116 119324 6208 5.5
.text 1314392 1331888 17496 1.3
light-app default (read/write) 2290512 2308016 17504 0.8
.bss 100888 107096 6208 6.2
.text 1248776 1266280 17504 1.4
lock-app default (read/write) 2266376 2283872 17496 0.8
.bss 99768 105976 6208 6.2
.data 2288 2296 8 0.3
.text 1224640 1242136 17496 1.4
qpg lighting-app qpg6100+debug (read only) 517944 524640 6696 1.3
.bss 82616 87928 5312 6.4
.text 512624 519320 6696 1.3
lock-app qpg6100+debug (read only) 491944 498628 6684 1.4
.bss 81752 87064 5312 6.5
.text 486624 493308 6684 1.4
telink lighting-app tlsr9518adk80d (read/write) 807462 820842 13380 1.7
bss 82748 88060 5312 6.4
text 563528 570886 7358 1.3
Decreases (3 builds for p6)
platform target config section 4584707 2035642 change % change
p6 all-clusters-app default .heap 917712 911504 -6208 -0.7
light-app default .heap 930128 923920 -6208 -0.7
lock-app default .heap 931288 925072 -6216 -0.7
Full report (9 builds for linux, p6, qpg, telink)
platform target config section 4584707 2035642 change % change
linux chip-tool-ipv6only arm64 (read only) 6786028 6788860 2832 0.0
(read/write) 312337 316417 4080 1.3
.bss 51633 55569 3936 7.6
.data 1048 1048 0 0.0
.data.rel.ro 207632 207752 120 0.1
.dynamic 560 560 0 0.0
.got 48384 48416 32 0.1
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 342380 342380 0 0.0
.text 5782004 5784484 2480 0.0
thermostat-no-ble arm64 (read only) 1932068 1959868 27800 1.4
(read/write) 136321 143137 6816 5.0
.bss 59425 65313 5888 9.9
.data 776 776 0 0.0
.data.rel.ro 69736 70576 840 1.2
.dynamic 560 560 0 0.0
.got 3520 3616 96 2.7
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124820 125740 920 0.7
.text 1601520 1626256 24736 1.5
p6 all-clusters-app default (read/write) 2356128 2373624 17496 0.7
.bss 113116 119324 6208 5.5
.data 2512 2512 0 0.0
.heap 917712 911504 -6208 -0.7
.text 1314392 1331888 17496 1.3
light-app default (read/write) 2290512 2308016 17504 0.8
.bss 100888 107096 6208 6.2
.data 2328 2328 0 0.0
.heap 930128 923920 -6208 -0.7
.text 1248776 1266280 17504 1.4
lock-app default (read/write) 2266376 2283872 17496 0.8
.bss 99768 105976 6208 6.2
.data 2288 2296 8 0.3
.heap 931288 925072 -6216 -0.7
.text 1224640 1242136 17496 1.4
qpg lighting-app qpg6100+debug (read only) 517944 524640 6696 1.3
(read/write) 122332 122332 0 0.0
.bss 82616 87928 5312 6.4
.data 956 956 0 0.0
.text 512624 519320 6696 1.3
lock-app qpg6100+debug (read only) 491944 498628 6684 1.4
(read/write) 122336 122336 0 0.0
.bss 81752 87064 5312 6.5
.data 912 912 0 0.0
.text 486624 493308 6684 1.4
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807462 820842 13380 1.7
bss 82748 88060 5312 6.4
noinit 37160 37160 0 0.0
text 563528 570886 7358 1.3

@restyled-io restyled-io bot mentioned this pull request Dec 8, 2021
Closed
@gjc13 gjc13 mentioned this pull request Dec 9, 2021
Merged
@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12636: Size comparison from a583812 to a3127d8

Increases (25 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a583812 a3127d8 change % change
efr32 lighting-app BRD4161A (read only) 804092 804156 64 0.0
(read/write) 122988 122996 8 0.0
.bss 121168 121176 8 0.0
.text 804084 804148 64 0.0
BRD4161A+rpc (read only) 791696 791776 80 0.0
(read/write) 139672 139680 8 0.0
.bss 137744 137752 8 0.0
.text 791688 791768 80 0.0
window-app BRD4161A (read only) 780804 780884 80 0.0
(read/write) 121120 121128 8 0.0
.bss 119336 119344 8 0.0
.text 780796 780876 80 0.0
esp32 all-clusters-app c3devkit (read/write) 1306706 1306722 16 0.0
.dram0.bss 67632 67640 8 0.0
m5stack (read/write) 450980 450988 8 0.0
.dram0.bss 75000 75008 8 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724652 724676 24 0.0
.bss 81232 81240 8 0.0
.text 635768 635784 16 0.0
lock-app k32w061+debug (read/write) 615812 615836 24 0.0
.bss 71896 71904 8 0.0
.text 536296 536312 16 0.0
shell k32w061+debug (read/write) 679068 679076 8 0.0
.bss 81596 81604 8 0.0
linux chip-tool-ipv6only arm64 (read only) 6786172 6786188 16 0.0
.text 5782132 5782148 16 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 186884 186892 8 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 175696 175704 8 0.0
lock-app CY8CPROTO_062_4343W+release .bss 174736 174744 8 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 116168 116176 8 0.0
nrf52840dk_nrf52840+rpc bss 112516 112524 8 0.0
nrf5340dk_nrf5340_cpuapp bss 117544 117552 8 0.0
lock-app nrf52840dk_nrf52840 bss 113432 113440 8 0.0
nrf5340dk_nrf5340_cpuapp bss 114840 114848 8 0.0
pump-app nrf52840dk_nrf52840 (read/write) 880455 880487 32 0.0
bss 113344 113352 8 0.0
pump-controller-app nrf52840dk_nrf52840 bss 113220 113228 8 0.0
p6 all-clusters-app default .bss 113116 113124 8 0.0
light-app default .bss 100888 100896 8 0.0
lock-app default .bss 99768 99776 8 0.0
qpg lighting-app qpg6100+debug (read only) 517960 517976 16 0.0
.bss 82616 82624 8 0.0
.text 512640 512656 16 0.0
lock-app qpg6100+debug (read only) 491960 491968 8 0.0
.bss 81752 81760 8 0.0
.text 486640 486648 8 0.0
telink lighting-app tlsr9518adk80d (read/write) 807478 807494 16 0.0
bss 82748 82756 8 0.0
Decreases (11 builds for esp32, mbed, nrfconnect, p6)
platform target config section a583812 a3127d8 change % change
esp32 all-clusters-app m5stack (read only) 962535 962531 -4 -0.0
.flash.text 957151 957147 -4 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2320200 2320136 -64 -0.0
.heap 844328 844320 -8 -0.0
.text 1282776 1282712 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 855264 855256 -8 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 856224 856216 -8 -0.0
nrfconnect lock-app nrf52840dk_nrf52840 text 589452 589448 -4 -0.0
nrf5340dk_nrf5340_cpuapp text 519976 519972 -4 -0.0
pump-app nrf52840dk_nrf52840 text 593044 593040 -4 -0.0
pump-controller-app nrf52840dk_nrf52840 text 588204 588200 -4 -0.0
p6 all-clusters-app default (read/write) 2356232 2356168 -64 -0.0
.heap 917712 917704 -8 -0.0
.text 1314496 1314432 -64 -0.0
light-app default (read/write) 2290528 2290448 -80 -0.0
.heap 930128 930120 -8 -0.0
.text 1248792 1248712 -80 -0.0
lock-app default (read/write) 2266392 2266328 -64 -0.0
.heap 931288 931280 -8 -0.0
.text 1224656 1224592 -64 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a583812 a3127d8 change % change
efr32 lighting-app BRD4161A (read only) 804092 804156 64 0.0
(read/write) 122988 122996 8 0.0
.bss 121168 121176 8 0.0
.data 1820 1820 0 0.0
.text 804084 804148 64 0.0
BRD4161A+rpc (read only) 791696 791776 80 0.0
(read/write) 139672 139680 8 0.0
.bss 137744 137752 8 0.0
.data 1928 1928 0 0.0
.text 791688 791768 80 0.0
window-app BRD4161A (read only) 780804 780884 80 0.0
(read/write) 121120 121128 8 0.0
.bss 119336 119344 8 0.0
.data 1784 1784 0 0.0
.text 780796 780876 80 0.0
esp32 all-clusters-app c3devkit (read only) 859206 859206 0 0.0
(read/write) 1306706 1306722 16 0.0
.dram0.bss 67632 67640 8 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 171920 171920 0 0.0
.flash.text 859206 859206 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 962535 962531 -4 -0.0
(read/write) 450980 450988 8 0.0
.dram0.bss 75000 75008 8 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210144 210144 0 0.0
.flash.text 957151 957147 -4 -0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724652 724676 24 0.0
.bss 81232 81240 8 0.0
.data 1852 1852 0 0.0
.text 635768 635784 16 0.0
lock-app k32w061+debug (read/write) 615812 615836 24 0.0
.bss 71896 71904 8 0.0
.data 1820 1820 0 0.0
.text 536296 536312 16 0.0
shell k32w061+debug (read/write) 679068 679076 8 0.0
.bss 81596 81604 8 0.0
.data 1792 1792 0 0.0
.text 589880 589880 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6786172 6786188 16 0.0
(read/write) 312337 312337 0 0.0
.bss 51633 51633 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 207632 207632 0 0.0
.dynamic 560 560 0 0.0
.got 48384 48384 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 342396 342396 0 0.0
.text 5782132 5782148 16 0.0
thermostat-no-ble arm64 (read only) 1931988 1931988 0 0.0
(read/write) 136337 136337 0 0.0
.bss 59441 59441 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69736 69736 0 0.0
.dynamic 560 560 0 0.0
.got 3520 3520 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124820 124820 0 0.0
.text 1601440 1601440 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2320200 2320136 -64 -0.0
.bss 186884 186892 8 0.0
.data 5232 5232 0 0.0
.heap 844328 844320 -8 -0.0
.text 1282776 1282712 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305992 2305992 0 0.0
.bss 175696 175704 8 0.0
.data 5488 5488 0 0.0
.heap 855264 855256 -8 -0.0
.text 1268592 1268592 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2278720 2278720 0 0.0
.bss 174736 174744 8 0.0
.data 5488 5488 0 0.0
.heap 856224 856216 -8 -0.0
.text 1241320 1241320 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047808 2047808 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010408 1010408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 903299 903299 0 0.0
bss 116168 116176 8 0.0
rodata 101164 101164 0 0.0
text 610392 610392 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 866323 866323 0 0.0
bss 112516 112524 8 0.0
rodata 92460 92460 0 0.0
text 585120 585120 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 829290 829290 0 0.0
bss 117544 117552 8 0.0
rodata 96420 96420 0 0.0
text 540820 540820 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 875527 875527 0 0.0
bss 113432 113440 8 0.0
rodata 97280 97280 0 0.0
text 589452 589448 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801774 801774 0 0.0
bss 114840 114848 8 0.0
rodata 92568 92568 0 0.0
text 519976 519972 -4 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 880455 880487 32 0.0
bss 113344 113352 8 0.0
rodata 98632 98632 0 0.0
text 593044 593040 -4 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 873667 873667 0 0.0
bss 113220 113228 8 0.0
rodata 96772 96772 0 0.0
text 588204 588200 -4 -0.0
shell nrf52840dk_nrf52840 (read/write) 781627 781627 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523280 523280 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696702 696702 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443924 443924 0 0.0
p6 all-clusters-app default (read/write) 2356232 2356168 -64 -0.0
.bss 113116 113124 8 0.0
.data 2512 2512 0 0.0
.heap 917712 917704 -8 -0.0
.text 1314496 1314432 -64 -0.0
light-app default (read/write) 2290528 2290448 -80 -0.0
.bss 100888 100896 8 0.0
.data 2328 2328 0 0.0
.heap 930128 930120 -8 -0.0
.text 1248792 1248712 -80 -0.0
lock-app default (read/write) 2266392 2266328 -64 -0.0
.bss 99768 99776 8 0.0
.data 2288 2288 0 0.0
.heap 931288 931280 -8 -0.0
.text 1224656 1224592 -64 -0.0
qpg lighting-app qpg6100+debug (read only) 517960 517976 16 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82624 8 0.0
.data 956 956 0 0.0
.text 512640 512656 16 0.0
lock-app qpg6100+debug (read only) 491960 491968 8 0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81760 8 0.0
.data 912 912 0 0.0
.text 486640 486648 8 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807478 807494 16 0.0
bss 82748 82756 8 0.0
noinit 37160 37160 0 0.0
text 563540 563540 0 0.0

@carol-apple carol-apple merged commit f18d8b7 into project-chip:master Dec 9, 2021
This was referenced Dec 9, 2021
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 10, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjc13 gjc13 gjc13 approved these changes

@msandstedt msandstedt msandstedt approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@selissia selissia Awaiting requested review from selissia

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app examples lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

This will be redone once the full Requestor app design is in place
7 participants
@carol-apple @tcarmelveilleux @msandstedt @gjc13 @woody-apple @selissia @Damian-Nordic