Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for parsing BDX URI #12774

Closed
todo bot opened this issue Dec 9, 2021 · 1 comment
Closed

Add unit tests for parsing BDX URI #12774

todo bot opened this issue Dec 9, 2021 · 1 comment

Comments

@todo
Copy link

todo bot commented Dec 9, 2021

// TODO: Add unit tests for parsing BDX URI
CHIP_ERROR BDXDownloader::ParseBdxUri(CharSpan uri, NodeId & nodeId, MutableCharSpan fileDesignator)
{
// Check against minimum length of a valid BDX URI
if (uri.size() < kValidBdxUriMinLen)
{
return CHIP_ERROR_INVALID_STRING_LENGTH;
}
uint8_t readValue[kUriMaxLen];
Encoding::LittleEndian::Reader uriReader(reinterpret_cast<const uint8_t *>(uri.data()), uri.size());


This issue was generated by todo based on a TODO comment in a3127d8 when #12636 was merged. cc @carol-apple.
@todo todo bot added the todo label Dec 9, 2021
@carol-apple carol-apple removed the todo label Dec 10, 2021
@carol-apple carol-apple removed their assignment Jan 10, 2022
@carol-apple
Copy link
Contributor

Fixed by: #12784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant