Restyle [OTA] Use CASESessionManager to establish CASE sessions from OTARequestor class

[restyled-io]

A duplicate of #12636 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

• clang-format

To incorporate these changes, you can either:

1. Merge this Pull Request instead of the original, or

2. Ask your contributor to locally incorporate these commits and push them to
   the original Pull Request

   Expand for example instructions

   ```console
   git remote add upstream https://github.com/project-chip/connectedhomeip.git
   git fetch upstream pull/<this PR number>/head
   git merge --ff-only FETCH_HEAD
   git push
   ```
   

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

[todo]

This uses the current node as the provider to supply the OTA image. This can be configurable such that the provider

connectedhomeip/examples/ota-provider-app/ota-provider-common/OTAProviderExample.cpp

Lines 123 to 133 in ea2bf6e

	// TODO: This uses the current node as the provider to supply the OTA image. This can be configurable such that the provider
	// supplying the response is not the provider supplying the OTA image.
	FabricIndex fabricIndex = commandObj->GetExchangeContext()->GetSessionHandle().GetFabricIndex();
	FabricInfo * fabricInfo = Server::GetInstance().GetFabricTable().FindFabricWithIndex(fabricIndex);
	NodeId nodeId = fabricInfo->GetPeerId().GetNodeId();
	// Only doing BDX transport for now
	MutableCharSpan uri(uriBuf, kUriMaxLen);
	GenerateBdxUri(nodeId, CharSpan(mOTAFilePath, strlen(mOTAFilePath)), uri);
	ChipLogDetail(SoftwareUpdate, "Generated URI: %.*s", static_cast<int>(uri.size()), uri.data());
	}

---

This comment was generated by todo based on a TODO comment in ea2bf6e in #12759. cc @project-chip.

[todo]

Revisit who should be set as the resolver delegate

connectedhomeip/src/app/CASESessionManager.h

Lines 60 to 64 in ea2bf6e

	// TODO: Revisit who should be set as the resolver delegate
	Dnssd::Resolver::Instance().SetResolverDelegate(this);
	}
	virtual ~CASESessionManager() {}

---

This comment was generated by todo based on a TODO comment in ea2bf6e in #12759. cc @project-chip.

[todo]

Add unit tests for parsing BDX URI

connectedhomeip/src/app/clusters/ota-requestor/BDXDownloader.cpp

Lines 220 to 230 in ea2bf6e

	// TODO: Add unit tests for parsing BDX URI
	CHIP_ERROR BDXDownloader::ParseBdxUri(CharSpan uri, NodeId & nodeId, MutableCharSpan fileDesignator)
	{
	// Check against minimum length of a valid BDX URI
	if (uri.size() < kValidBdxUriMinLen)
	{
	return CHIP_ERROR_INVALID_STRING_LENGTH;
	}
	uint8_t readValue[kUriMaxLen];
	Encoding::LittleEndian::Reader uriReader(reinterpret_cast<const uint8_t *>(uri.data()), uri.size());

---

This comment was generated by todo based on a TODO comment in ea2bf6e in #12759. cc @project-chip.

[todo]

Add a method to OTARequestorDriver used to report error condictions

connectedhomeip/src/app/clusters/ota-requestor/OTARequestor.cpp

Lines 104 to 114 in ea2bf6e

	// TODO: Add a method to OTARequestorDriver used to report error condictions
	VerifyOrReturn(response.imageURI.HasValue(), ChipLogError(SoftwareUpdate, "Update is available but no image URI present"));
	// Parse out the provider node ID and file designator from the image URI
	NodeId nodeId = kUndefinedNodeId;
	char fileDesignatorBuffer[kUriMaxLen] = { 0 };
	MutableCharSpan fileDesignator(fileDesignatorBuffer, kUriMaxLen);
	CHIP_ERROR err = requestorCore->mBdxDownloader->ParseBdxUri(response.imageURI.Value(), nodeId, fileDesignator);
	VerifyOrReturn(err == CHIP_NO_ERROR,
	ChipLogError(SoftwareUpdate, "Parse BDX image URI (%.*s) returned err=%" CHIP_ERROR_FORMAT,
	static_cast<int>(response.imageURI.Value().size()), response.imageURI.Value().data(),

---

This comment was generated by todo based on a TODO comment in ea2bf6e in #12759. cc @project-chip.

[todo]

Add download protocol not supported

connectedhomeip/src/app/clusters/ota-requestor/OTARequestor.cpp

Lines 127 to 137 in ea2bf6e

	// TODO: Add download protocol not supported
	// Issue #9524 should handle all response status appropriately
	default:
	break;
	}
	}
	void OTARequestor::OnQueryImageFailure(void * context, EmberAfStatus status)
	{
	ChipLogDetail(SoftwareUpdate, "QueryImage failure response %" PRIu8, status);
	}

---

This comment was generated by todo based on a TODO comment in ea2bf6e in #12759. cc @project-chip.

[todo]

this should be OTADownloader

connectedhomeip/src/app/clusters/ota-requestor/OTARequestor.h

Lines 196 to 201 in ea2bf6e

	BDXDownloader * mBdxDownloader = nullptr; // TODO: this should be OTADownloader
	BDXMessenger mBdxMessenger; // TODO: ideally this is held by the application
	Server * mServer = nullptr;
	};
	} // namespace chip

---

This comment was generated by todo based on a TODO comment in ea2bf6e in #12759. cc @project-chip.

[todo]

ideally this is held by the application

connectedhomeip/src/app/clusters/ota-requestor/OTARequestor.h

Lines 197 to 201 in ea2bf6e

	BDXMessenger mBdxMessenger; // TODO: ideally this is held by the application
	Server * mServer = nullptr;
	};
	} // namespace chip

---

This comment was generated by todo based on a TODO comment in ea2bf6e in #12759. cc @project-chip.